components/navigation_interception/intercept_navigation_delegate.cc is still using net::URLRequest directly. To be compatible with the network service, we should remove this dependency.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a0e4299be00fe90fb0bb41641666440d5ea4b8e5 commit a0e4299be00fe90fb0bb41641666440d5ea4b8e5 Author: Clark DuVall <cduvall@chromium.org> Date: Mon Sep 17 17:00:11 2018 Remove dependency on net::URLRequest in InterceptNavigationDelegate This moves the UpdateUserGestureCarryoverInfo calls from ResourceDispatcherHostDelegate (which is not used with network service enabled) to ResourceDispatcher. ResourceDispatcher will then pass the info back to the browser through a mojo call. We should not depend on net::URLRequest anywhere outside of the network service. This fixes InterceptNavigationDelegateTests when run with network service enabled. Bug: 882060 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ib737185d5e1f09063bdad0be20a68171a920c975 Reviewed-on: https://chromium-review.googlesource.com/1217347 Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#591711} [modify] https://crrev.com/a0e4299be00fe90fb0bb41641666440d5ea4b8e5/android_webview/browser/aw_web_contents_delegate.cc [modify] https://crrev.com/a0e4299be00fe90fb0bb41641666440d5ea4b8e5/android_webview/browser/aw_web_contents_delegate.h [modify] https://crrev.com/a0e4299be00fe90fb0bb41641666440d5ea4b8e5/android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc [modify] https://crrev.com/a0e4299be00fe90fb0bb41641666440d5ea4b8e5/chrome/browser/android/tab_web_contents_delegate_android.cc [modify] https://crrev.com/a0e4299be00fe90fb0bb41641666440d5ea4b8e5/chrome/browser/android/tab_web_contents_delegate_android.h [modify] https://crrev.com/a0e4299be00fe90fb0bb41641666440d5ea4b8e5/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc [modify] https://crrev.com/a0e4299be00fe90fb0bb41641666440d5ea4b8e5/components/navigation_interception/DEPS [modify] https://crrev.com/a0e4299be00fe90fb0bb41641666440d5ea4b8e5/components/navigation_interception/intercept_navigation_delegate.cc [modify] https://crrev.com/a0e4299be00fe90fb0bb41641666440d5ea4b8e5/components/navigation_interception/intercept_navigation_delegate.h [modify] https://crrev.com/a0e4299be00fe90fb0bb41641666440d5ea4b8e5/content/browser/frame_host/render_frame_host_delegate.h [modify] https://crrev.com/a0e4299be00fe90fb0bb41641666440d5ea4b8e5/content/browser/frame_host/render_frame_host_impl.cc [modify] https://crrev.com/a0e4299be00fe90fb0bb41641666440d5ea4b8e5/content/browser/frame_host/render_frame_host_impl.h [modify] https://crrev.com/a0e4299be00fe90fb0bb41641666440d5ea4b8e5/content/browser/web_contents/web_contents_impl.cc [modify] https://crrev.com/a0e4299be00fe90fb0bb41641666440d5ea4b8e5/content/browser/web_contents/web_contents_impl.h [modify] https://crrev.com/a0e4299be00fe90fb0bb41641666440d5ea4b8e5/content/common/frame.mojom [modify] https://crrev.com/a0e4299be00fe90fb0bb41641666440d5ea4b8e5/content/public/browser/web_contents_delegate.h [modify] https://crrev.com/a0e4299be00fe90fb0bb41641666440d5ea4b8e5/content/renderer/loader/resource_dispatcher.cc [modify] https://crrev.com/a0e4299be00fe90fb0bb41641666440d5ea4b8e5/content/test/test_render_frame.cc [modify] https://crrev.com/a0e4299be00fe90fb0bb41641666440d5ea4b8e5/testing/buildbot/filters/mojo.fyi.network_chrome_public_test_apk.filter
Comment 1 by cduvall@chromium.org
, Sep 7