Tap the wallpaper area will not dismiss the auto hide shelf. |
||||||
Issue descriptionWhat steps will reproduce the problem? (1) Set shelf to "Autohide shelf". (2) Open a window, keep it as not maximized. (3) Swipe up to show the shelf. (4) Tap wallpaper area. What is the expected result? Hide shelf. What happens instead? Shelf is still shown.
,
Sep 7
You're referring to laptop mode here, right? Sounds correct to me. What happens with mouse in this situation?
,
Sep 7
Yes, Ben. Mouse move will always hide the shelf.
,
Sep 8
Thanks, your expected behavior is what I would expect, too. kejiashao@, sgabriel@, thoughts?
,
Sep 8
I agree. This described expected behavior is correct.
,
Sep 13
,
Oct 15
Bulk moving all M-71 <P-1's to M-72.
,
Oct 15
,
Nov 20
,
Nov 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b5d22b702903e7bc9b1bc87ffe89b58bfc37c4e7 commit b5d22b702903e7bc9b1bc87ffe89b58bfc37c4e7 Author: Min Chen <minch@google.com> Date: Wed Nov 21 01:41:21 2018 Tap to hide the AUTO_HIDE_SHOWN shelf. Currently we can see AUTO_HIDE_SHOWN shelf can be hidden when tap inside some of the apps, e.g, chrome browser. That is because of the window hierarchy, stacking changes or set bounds for the child windows. Tap inside of some the apps like "Files" or Wallpaper can't hide the AUTO_HIDE_SHOWN shelf since we don't have the related logic for TAP event. This cl adds the logic that tap outside of the AUTO_HIDE_SHOWN shelf to hide it. Bug: 882059 , b/119322652 Change-Id: I8fc5b6d06a885a7b77280cbf86de4d830c04a296 Reviewed-on: https://chromium-review.googlesource.com/c/1343511 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#609885} [modify] https://crrev.com/b5d22b702903e7bc9b1bc87ffe89b58bfc37c4e7/ash/shelf/shelf.cc [modify] https://crrev.com/b5d22b702903e7bc9b1bc87ffe89b58bfc37c4e7/ash/shelf/shelf_layout_manager.cc [modify] https://crrev.com/b5d22b702903e7bc9b1bc87ffe89b58bfc37c4e7/ash/shelf/shelf_layout_manager.h [modify] https://crrev.com/b5d22b702903e7bc9b1bc87ffe89b58bfc37c4e7/ash/shelf/shelf_layout_manager_unittest.cc
,
Nov 21
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by minch@chromium.org
, Sep 7