New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 882050 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 11
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Write unit tests for new functionality in AppList autocomplete

Project Member Reported by oxyflush@chromium.org, Sep 7

Issue description

These new interactions were landed in a separate CL:
1. Autocomplete suggestions are accepted if SearchBoxView is clicked.
2. Autocomplete suggestions are accepted if SearchBoxView is tapped through a GestureEvent.

The tests are landed in a separate CL since they had lower priority than other tasks, and time is limited.
 
Status: Fixed (was: Started)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c04fd53a98b6d5e12f27306a1290080eac50cc94

commit c04fd53a98b6d5e12f27306a1290080eac50cc94
Author: Daniel Zhang <oxyflush@google.com>
Date: Tue Sep 11 18:04:16 2018

cros: Add unit tests for autocomplete gesture and mouse events.

1. Functionality was landed in separate CLs.
2. Refactoring existing unit tests to make it simpler to land
additional unit tests in the future.

Bug:  882050 
Change-Id: I86fa9ebb457f9f17342ce88bc1c3fc7edd274e07
Reviewed-on: https://chromium-review.googlesource.com/1213518
Commit-Queue: Daniel Zhang <oxyflush@google.com>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590397}
[modify] https://crrev.com/c04fd53a98b6d5e12f27306a1290080eac50cc94/ash/app_list/views/search_box_view_unittest.cc

Sign in to add a comment