"ChromeLauncherControllerWithArcTest.ArcCustomAppIcon/1" is flaky |
||||
Issue description"ChromeLauncherControllerWithArcTest.ArcCustomAppIcon/1" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 4 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyQQsSBUZsYWtlIjZDaHJvbWVMYXVuY2hlckNvbnRyb2xsZXJXaXRoQXJjVGVzdC5BcmNDdXN0b21BcHBJY29uLzEM. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Sep 10
Well, revert does not mean fixed.
,
Sep 10
Revert does mean no longer sheriffs' problem though :)
,
Sep 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4c8d038112ca80e0f63885273c3e9ffc5d54ea72 commit 4c8d038112ca80e0f63885273c3e9ffc5d54ea72 Author: khmel@chromium.org <khmel@chromium.org> Date: Mon Sep 10 21:31:37 2018 Reland "arc: Fix shelf item icon flickering on app start." This reverts commit 373854345147a28fac7c7796f1e86c186a0889fc. (Test flakiness fixed) When app is pinned, icon image is loaded via controller using loader owner by chrome launcher controller. Once new ARC app window appears in the system, it's icon is loaded asynchronously. In this flow, default app icon is applied first and then, once real image is loaded final icon is set. Each update of ARC window icon is reflected on shelf. That means default app icon appear on the shelf for a moment and in most cases this is very noticeable. This CL prevents setting default app in favor of final app icon and default icon is set only as a fallback when final icon could not be loaded. TEST=Manual BUG= 882048 BUG= 882043 Bug: b:114246197 TBR=xiyuan@chromium.org,jdonnelly@chromium.org,khmel@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ic2015afe42b4b3aacd05a307350e643a6967d3e8 Reviewed-on: https://chromium-review.googlesource.com/1216721 Commit-Queue: Yury Khmel <khmel@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#590071} [modify] https://crrev.com/4c8d038112ca80e0f63885273c3e9ffc5d54ea72/chrome/browser/ui/ash/launcher/arc_app_window.cc [modify] https://crrev.com/4c8d038112ca80e0f63885273c3e9ffc5d54ea72/chrome/browser/ui/ash/launcher/arc_app_window.h [modify] https://crrev.com/4c8d038112ca80e0f63885273c3e9ffc5d54ea72/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc
,
Sep 11
|
||||
►
Sign in to add a comment |
||||
Comment 1 by yhirano@chromium.org
, Sep 10Owner: khmel@chromium.org
Status: Fixed (was: Untriaged)