Inline installation is deprecated, and we are removing support in M71. We should remove the code.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c4fb02304cc8ee7c6896f860f52fef72db1f069a commit c4fb02304cc8ee7c6896f860f52fef72db1f069a Author: Benjamin Ackerman <ackermanb@chromium.org> Date: Wed Oct 03 19:55:41 2018 [Extensions] Obliterating the inline install API. Removing everything associated with inline installation as it is deprecated per the announcement in https://blog.chromium.org/2018/06/improving-extension-transparency-for.html Bug: 882045 Change-Id: Ia24cb4076a841d9b37febe68cad89db7ea1ce1c8 Reviewed-on: https://chromium-review.googlesource.com/c/1220299 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Chris Palmer <palmer@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Benjamin Ackerman <ackermanb@chromium.org> Cr-Commit-Position: refs/heads/master@{#596334} [modify] https://crrev.com/c4fb02304cc8ee7c6896f860f52fef72db1f069a/chrome/browser/chrome_content_browser_manifest_overlay.json [modify] https://crrev.com/c4fb02304cc8ee7c6896f860f52fef72db1f069a/chrome/browser/extensions/BUILD.gn [modify] https://crrev.com/c4fb02304cc8ee7c6896f860f52fef72db1f069a/chrome/browser/extensions/api/inline_install_private/inline_install_private_api.cc [modify] https://crrev.com/c4fb02304cc8ee7c6896f860f52fef72db1f069a/chrome/browser/extensions/api/webstore_widget_private/app_installer.cc [modify] https://crrev.com/c4fb02304cc8ee7c6896f860f52fef72db1f069a/chrome/browser/extensions/api/webstore_widget_private/app_installer.h [modify] https://crrev.com/c4fb02304cc8ee7c6896f860f52fef72db1f069a/chrome/browser/extensions/extension_install_prompt.cc [modify] https://crrev.com/c4fb02304cc8ee7c6896f860f52fef72db1f069a/chrome/browser/extensions/extension_install_prompt.h [delete] https://crrev.com/35421cb5ddd7aa5d05b2ef4d46b75ee949c590da/chrome/browser/extensions/extension_reenabler.cc [delete] https://crrev.com/35421cb5ddd7aa5d05b2ef4d46b75ee949c590da/chrome/browser/extensions/extension_reenabler.h [delete] https://crrev.com/35421cb5ddd7aa5d05b2ef4d46b75ee949c590da/chrome/browser/extensions/extension_reenabler_unittest.cc [modify] https://crrev.com/c4fb02304cc8ee7c6896f860f52fef72db1f069a/chrome/browser/extensions/tab_helper.cc [modify] https://crrev.com/c4fb02304cc8ee7c6896f860f52fef72db1f069a/chrome/browser/extensions/tab_helper.h [modify] https://crrev.com/c4fb02304cc8ee7c6896f860f52fef72db1f069a/chrome/browser/extensions/webstore_data_fetcher.cc [modify] https://crrev.com/c4fb02304cc8ee7c6896f860f52fef72db1f069a/chrome/browser/extensions/webstore_data_fetcher.h [modify] https://crrev.com/c4fb02304cc8ee7c6896f860f52fef72db1f069a/chrome/browser/extensions/webstore_data_fetcher_delegate.cc [modify] https://crrev.com/c4fb02304cc8ee7c6896f860f52fef72db1f069a/chrome/browser/extensions/webstore_data_fetcher_delegate.h [delete] https://crrev.com/35421cb5ddd7aa5d05b2ef4d46b75ee949c590da/chrome/browser/extensions/webstore_inline_installer.cc [delete] https://crrev.com/35421cb5ddd7aa5d05b2ef4d46b75ee949c590da/chrome/browser/extensions/webstore_inline_installer.h [delete] https://crrev.com/35421cb5ddd7aa5d05b2ef4d46b75ee949c590da/chrome/browser/extensions/webstore_inline_installer_browsertest.cc [delete] https://crrev.com/35421cb5ddd7aa5d05b2ef4d46b75ee949c590da/chrome/browser/extensions/webstore_inline_installer_factory.cc [delete] https://crrev.com/35421cb5ddd7aa5d05b2ef4d46b75ee949c590da/chrome/browser/extensions/webstore_inline_installer_factory.h [delete] https://crrev.com/35421cb5ddd7aa5d05b2ef4d46b75ee949c590da/chrome/browser/extensions/webstore_inline_installer_unittest.cc [modify] https://crrev.com/c4fb02304cc8ee7c6896f860f52fef72db1f069a/chrome/browser/extensions/webstore_install_with_prompt.cc [modify] https://crrev.com/c4fb02304cc8ee7c6896f860f52fef72db1f069a/chrome/browser/extensions/webstore_install_with_prompt.h [modify] https://crrev.com/c4fb02304cc8ee7c6896f860f52fef72db1f069a/chrome/browser/extensions/webstore_installer.h [modify] https://crrev.com/c4fb02304cc8ee7c6896f860f52fef72db1f069a/chrome/browser/extensions/webstore_installer_test.cc [modify] https://crrev.com/c4fb02304cc8ee7c6896f860f52fef72db1f069a/chrome/browser/extensions/webstore_installer_unittest.cc [modify] https://crrev.com/c4fb02304cc8ee7c6896f860f52fef72db1f069a/chrome/browser/extensions/webstore_reinstaller.cc [modify] https://crrev.com/c4fb02304cc8ee7c6896f860f52fef72db1f069a/chrome/browser/extensions/webstore_reinstaller.h [modify] https://crrev.com/c4fb02304cc8ee7c6896f860f52fef72db1f069a/chrome/browser/extensions/webstore_standalone_installer.cc [modify] https://crrev.com/c4fb02304cc8ee7c6896f860f52fef72db1f069a/chrome/browser/extensions/webstore_standalone_installer.h [delete] https://crrev.com/35421cb5ddd7aa5d05b2ef4d46b75ee949c590da/chrome/browser/extensions/webstore_startup_installer.cc [delete] https://crrev.com/35421cb5ddd7aa5d05b2ef4d46b75ee949c590da/chrome/browser/extensions/webstore_startup_installer.h [delete] https://crrev.com/35421cb5ddd7aa5d05b2ef4d46b75ee949c590da/chrome/browser/extensions/webstore_startup_installer_browsertest.cc [modify] https://crrev.com/c4fb02304cc8ee7c6896f860f52fef72db1f069a/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc [modify] https://crrev.com/c4fb02304cc8ee7c6896f860f52fef72db1f069a/chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc [modify] https://crrev.com/c4fb02304cc8ee7c6896f860f52fef72db1f069a/chrome/common/BUILD.gn [modify] https://crrev.com/c4fb02304cc8ee7c6896f860f52fef72db1f069a/chrome/common/common_message_generator.h [modify] https://crrev.com/c4fb02304cc8ee7c6896f860f52fef72db1f069a/chrome/common/extensions/BUILD.gn [delete] https://crrev.com/35421cb5ddd7aa5d05b2ef4d46b75ee949c590da/chrome/common/extensions/mojom/OWNERS [delete] https://crrev.com/35421cb5ddd7aa5d05b2ef4d46b75ee949c590da/chrome/common/extensions/mojom/inline_install.mojom [delete] https://crrev.com/35421cb5ddd7aa5d05b2ef4d46b75ee949c590da/chrome/common/extensions/mojom/inline_install.typemap [delete] https://crrev.com/35421cb5ddd7aa5d05b2ef4d46b75ee949c590da/chrome/common/extensions/mojom/inline_install_traits.h [delete] https://crrev.com/35421cb5ddd7aa5d05b2ef4d46b75ee949c590da/chrome/common/extensions/typemaps.gni [modify] https://crrev.com/c4fb02304cc8ee7c6896f860f52fef72db1f069a/chrome/renderer/BUILD.gn [modify] https://crrev.com/c4fb02304cc8ee7c6896f860f52fef72db1f069a/chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc [delete] https://crrev.com/35421cb5ddd7aa5d05b2ef4d46b75ee949c590da/chrome/renderer/extensions/webstore_bindings.cc [delete] https://crrev.com/35421cb5ddd7aa5d05b2ef4d46b75ee949c590da/chrome/renderer/extensions/webstore_bindings.h [modify] https://crrev.com/c4fb02304cc8ee7c6896f860f52fef72db1f069a/chrome/test/BUILD.gn [modify] https://crrev.com/c4fb02304cc8ee7c6896f860f52fef72db1f069a/mojo/public/tools/bindings/chromium_bindings_configuration.gni [modify] https://crrev.com/c4fb02304cc8ee7c6896f860f52fef72db1f069a/testing/buildbot/filters/mac_window_server_killers.browser_tests.filter
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7b5fbbaeeb1a930dc7fcc1a4a594ec85b2f9403d commit 7b5fbbaeeb1a930dc7fcc1a4a594ec85b2f9403d Author: proberge <proberge@chromium.org> Date: Thu Oct 18 20:03:17 2018 Remove all references to inlineInstallPrivate InlineInstallPrivate seems to have been an experimental API developed to allow apps to install other apps and extensions. It seems like it was never launched. Since regular inline installation is being removed, we should probably remove this API as well. Bug: 882045 Change-Id: Iefa97bd46cc38873d1a3d07292d45b2188c8f637 Reviewed-on: https://chromium-review.googlesource.com/c/1265558 Commit-Queue: proberge <proberge@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#600877} [modify] https://crrev.com/7b5fbbaeeb1a930dc7fcc1a4a594ec85b2f9403d/chrome/browser/extensions/BUILD.gn [delete] https://crrev.com/55f0b2e349a9563fa4d270af27e1a4391a585f0f/chrome/browser/extensions/api/inline_install_private/inline_install_private_api.cc [delete] https://crrev.com/55f0b2e349a9563fa4d270af27e1a4391a585f0f/chrome/browser/extensions/api/inline_install_private/inline_install_private_api.h [delete] https://crrev.com/55f0b2e349a9563fa4d270af27e1a4391a585f0f/chrome/browser/extensions/api/inline_install_private/inline_install_private_apitest.cc [modify] https://crrev.com/7b5fbbaeeb1a930dc7fcc1a4a594ec85b2f9403d/chrome/common/extensions/api/_api_features.json [modify] https://crrev.com/7b5fbbaeeb1a930dc7fcc1a4a594ec85b2f9403d/chrome/common/extensions/api/_permission_features.json [modify] https://crrev.com/7b5fbbaeeb1a930dc7fcc1a4a594ec85b2f9403d/chrome/common/extensions/api/api_sources.gni [delete] https://crrev.com/55f0b2e349a9563fa4d270af27e1a4391a585f0f/chrome/common/extensions/api/inline_install_private.idl [modify] https://crrev.com/7b5fbbaeeb1a930dc7fcc1a4a594ec85b2f9403d/chrome/common/extensions/permissions/chrome_api_permissions.cc [modify] https://crrev.com/7b5fbbaeeb1a930dc7fcc1a4a594ec85b2f9403d/chrome/common/extensions/permissions/permission_set_unittest.cc [modify] https://crrev.com/7b5fbbaeeb1a930dc7fcc1a4a594ec85b2f9403d/chrome/test/BUILD.gn [delete] https://crrev.com/55f0b2e349a9563fa4d270af27e1a4391a585f0f/chrome/test/data/extensions/api_test/inline_install_private/app.crx [delete] https://crrev.com/55f0b2e349a9563fa4d270af27e1a4391a585f0f/chrome/test/data/extensions/api_test/inline_install_private/app.pem [delete] https://crrev.com/55f0b2e349a9563fa4d270af27e1a4391a585f0f/chrome/test/data/extensions/api_test/inline_install_private/app/background.js [delete] https://crrev.com/55f0b2e349a9563fa4d270af27e1a4391a585f0f/chrome/test/data/extensions/api_test/inline_install_private/app/icon.png [delete] https://crrev.com/55f0b2e349a9563fa4d270af27e1a4391a585f0f/chrome/test/data/extensions/api_test/inline_install_private/app/manifest.json [delete] https://crrev.com/55f0b2e349a9563fa4d270af27e1a4391a585f0f/chrome/test/data/extensions/api_test/inline_install_private/app/page.html [delete] https://crrev.com/55f0b2e349a9563fa4d270af27e1a4391a585f0f/chrome/test/data/extensions/api_test/inline_install_private/inlineinstall/detail/adjpiofaikamijlfbhehkldllbdcbmeb [delete] https://crrev.com/55f0b2e349a9563fa4d270af27e1a4391a585f0f/chrome/test/data/extensions/api_test/inline_install_private/test_driver/background.js [delete] https://crrev.com/55f0b2e349a9563fa4d270af27e1a4391a585f0f/chrome/test/data/extensions/api_test/inline_install_private/test_driver/manifest.json [delete] https://crrev.com/55f0b2e349a9563fa4d270af27e1a4391a585f0f/chrome/test/data/extensions/api_test/inline_install_private/test_driver/page.html [delete] https://crrev.com/55f0b2e349a9563fa4d270af27e1a4391a585f0f/chrome/test/data/extensions/api_test/inline_install_private/test_driver/page.js [modify] https://crrev.com/7b5fbbaeeb1a930dc7fcc1a4a594ec85b2f9403d/extensions/browser/extension_function_histogram_value.h [modify] https://crrev.com/7b5fbbaeeb1a930dc7fcc1a4a594ec85b2f9403d/extensions/common/permissions/api_permission.h [modify] https://crrev.com/7b5fbbaeeb1a930dc7fcc1a4a594ec85b2f9403d/tools/metrics/histograms/enums.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7b9a31358cdf07788364fb9768aec85ac28456ad commit 7b9a31358cdf07788364fb9768aec85ac28456ad Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Thu Oct 25 21:46:45 2018 [Extensions] Remove webstore custom bindings Inline install is deprecated, and the functionality is removed. Clean up the lingering webstore_custom_bindings.js file. TBR=stevenjb@chromium.org (removing resource entry in renderer_resources.grd) Bug: 882045 Change-Id: I899aa384cbc4c9fcc3365498fa3723c34749b6e1 Reviewed-on: https://chromium-review.googlesource.com/c/1298115 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#602868} [modify] https://crrev.com/7b9a31358cdf07788364fb9768aec85ac28456ad/chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc [delete] https://crrev.com/0da589ad1be1bf58188bb1191fa5304eab9bdd30/chrome/renderer/resources/extensions/webstore_custom_bindings.js [modify] https://crrev.com/7b9a31358cdf07788364fb9768aec85ac28456ad/chrome/renderer/resources/renderer_resources.grd
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ac4efffc00ee83ffa4f4bcf6ebe0356492e7e018 commit ac4efffc00ee83ffa4f4bcf6ebe0356492e7e018 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Thu Oct 25 22:03:21 2018 [Extensions] De-compile webstore.json webstore.json describes inline installation, which is now deprecated and removed. Remove it from the build so we don't generate schemas items. Leave the file in the source tree for posterity, but update each item to include the "deprecated" field. Bug: 882045 Change-Id: Ic9652df2c18c277fcf130a71fb9da494e2e257e0 Reviewed-on: https://chromium-review.googlesource.com/c/1298116 Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#602889} [modify] https://crrev.com/ac4efffc00ee83ffa4f4bcf6ebe0356492e7e018/chrome/common/extensions/api/BUILD.gn [modify] https://crrev.com/ac4efffc00ee83ffa4f4bcf6ebe0356492e7e018/chrome/common/extensions/api/webstore.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9afecb6e13b1fd6fa5480a3e76fa11ab318a21bc commit 9afecb6e13b1fd6fa5480a3e76fa11ab318a21bc Author: Benjamin Ackerman <ackermanb@chromium.org> Date: Fri Oct 26 22:00:42 2018 [Extensions] Removing unused constants library. The webstore_api_constants is no longer being used, so removing it. Bug: 882045 Change-Id: If0ab15c26eb70c89a9bad3d236c0fa62b71ef2fb Reviewed-on: https://chromium-review.googlesource.com/c/1299545 Commit-Queue: Benjamin Ackerman <ackermanb@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#603205} [modify] https://crrev.com/9afecb6e13b1fd6fa5480a3e76fa11ab318a21bc/chrome/browser/extensions/tab_helper.cc [modify] https://crrev.com/9afecb6e13b1fd6fa5480a3e76fa11ab318a21bc/chrome/common/BUILD.gn [delete] https://crrev.com/9f95302af1a4aac1666e850b22edb8a22b97d3e5/chrome/common/extensions/api/webstore/webstore_api_constants.cc [delete] https://crrev.com/9f95302af1a4aac1666e850b22edb8a22b97d3e5/chrome/common/extensions/api/webstore/webstore_api_constants.h
Comment 1 by bugdroid1@chromium.org
, Oct 3