New issue
Advanced search Search tips

Issue 882043 link

Starred by 1 user
Status: Fixed
Owner:
khmel@chromium.org
Closed: Sep 11
Cc:
osh...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

ChromeLauncherControllerWithArcTest.ArcCustomAppIcon/1 keeps failing on trybots

Project Member Reported by afakhry@chromium.org, Sep 7 
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux-chromeos-rel/89576


[ RUN      ] ChromeLauncherControllerWithArcTest.ArcCustomAppIcon/1
[21017:21017:0907/154120.909044:592013161:ERROR:multi_user_window_manager_stub.cc(17)] Not implemented reached in virtual void MultiUserWindowManagerStub::SetWindowOwner(aura::Window *, const AccountId &)
[21017:21017:0907/154120.911744:592015860:ERROR:multi_user_window_manager_stub.cc(17)] Not implemented reached in virtual void MultiUserWindowManagerStub::SetWindowOwner(aura::Window *, const AccountId &)
../../chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc:2529: Failure
Value of: gfx::test::AreBitmapsEqual(default_icon, shelf_controller->GetLastItemImage())
  Actual: false
Expected: true
Stack trace:
#0 0x000002c1f68c testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop()
#1 0x000002c1f069 testing::internal::AssertHelper::operator=()
#2 0x00000187563b ChromeLauncherControllerWithArcTest_ArcCustomAppIcon_Test::TestBody()
[21017:21017:0907/154120.974543:592078661:INFO:arc_session_runner.cc(264)] ARC stopped: SHUTDOWN
[  FAILED  ] ChromeLauncherControllerWithArcTest.ArcCustomAppIcon/1, where GetParam() = true (223 ms)


Yury, could you please take a look?
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c8d038112ca80e0f63885273c3e9ffc5d54ea72

commit 4c8d038112ca80e0f63885273c3e9ffc5d54ea72
Author: khmel@chromium.org <khmel@chromium.org>
Date: Mon Sep 10 21:31:37 2018

Reland "arc: Fix shelf item icon flickering on app start."

This reverts commit 373854345147a28fac7c7796f1e86c186a0889fc.
(Test flakiness fixed)

When app is pinned, icon image is loaded via controller using loader
owner by chrome launcher controller. Once new ARC app window appears in
the system, it's icon is loaded asynchronously. In this flow, default
app icon is applied first and then, once real image is loaded final icon
is set. Each update of ARC window icon is reflected on shelf. That
means default app icon appear on the shelf for a moment and in most cases
this is very noticeable.
This CL prevents setting default app in favor of final app icon and
default icon is set only as a fallback when final icon could not be
loaded.

TEST=Manual
BUG= 882048 
BUG= 882043 
Bug: b:114246197

TBR=xiyuan@chromium.org,jdonnelly@chromium.org,khmel@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Ic2015afe42b4b3aacd05a307350e643a6967d3e8
Reviewed-on: https://chromium-review.googlesource.com/1216721
Commit-Queue: Yury Khmel <khmel@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590071}
[modify] https://crrev.com/4c8d038112ca80e0f63885273c3e9ffc5d54ea72/chrome/browser/ui/ash/launcher/arc_app_window.cc
[modify] https://crrev.com/4c8d038112ca80e0f63885273c3e9ffc5d54ea72/chrome/browser/ui/ash/launcher/arc_app_window.h
[modify] https://crrev.com/4c8d038112ca80e0f63885273c3e9ffc5d54ea72/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc

Comment 2 by khmel@chromium.org, Sep 11

Status: Fixed (was: Assigned)
►

Sign in to add a comment