New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 882031 link

Starred by 1 user

Issue metadata

Status: Available
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Task



Sign in to add a comment

Merge request for disable AImageReader patch

Project Member Reported by vikassoni@chromium.org, Sep 7

Issue description

Hi,

 I wanted to merge below changes to M70 branch. These changes are behind a feature flag and is enabled for only dev and canary as of now. So it should not cause any bugs on merge. Also this is tested in canary.

Can you please merge the below change.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2364c68c3dca2b4fe489362c703355dfc210d07f

commit 2364c68c3dca2b4fe489362c703355dfc210d07f
Author: Vikas Soni <vikassoni@chromium.org>
Date: Fri Aug 31 02:22:21 2018

Disable AImageReader on ARM GPU devices.

Add gpu driver workaround to disable AImageReader on devices which have
ARM GPU.

Bug: 838725
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ia60d5ee9e16a4f309a99d04212af245411319040
Reviewed-on: https://chromium-review.googlesource.com/1194680
Commit-Queue: vikas soni <vikassoni@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Martin Barbella <mbarbella@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587919}
[modify] https://crrev.com/2364c68c3dca2b4fe489362c703355dfc210d07f/base/android/android_image_reader_compat.cc
[modify] https://crrev.com/2364c68c3dca2b4fe489362c703355dfc210d07f/base/android/android_image_reader_compat.h
[modify] https://crrev.com/2364c68c3dca2b4fe489362c703355dfc210d07f/gpu/config/gpu_driver_bug_list.json
[modify] https://crrev.com/2364c68c3dca2b4fe489362c703355dfc210d07f/gpu/config/gpu_workaround_list.txt
[modify] https://crrev.com/2364c68c3dca2b4fe489362c703355dfc210d07f/gpu/ipc/common/android/surface_owner_android.cc
[modify] https://crrev.com/2364c68c3dca2b4fe489362c703355dfc210d07f/gpu/ipc/service/gpu_init.cc
[modify] https://crrev.com/2364c68c3dca2b4fe489362c703355dfc210d07f/media/gpu/android/texture_owner.cc
 
Cc: ericrk@chromium.org
Project Member

Comment 2 by sheriffbot@chromium.org, Sep 8

Labels: -Merge-Request-70 Hotlist-Merge-Approved Merge-Approved-70
Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by sheriffbot@chromium.org, Sep 12

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Approved -Merge-Approved-70

Sign in to add a comment