Some minimized windows in overview are unrendered. |
|||||||||||||
Issue descriptionWhat steps will reproduce the problem? (1) Open about 7 apps in different windows. (2) Minimize all windows (or press launcher button if in tablet mode). (3) Open overview. What is the expected result? All windows will not be drawn. What happens instead? Some windows will not be drawn. This is seen in 71.0.3546.0 and a couple versions back as well. This may also been a issue since the beginning but unnoticed since minimizing all those windows is not common, until home launcher.
,
Sep 7
Seems like a fairly recent regression - 70.3532 is working as expected, but ToT 71.0.3546 is not, (for chrome apps at least i think arc apps is a different issue).
,
Sep 10
I bisect to https://chromium-review.googlesource.com/c/chromium/src/+/1200411, but that does not really do it because in the web contents are still not draw as shown in the screenshot and once you open them and minimize there is the same problem. I bisect again to this cl which modifies the web contents: https://chromium-review.googlesource.com/c/chromium/src/+/1191862
,
Sep 10
+fdoray fdoray: Can you take a look? This also affects alt-tab, when there are more than 5-6 windows opened, and they are all minimized. The windows at the end do not render properly.
,
Sep 13
fdoray@, can you take a look? It's a pretty serious issue since home launch was enabled since M70. It's now very easy to have multiple minimized windows. +RBS
,
Sep 14
Fix sent for review at https://chromium-review.googlesource.com/c/chromium/src/+/1227211
,
Sep 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7d35e094695459e3e0ed05c248f6e5a6824bfb4b commit 7d35e094695459e3e0ed05c248f6e5a6824bfb4b Author: Francois Doray <fdoray@chromium.org> Date: Mon Sep 17 13:15:25 2018 aura: Make WebContents VISIBLE when host aura::Window is mirrored. https://chromium-review.googlesource.com/1191862 makes a WebContents VISIBLE if the WebContentsViewAura has the aura::client::kMirroringEnabledKey property. Unfortunately, Alt-Tab sets this property on the host of the WebContentsViewAura, not on the WebContentsViewAura. With this CL, we check for the property on the host aura::Window. Bug: 882028 Change-Id: Ib16df475ce886cd606fe9406cf63fb83da36d52c Reviewed-on: https://chromium-review.googlesource.com/1227211 Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#591653} [modify] https://crrev.com/7d35e094695459e3e0ed05c248f6e5a6824bfb4b/content/browser/web_contents/web_contents_view_aura.cc [modify] https://crrev.com/7d35e094695459e3e0ed05c248f6e5a6824bfb4b/content/browser/web_contents/web_contents_view_aura_unittest.cc
,
Sep 17
Fixed when testing on my Chrome OS build running on Linux. Can this be tested on an official build?
,
Sep 17
[Auto-generated comment by a script] We noticed that this issue is targeted for M-70; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-70 label, otherwise remove Merge-TBD label. Thanks.
,
Sep 17
Request to merge commit 7d35e094695459e3e0ed05c248f6e5a6824bfb4b to M70 (see comment #7). This change ensures that tab content is rendered for minimized windows in Alt-Tab and Overview views on Chrome OS.
,
Sep 17
re#8: Thanks for fixing this! I'll keep an eye out when I flash a new image onto my device.
,
Sep 17
,
Sep 21
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 25
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d9921d0ac236802aca9b3a74ca3613dd58880cad Commit: d9921d0ac236802aca9b3a74ca3613dd58880cad Author: fdoray@chromium.org Commiter: fdoray@chromium.org Date: 2018-09-25 19:02:09 +0000 UTC [Merge M70] aura: Make WebContents VISIBLE when host aura::Window is mirrored. https://chromium-review.googlesource.com/1191862 makes a WebContents VISIBLE if the WebContentsViewAura has the aura::client::kMirroringEnabledKey property. Unfortunately, Alt-Tab sets this property on the host of the WebContentsViewAura, not on the WebContentsViewAura. With this CL, we check for the property on the host aura::Window. Original CL: https://chromium-review.googlesource.com/1227211 Bug: 882028 Change-Id: Ib16df475ce886cd606fe9406cf63fb83da36d52c Reviewed-on: https://chromium-review.googlesource.com/1227211 Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#591653}(cherry picked from commit 7d35e094695459e3e0ed05c248f6e5a6824bfb4b) Reviewed-on: https://chromium-review.googlesource.com/1244356 Reviewed-by: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#657} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
,
Sep 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d9921d0ac236802aca9b3a74ca3613dd58880cad commit d9921d0ac236802aca9b3a74ca3613dd58880cad Author: Francois Doray <fdoray@chromium.org> Date: Tue Sep 25 19:02:09 2018 [Merge M70] aura: Make WebContents VISIBLE when host aura::Window is mirrored. https://chromium-review.googlesource.com/1191862 makes a WebContents VISIBLE if the WebContentsViewAura has the aura::client::kMirroringEnabledKey property. Unfortunately, Alt-Tab sets this property on the host of the WebContentsViewAura, not on the WebContentsViewAura. With this CL, we check for the property on the host aura::Window. Original CL: https://chromium-review.googlesource.com/1227211 Bug: 882028 Change-Id: Ib16df475ce886cd606fe9406cf63fb83da36d52c Reviewed-on: https://chromium-review.googlesource.com/1227211 Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#591653}(cherry picked from commit 7d35e094695459e3e0ed05c248f6e5a6824bfb4b) Reviewed-on: https://chromium-review.googlesource.com/1244356 Reviewed-by: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#657} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/d9921d0ac236802aca9b3a74ca3613dd58880cad/content/browser/web_contents/web_contents_view_aura.cc [modify] https://crrev.com/d9921d0ac236802aca9b3a74ca3613dd58880cad/content/browser/web_contents/web_contents_view_aura_unittest.cc
,
Sep 25
,
Nov 7
|
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by sammiequon@chromium.org
, Sep 7278 KB
278 KB View Download