New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 882015 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 17
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

recover_duts: reimplement as shell script

Project Member Reported by mka@chromium.org, Sep 7

Issue description

In certain autotest failure cases /var gets wiped and with it the
Python interpreter, in such a situation recover_duts.py can't be
executed. The script is fairly simple and doesn't really benefit
from being implemented in Python, reimplement it as shell script.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/39544fcf12101062883e73f6a80f3f29da7fbd23

commit 39544fcf12101062883e73f6a80f3f29da7fbd23
Author: Matthias Kaehlcke <mka@chromium.org>
Date: Mon Sep 17 20:17:29 2018

init: Switch to recover_duts shell script

recover_duts.py has been reimplemented as shell script, start the
new version.

Configure logrotate for the recover_duts logs, previously this was handled
by the Python logging module.

BUG= chromium:882015 
TEST=see CL:1213409
CQ-DEPEND=CL:1217023

Change-Id: I66dbd2c7de3a561bb8906da22372d25eb9648c46
Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1217082
Reviewed-by: Douglas Anderson <dianders@chromium.org>

[modify] https://crrev.com/39544fcf12101062883e73f6a80f3f29da7fbd23/init/chromeos-cleanup-logs
[modify] https://crrev.com/39544fcf12101062883e73f6a80f3f29da7fbd23/init/upstart/test-init/recover_duts.conf

Project Member

Comment 2 by bugdroid1@chromium.org, Sep 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/c722720815348f89a861e5a77a3bc5a13db3042d

commit c722720815348f89a861e5a77a3bc5a13db3042d
Author: Matthias Kaehlcke <mka@chromium.org>
Date: Mon Sep 17 20:17:29 2018

recover_duts: switch to shell script

recover_duts.py has been reimplemented as shell script, install the
new version.

BUG= chromium:882015 
TEST=see CL:1213409
CQ-DEPEND=CL:1213409

Change-Id: Ic260bdbec0782c890e482ef73fed1b008c872824
Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1217023
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Grant Grundler <grundler@chromium.org>

[modify] https://crrev.com/c722720815348f89a861e5a77a3bc5a13db3042d/chromeos-base/recover-duts/recover-duts-9999.ebuild

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/crostestutils/+/ea94e325ebe45d445bd032b278daaa91e7cdacc4

commit ea94e325ebe45d445bd032b278daaa91e7cdacc4
Author: Matthias Kaehlcke <mka@chromium.org>
Date: Mon Sep 17 20:17:28 2018

recover_duts: Reimplement as shell script

In certain autotest failure cases /var gets wiped and with it the
Python interpreter, in such a situation recover_duts.py can't be
executed. The script is fairly simple and doesn't really benefit
from being implemented in Python, reimplement it as shell script.

BUG= chromium:882015 
TEST=touch /mnt/stateful_partition/.labmachine
  rmmod r8152 # or applicable ethernet driver
  # wait up to 90s
    => eth0 is brought up again
CQ-DEPEND=CL:1217082

Change-Id: I07a4610056c83e88f1b19e7e2f8b7767f81254e2
Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1213409
Reviewed-by: Douglas Anderson <dianders@chromium.org>

[add] https://crrev.com/ea94e325ebe45d445bd032b278daaa91e7cdacc4/recover_duts/recover_duts.sh
[delete] https://crrev.com/584d04568c8b135e3b24fe3ff372bd6e22078c6e/recover_duts/recover_duts.py
[modify] https://crrev.com/ea94e325ebe45d445bd032b278daaa91e7cdacc4/recover_duts/README

Status: Fixed (was: Assigned)

Sign in to add a comment