New issue
Advanced search Search tips

Issue 882014 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 8
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 3
Type: Bug



Sign in to add a comment

linearRGB and sRGB should be lower case

Project Member Reported by ericwilligers@chromium.org, Sep 7

Issue description

CSS keywords should serialize in lower case.

This includes the keywords linearRGB and sRGB.

Web platform tests already use lower case.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/21eea8641df09cee4b15cff6ca8cd87843713db8

commit 21eea8641df09cee4b15cff6ca8cd87843713db8
Author: Eric Willigers <ericwilligers@chromium.org>
Date: Sat Sep 08 04:11:34 2018

CSS: serialize linearRGB and sRGB in lower case

CSS keywords serialize in lower case.

https://drafts.csswg.org/cssom/#serializing-css-values
"To serialize a CSS component value depends on the component, as follows:
keyword
The keyword converted to ASCII lowercase."

BUG= 882014 

Change-Id: Ibdfb7f3bf64f26bc4841bbf012668d9071d4473c
Reviewed-on: https://chromium-review.googlesource.com/1213563
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#589769}
[modify] https://crrev.com/21eea8641df09cee4b15cff6ca8cd87843713db8/third_party/WebKit/LayoutTests/animations/svg/svg-presentation-attribute-animation.html
[modify] https://crrev.com/21eea8641df09cee4b15cff6ca8cd87843713db8/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/color-interpolation.html
[modify] https://crrev.com/21eea8641df09cee4b15cff6ca8cd87843713db8/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/variable-presentation-attribute-expected.txt
[modify] https://crrev.com/21eea8641df09cee4b15cff6ca8cd87843713db8/third_party/WebKit/LayoutTests/external/wpt/web-animations/animation-model/animation-types/accumulation-per-property-expected.txt
[modify] https://crrev.com/21eea8641df09cee4b15cff6ca8cd87843713db8/third_party/WebKit/LayoutTests/external/wpt/web-animations/animation-model/animation-types/addition-per-property-expected.txt
[modify] https://crrev.com/21eea8641df09cee4b15cff6ca8cd87843713db8/third_party/WebKit/LayoutTests/external/wpt/web-animations/animation-model/animation-types/interpolation-per-property-expected.txt
[modify] https://crrev.com/21eea8641df09cee4b15cff6ca8cd87843713db8/third_party/WebKit/LayoutTests/external/wpt/web-animations/animation-model/animation-types/property-list.js
[modify] https://crrev.com/21eea8641df09cee4b15cff6ca8cd87843713db8/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-listing-expected.txt
[modify] https://crrev.com/21eea8641df09cee4b15cff6ca8cd87843713db8/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt
[modify] https://crrev.com/21eea8641df09cee4b15cff6ca8cd87843713db8/third_party/WebKit/LayoutTests/platform/mac/external/wpt/css/css-variables/variable-presentation-attribute-expected.txt
[modify] https://crrev.com/21eea8641df09cee4b15cff6ca8cd87843713db8/third_party/WebKit/LayoutTests/svg/css/getComputedStyle-listing-expected.txt
[modify] https://crrev.com/21eea8641df09cee4b15cff6ca8cd87843713db8/third_party/blink/renderer/core/css/CSSProperties.json5
[modify] https://crrev.com/21eea8641df09cee4b15cff6ca8cd87843713db8/third_party/blink/renderer/core/css/SVGCSSValueKeywords.json5
[modify] https://crrev.com/21eea8641df09cee4b15cff6ca8cd87843713db8/third_party/blink/renderer/core/css/css_primitive_value_mappings.h
[modify] https://crrev.com/21eea8641df09cee4b15cff6ca8cd87843713db8/third_party/blink/renderer/core/css/parser/css_parser_fast_paths.cc

Status: Fixed (was: Started)

Sign in to add a comment