Merge request for omnibox animation fix |
||||
Issue descriptionThis is a merge request for https://chromium-review.googlesource.com/c/chromium/src/+/1208140. Not only does it fix a bug for the "Card saved" animation of the Sign-in after local credit card save project, but the "Pop-up blocked" animation suffered from the *same problem* (was introduced in M70), so this fixes that as well.
,
Sep 8
Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 10
Confirmed fixed in Canary and merged into branch 3538.
,
Sep 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/50f09efa79cc7e865c2fc0d571edaef3342b5947 commit 50f09efa79cc7e865c2fc0d571edaef3342b5947 Author: Manas Verma <manasverma@google.com> Date: Mon Sep 10 20:05:10 2018 [Autofill] The "Card saved" animation resets properly once done. Previously, if we save a card twice in a row, the second time the animation needs to be shown, it would just show static text. The animation continues to glitch for each subsequent use. Now the animation works properly each time it is invoked. This also applies to the pop-up blocker's "Pop-up blocked" text animation. Bug: 882012 Change-Id: Ie6f8a53a24d5ec4dd06b9ead27b784fc46a26310 Reviewed-on: https://chromium-review.googlesource.com/1208140 Reviewed-by: Carlos IL <carlosil@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Commit-Queue: Manas Verma <manasverma@google.com> Cr-Original-Commit-Position: refs/heads/master@{#589356}(cherry picked from commit 329d8468628836870c240d47a135a7529429083c) Reviewed-on: https://chromium-review.googlesource.com/1217088 Reviewed-by: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/branch-heads/3538@{#243} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/50f09efa79cc7e865c2fc0d571edaef3342b5947/chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc |
||||
►
Sign in to add a comment |
||||
Comment 1 by jsaul@google.com
, Sep 7