New issue
Advanced search Search tips

Issue 882003 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"org.chromium.chrome.browser.TabsTest#testToolbarSwipeNextThenPrevTab" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Sep 7

Issue description

"org.chromium.chrome.browser.TabsTest#testToolbarSwipeNextThenPrevTab" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyTwsSBUZsYWtlIkRvcmcuY2hyb21pdW0uY2hyb21lLmJyb3dzZXIuVGFic1Rlc3QjdGVzdFRvb2xiYXJTd2lwZU5leHRUaGVuUHJldlRhYgw.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Owner: mdjones@chromium.org
Status: Assigned (was: Untriaged)
mdjones: no good deed goes unpunished...looks like you tried to deflake this in https://chromium.googlesource.com/chromium/src/+/b8563ec5600a0e697fd5849549dda61f8c195dcd. It's still flaky though. :( Does this look like the same flake? If not, please assign to the appropriate person/team.
Yeah this is mine, I'll try to look into it today.
https://luci-logdog.appspot.com/v/?s=chromium%2Fandroid%2Fswarming%2Flogcats%2F3c3e9dc6c1c25611%2F%2B%2Flogcat_logcat_org.chromium.chrome.browser.TabsTest.testToolbarSwipeNextThenPrevTab_20180314T184633-UTC_076a8b9c13dbaf84

03-14 18:46:44.309 18483 18498 I TestRunner: failed: testToolbarSwipeNextThenPrevTab(org.chromium.chrome.browser.TabsTest)
03-14 18:46:44.309 18483 18498 I TestRunner: ----- begin exception -----
03-14 18:46:44.309 18483 18498 I TestRunner: java.lang.AssertionError: Index after toolbar side swipe is incorrect expected:<1> but was:<0>
03-14 18:46:44.309 18483 18498 I TestRunner: 	at org.junit.Assert.fail(Assert.java:88)
03-14 18:46:44.309 18483 18498 I TestRunner: 	at org.junit.Assert.failNotEquals(Assert.java:834)
03-14 18:46:44.309 18483 18498 I TestRunner: 	at org.junit.Assert.assertEquals(Assert.java:645)
03-14 18:46:44.309 18483 18498 I TestRunner: 	at org.chromium.chrome.browser.TabsTest.runToolbarSideSwipeTestOnCurrentModel(TabsTest.java:1633)
03-14 18:46:44.309 18483 18498 I TestRunner: 	at org.chromium.chrome.browser.TabsTest.testToolbarSwipeNextThenPrevTab(TabsTest.java:1582)
03-14 18:46:44.309 18483 18498 I TestRunner: 	at java.lang.reflect.Method.invokeNative(Native Method)
03-14 18:46:44.309 18483 18498 I TestRunner: 	at java.lang.reflect.Method.invoke(Method.java:515)
03-14 18:46:44.309 18483 18498 I TestRunner: 	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
03-14 18:46:44.309 18483 18498 I TestRunner: 	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
03-14 18:46:44.309 18483 18498 I TestRunner: 	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:52)
03-14 18:46:44.309 18483 18498 I TestRunner: 	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
03-14 18:46:44.309 18483 18498 I TestRunner: 	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
03-14 18:46:44.309 18483 18498 I TestRunner: 	at org.chromium.base.test.ScreenshotOnFailureStatement.evaluate(ScreenshotOnFailureStatement.java:37)
03-14 18:46:44.309 18483 18498 I TestRunner: 	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
03-14 18:46:44.309 18483 18498 I TestRunner: 	at org.chromium.chrome.test.ChromeActivityTestRule$1.evaluate(ChromeActivityTestRule.java:113)
03-14 18:46:44.309 18483 18498 I TestRunner: 	at android.support.test.internal.statement.UiThreadStatement.evaluate(UiThreadStatement.java:55)
03-14 18:46:44.309 18483 18498 I TestRunner: 	at android.support.test.rule.ActivityTestRule$ActivityStatement.evaluate(ActivityTestRule.java:270)
03-14 18:46:44.309 18483 18498 I TestRunner: 	at org.junit.rules.RunRules.evaluate(RunRules.java:20)
03-14 18:46:44.309 18483 18498 I TestRunner: 	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
03-14 18:46:44.309 18483 18498 I TestRunner: 	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
03-14 18:46:44.309 18483 18498 I TestRunner: 	at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:201)
03-14 18:46:44.309 18483 18498 I TestRunner: 	at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:43)
03-14 18:46:44.309 18483 18498 I TestRunner: 	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
03-14 18:46:44.309 18483 18498 I TestRunner: 	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
03-14 18:46:44.309 18483 18498 I TestRunner: 	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
03-14 18:46:44.309 18483 18498 I TestRunner: 	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
03-14 18:46:44.309 18483 18498 I TestRunner: 	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
03-14 18:46:44.309 18483 18498 I TestRunner: 	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
03-14 18:46:44.309 18483 18498 I TestRunner: 	at org.chromium.base.test.BaseJUnit4ClassRunner.run(BaseJUnit4ClassRunner.java:183)
03-14 18:46:44.309 18483 18498 I TestRunner: 	at org.junit.runners.Suite.runChild(Suite.java:128)
03-14 18:46:44.309 18483 18498 I TestRunner: 	at org.junit.runners.Suite.runChild(Suite.java:27)
03-14 18:46:44.309 18483 18498 I TestRunner: 	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
03-14 18:46:44.309 18483 18498 I TestRunner: 	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
03-14 18:46:44.309 18483 18498 I TestRunner: 	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
03-14 18:46:44.309 18483 18498 I TestRunner: 	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
03-14 18:46:44.309 18483 18498 I TestRunner: 	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
03-14 18:46:44.309 18483 18498 I TestRunner: 	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
03-14 18:46:44.309 18483 18498 I TestRunner: 	at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
03-14 18:46:44.309 18483 18498 I TestRunner: 	at org.junit.runner.JUnitCore.run(JUnitCore.java:115)
03-14 18:46:44.309 18483 18498 I TestRunner: 	at android.support.test.internal.runner.TestExecutor.execute(TestExecutor.java:59)
03-14 18:46:44.309 18483 18498 I TestRunner: 	at android.support.test.runner.AndroidJUnitRunner.onStart(AndroidJUnitRunner.java:262)
03-14 18:46:44.309 18483 18498 I TestRunner: 	at org.chromium.base.test.BaseChromiumAndroidJUnitRunner.onStart(BaseChromiumAndroidJUnitRunner.java:103)
03-14 18:46:44.309 18483 18498 I TestRunner: 	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)
03-14 18:46:44.309 18483 18498 I TestRunner: ----- end exception -----
03-14 18:46:44.309 18483 18498 I TestRunner: finished: testToolbarSwipeNextThenPrevTab(org.chromium.chrome.browser.TabsTest)

The incognito version times out:

https://luci-logdog.appspot.com/v/?s=chromium%2Fandroid%2Fswarming%2Flogcats%2F3d9bb4ec4f2b0b11%2F%2B%2Flogcat_logcat_org.chromium.chrome.browser.TabsTest.testToolbarSwipeNextThenPrevTabIncognito_20180521T134417-UTC_06c15955003b7eaa

05-21 13:44:36.989 24019 24033 I TestRunner: failed: testToolbarSwipeNextThenPrevTabIncognito(org.chromium.chrome.browser.TabsTest)
05-21 13:44:36.989 24019 24033 I TestRunner: ----- begin exception -----
05-21 13:44:36.999 24019 24033 I TestRunner: java.util.concurrent.TimeoutException: waitForCallback timed out!
05-21 13:44:36.999 24019 24033 I TestRunner: 	at org.chromium.base.test.util.CallbackHelper.waitForCallback(CallbackHelper.java:191)
05-21 13:44:36.999 24019 24033 I TestRunner: 	at org.chromium.base.test.util.CallbackHelper.waitForCallback(CallbackHelper.java:210)
05-21 13:44:36.999 24019 24033 I TestRunner: 	at org.chromium.chrome.browser.TabsTest.runToolbarSideSwipeTestOnCurrentModel(TabsTest.java:1636)
05-21 13:44:36.999 24019 24033 I TestRunner: 	at org.chromium.chrome.browser.TabsTest.testToolbarSwipeNextThenPrevTabIncognito(TabsTest.java:1596)
05-21 13:44:36.999 24019 24033 I TestRunner: 	at java.lang.reflect.Method.invokeNative(Native Method)
05-21 13:44:36.999 24019 24033 I TestRunner: 	at java.lang.reflect.Method.invoke(Method.java:515)
05-21 13:44:36.999 24019 24033 I TestRunner: 	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
05-21 13:44:36.999 24019 24033 I TestRunner: 	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
05-21 13:44:36.999 24019 24033 I TestRunner: 	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:52)
05-21 13:44:36.999 24019 24033 I TestRunner: 	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
05-21 13:44:36.999 24019 24033 I TestRunner: 	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
05-21 13:44:36.999 24019 24033 I TestRunner: 	at org.chromium.base.test.ScreenshotOnFailureStatement.evaluate(ScreenshotOnFailureStatement.java:37)
05-21 13:44:36.999 24019 24033 I TestRunner: 	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
05-21 13:44:36.999 24019 24033 I TestRunner: 	at org.chromium.chrome.test.ChromeActivityTestRule$1.evaluate(ChromeActivityTestRule.java:115)
05-21 13:44:36.999 24019 24033 I TestRunner: 	at android.support.test.internal.statement.UiThreadStatement.evaluate(UiThreadStatement.java:55)
05-21 13:44:36.999 24019 24033 I TestRunner: 	at android.support.test.rule.ActivityTestRule$ActivityStatement.evaluate(ActivityTestRule.java:270)
05-21 13:44:36.999 24019 24033 I TestRunner: 	at org.junit.rules.RunRules.evaluate(RunRules.java:20)
05-21 13:44:36.999 24019 24033 I TestRunner: 	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
05-21 13:44:36.999 24019 24033 I TestRunner: 	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
05-21 13:44:36.999 24019 24033 I TestRunner: 	at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:201)
05-21 13:44:36.999 24019 24033 I TestRunner: 	at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:43)
05-21 13:44:36.999 24019 24033 I TestRunner: 	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
05-21 13:44:36.999 24019 24033 I TestRunner: 	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
05-21 13:44:36.999 24019 24033 I TestRunner: 	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
05-21 13:44:36.999 24019 24033 I TestRunner: 	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
05-21 13:44:36.999 24019 24033 I TestRunner: 	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
05-21 13:44:36.999 24019 24033 I TestRunner: 	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
05-21 13:44:36.999 24019 24033 I TestRunner: 	at org.chromium.base.test.BaseJUnit4ClassRunner.run(BaseJUnit4ClassRunner.java:183)
05-21 13:44:36.999 24019 24033 I TestRunner: 	at org.junit.runners.Suite.runChild(Suite.java:128)
05-21 13:44:36.999 24019 24033 I TestRunner: 	at org.junit.runners.Suite.runChild(Suite.java:27)
05-21 13:44:36.999 24019 24033 I TestRunner: 	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
05-21 13:44:36.999 24019 24033 I TestRunner: 	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
05-21 13:44:36.999 24019 24033 I TestRunner: 	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
05-21 13:44:36.999 24019 24033 I TestRunner: 	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
05-21 13:44:36.999 24019 24033 I TestRunner: 	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
05-21 13:44:36.999 24019 24033 I TestRunner: 	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
05-21 13:44:36.999 24019 24033 I TestRunner: 	at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
05-21 13:44:36.999 24019 24033 I TestRunner: 	at org.junit.runner.JUnitCore.run(JUnitCore.java:115)
05-21 13:44:36.999 24019 24033 I TestRunner: 	at android.support.test.internal.runner.TestExecutor.execute(TestExecutor.java:59)
05-21 13:44:36.999 24019 24033 I TestRunner: 	at android.support.test.runner.AndroidJUnitRunner.onStart(AndroidJUnitRunner.java:262)
05-21 13:44:36.999 24019 24033 I TestRunner: 	at org.chromium.base.test.BaseChromiumAndroidJUnitRunner.onStart(BaseChromiumAndroidJUnitRunner.java:122)
05-21 13:44:36.999 24019 24033 I TestRunner: 	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)
05-21 13:44:36.999 24019 24033 I TestRunner: ----- end exception -----
05-21 13:44:36.999 24019 24033 I TestRunner: finished: testToolbarSwipeNextThenPrevTabIncognito(org.chromium.chrome.browser.TabsTest)
Labels: -Sheriff-Chromium Test-Disabled
I have disabled the tests (in commit queue). As failures are documented and owner is assigned, I am taking this out of the sheriff queue.
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c8bc84b685a77f6b5cea6421b705395a23d47b7

commit 5c8bc84b685a77f6b5cea6421b705395a23d47b7
Author: Dominic Battre <battre@chromium.org>
Date: Tue Sep 11 07:53:59 2018

Disable some org.chromium.chrome.browser.TabsTest tests

Disabled testToolbarSwipeNextThenPrevTab and
testToolbarSwipeNextThenPrevTabIncognito for flakiness.
See bug for details.

TBR=mdjones@chromium.org

Bug: 882003
Change-Id: Ic78f41566c1abce0feb4010196fcf1270fba11a6
Reviewed-on: https://chromium-review.googlesource.com/1218722
Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590228}
[modify] https://crrev.com/5c8bc84b685a77f6b5cea6421b705395a23d47b7/chrome/android/javatests/src/org/chromium/chrome/browser/TabsTest.java

Sign in to add a comment