New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 881986 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Team-Accessibility



Sign in to add a comment

AXTreeID should be a base::UnguessableToken

Project Member Reported by dmazz...@chromium.org, Sep 7

Issue description

Because of out-of-process iframes, each frame sends a separate accessibility tree to the browser process, which is sometimes forwarded to automation extensions like ChromeVox. To be able to reconstruct the composed accessibility tree across frames, we need each accessibility tree to have a unique ID and trees need to identify the IDs of their parents and children.

Currently RenderFrames don't have unique IDs, so renderers send the routing ID of their own frame and of parent and child frames back to the browser process, where they need to be converted into (globally-unique) AXTreeIDs.

Instead, each RenderFrame could have a base::UnguessableToken that's synchronized across all processes, which could be used to directly reference other frames uniquely, no translation required. On the browser side, we could *verify* these ids but we wouldn't need to *translate* them. This means less rewriting of structs.

Benefits:
* We can implement Onion Soup (having Blink talk directly to the browser process without a content layer) without "leaking" concepts like routing IDs into Blink
* RenderFrameHostImpl doesn't need to rewrite a AXContentNodeData into an AXNodeData
* Then we can get rid of AXContentNodeData and just use AXNodeData everywhere
* Mojo Apps (native aura/views apps in a separate process) could each have a unique AXTreeID too
* Eventually we might be able to route mojo messages directly from Blink to an extension like ChromeVox and bypass the browser process, as long as we were careful about not trusting AXTreeIDs.

 
Cc: jamescook@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/336bc00667a7f428abf1bedb57b1729c1da34116

commit 336bc00667a7f428abf1bedb57b1729c1da34116
Author: Dominic Mazzoni <dmazzoni@chromium.org>
Date: Sun Sep 23 16:46:43 2018

Change type of AXTreeID from int to string.

There was a pervasive assumption throughout the code that
AXTreeID was a 32-bit int. This patch switches AXTreeID
to a std::string but doesn't otherwise change the
functionality, with a goal of cleaning up that assumption
everywhere.

As an ultimate goal I'd like to explore using
base::UnguessableToken for AXTreeID, and this is just
the first step. See bug for motivation and details.
Even if we decide not to go that route, I think this
is a worthwhile refactoring either way, to give
us the flexibility to change AXTreeID into any
type later.

Bug: 881986

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ic2c45d19ada492fa9c96222fb0666abd750ce1d1
Reviewed-on: https://chromium-review.googlesource.com/1212484
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593456}
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/ash/system/message_center/arc/arc_notification_content_view.cc
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/ash/system/message_center/arc/arc_notification_surface.h
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/ash/system/message_center/arc/arc_notification_surface_impl.cc
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/ash/system/message_center/arc/arc_notification_surface_impl.h
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/ash/system/message_center/arc/mock_arc_notification_surface.cc
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/ash/system/message_center/arc/mock_arc_notification_surface.h
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/ash/wm/non_client_frame_controller.cc
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/ash/wm/non_client_frame_controller_unittest.cc
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/chrome/browser/chromeos/accessibility/ax_host_service.cc
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/chrome/browser/chromeos/accessibility/ax_host_service.h
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge.cc
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge.h
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge_unittest.cc
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/chrome/browser/chromeos/arc/accessibility/ax_tree_source_arc.cc
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/chrome/browser/extensions/api/automation_internal/automation_event_router.cc
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/chrome/browser/extensions/api/automation_internal/automation_event_router.h
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/chrome/browser/extensions/api/automation_internal/automation_internal_api.cc
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/chrome/browser/ui/aura/accessibility/automation_manager_aura.cc
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/chrome/browser/ui/aura/accessibility/automation_manager_aura_browsertest.cc
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/chrome/browser/ui/aura/accessibility/ax_tree_source_aura.cc
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/chrome/common/BUILD.gn
[delete] https://crrev.com/441ab12f5f1171c41d48afebf05fd72c17e140a2/chrome/common/extensions/api/automation_api_constants.h
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/chrome/common/extensions/api/automation_internal.idl
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/chrome/common/extensions/chrome_extension_messages.h
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/chrome/renderer/extensions/automation_ax_tree_wrapper.cc
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/chrome/renderer/extensions/automation_ax_tree_wrapper.h
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/chrome/renderer/extensions/automation_internal_custom_bindings.cc
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/chrome/renderer/extensions/automation_internal_custom_bindings.h
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/chrome/renderer/resources/extensions/automation/automation_node.js
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/chrome/renderer/resources/extensions/automation_custom_bindings.js
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/chromecast/browser/extensions/api/automation_internal/automation_event_router.cc
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/chromecast/browser/extensions/api/automation_internal/automation_event_router.h
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/chromecast/browser/extensions/api/automation_internal/automation_internal_api.cc
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/chromecast/browser/ui/aura/accessibility/automation_manager_aura.cc
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/chromecast/browser/ui/aura/accessibility/ax_tree_source_aura.cc
[delete] https://crrev.com/441ab12f5f1171c41d48afebf05fd72c17e140a2/chromecast/common/extensions_api/automation_api_constants.h
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/chromecast/common/extensions_api/automation_internal.idl
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/chromecast/common/extensions_api/cast_extension_messages.h
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/chromecast/renderer/extensions/automation_ax_tree_wrapper.cc
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/chromecast/renderer/extensions/automation_ax_tree_wrapper.h
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/chromecast/renderer/extensions/automation_internal_custom_bindings.cc
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/chromecast/renderer/extensions/automation_internal_custom_bindings.h
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/components/exo/shell_surface_base.cc
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/components/exo/shell_surface_base.h
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/content/browser/accessibility/accessibility_tree_formatter_blink.cc
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/content/browser/accessibility/browser_accessibility.cc
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/content/browser/accessibility/browser_accessibility_manager.cc
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/content/browser/accessibility/browser_accessibility_manager.h
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/content/browser/accessibility/browser_accessibility_position.cc
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/content/browser/accessibility/browser_accessibility_position.h
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/content/browser/renderer_host/render_widget_host_view_aura.cc
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/content/browser/renderer_host/render_widget_host_view_aura.h
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/content/browser/renderer_host/render_widget_host_view_base.h
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/content/public/browser/ax_event_notification_details.cc
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/content/public/browser/ax_event_notification_details.h
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/content/public/browser/render_frame_host.h
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/ui/accessibility/BUILD.gn
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/ui/accessibility/ax_action_data.h
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/ui/accessibility/ax_enum_util.cc
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/ui/accessibility/ax_enums.mojom
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/ui/accessibility/ax_host_delegate.cc
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/ui/accessibility/ax_host_delegate.h
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/ui/accessibility/ax_node_data.cc
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/ui/accessibility/ax_node_position.cc
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/ui/accessibility/ax_node_position.h
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/ui/accessibility/ax_node_position_unittest.cc
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/ui/accessibility/ax_position.h
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/ui/accessibility/ax_tree.cc
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/ui/accessibility/ax_tree.h
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/ui/accessibility/ax_tree_combiner.cc
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/ui/accessibility/ax_tree_combiner.h
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/ui/accessibility/ax_tree_combiner_unittest.cc
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/ui/accessibility/ax_tree_data.cc
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/ui/accessibility/ax_tree_data.h
[add] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/ui/accessibility/ax_tree_id.cc
[add] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/ui/accessibility/ax_tree_id.h
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/ui/accessibility/ax_tree_id_registry.cc
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/ui/accessibility/ax_tree_id_registry.h
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/ui/accessibility/ax_tree_unittest.cc
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/ui/accessibility/mojom/ax_action_data.mojom
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/ui/accessibility/mojom/ax_action_data_mojom_traits.cc
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/ui/accessibility/mojom/ax_action_data_mojom_traits.h
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/ui/accessibility/mojom/ax_action_data_mojom_traits_unittest.cc
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/ui/accessibility/mojom/ax_host.mojom
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/ui/accessibility/mojom/ax_tree_data.mojom
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/ui/accessibility/mojom/ax_tree_data_mojom_traits.cc
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/ui/accessibility/mojom/ax_tree_data_mojom_traits.h
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/ui/accessibility/mojom/ax_tree_data_mojom_traits_unittest.cc
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/ui/accessibility/platform/aura_window_properties.cc
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/ui/accessibility/platform/aura_window_properties.h
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/ui/views/accessibility/ax_window_obj_wrapper.cc
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/ui/views/mus/ax_remote_host.cc
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/ui/views/mus/ax_remote_host.h
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/ui/views/mus/ax_remote_host_unittest.cc
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/ui/views/mus/ax_tree_source_mus.cc
[modify] https://crrev.com/336bc00667a7f428abf1bedb57b1729c1da34116/ui/views/mus/ax_tree_source_mus_unittest.cc

My understanding from email discussion:
* Browser generates the UnguessableToken and sends it to the renderers
* Browser verifies that the tokens it gets back are valid, and not spoofed by malicious renderer

The implication for mojo apps is that they cannot generate their own AXTreeID, and instead must get one from a registry on startup.

Is that right?

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a69d4b4afa399d51d93d855cad60d3bbe463044

commit 3a69d4b4afa399d51d93d855cad60d3bbe463044
Author: Dominic Mazzoni <dmazzoni@chromium.org>
Date: Fri Sep 28 23:44:30 2018

Make AXTreeID into a mojo struct.

Currently it's just a mojo struct containing a string, but it should be
relatively easy to turn it into a different type now.

Follow-up to http://crrev.com/c/1212484 - eventually we may want this to
be a base::UnguessableToken. This change should completely eliminate any
assumption that ui::AXTreeID is a particular type, only that it's possible
to serialize and unserialize it as a string (which is necessary because
we need this to be passed through JavaScript APIs).

Bug: 881986
Change-Id: Ifb53e4ca2ea56c53488c89d6df188a1f131197ae
Reviewed-on: https://chromium-review.googlesource.com/1246297
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595254}
[modify] https://crrev.com/3a69d4b4afa399d51d93d855cad60d3bbe463044/ash/wm/non_client_frame_controller_unittest.cc
[modify] https://crrev.com/3a69d4b4afa399d51d93d855cad60d3bbe463044/chrome/browser/chromeos/accessibility/ax_host_service.cc
[modify] https://crrev.com/3a69d4b4afa399d51d93d855cad60d3bbe463044/chrome/browser/chromeos/accessibility/ax_host_service.h
[modify] https://crrev.com/3a69d4b4afa399d51d93d855cad60d3bbe463044/chrome/browser/chromeos/arc/accessibility/ax_tree_source_arc.cc
[modify] https://crrev.com/3a69d4b4afa399d51d93d855cad60d3bbe463044/chrome/browser/extensions/api/automation_internal/automation_internal_api.cc
[modify] https://crrev.com/3a69d4b4afa399d51d93d855cad60d3bbe463044/chrome/browser/ui/aura/accessibility/automation_manager_aura.cc
[modify] https://crrev.com/3a69d4b4afa399d51d93d855cad60d3bbe463044/chrome/browser/ui/aura/accessibility/automation_manager_aura_browsertest.cc
[modify] https://crrev.com/3a69d4b4afa399d51d93d855cad60d3bbe463044/chrome/common/extensions/chrome_extension_messages.h
[modify] https://crrev.com/3a69d4b4afa399d51d93d855cad60d3bbe463044/chrome/renderer/extensions/automation_internal_custom_bindings.cc
[modify] https://crrev.com/3a69d4b4afa399d51d93d855cad60d3bbe463044/chromecast/browser/extensions/api/automation_internal/automation_internal_api.cc
[modify] https://crrev.com/3a69d4b4afa399d51d93d855cad60d3bbe463044/chromecast/common/extensions_api/cast_extension_messages.h
[modify] https://crrev.com/3a69d4b4afa399d51d93d855cad60d3bbe463044/chromecast/renderer/extensions/automation_internal_custom_bindings.cc
[modify] https://crrev.com/3a69d4b4afa399d51d93d855cad60d3bbe463044/content/browser/accessibility/browser_accessibility.cc
[modify] https://crrev.com/3a69d4b4afa399d51d93d855cad60d3bbe463044/content/browser/accessibility/browser_accessibility_manager.cc
[modify] https://crrev.com/3a69d4b4afa399d51d93d855cad60d3bbe463044/content/public/common/common_param_traits.cc
[modify] https://crrev.com/3a69d4b4afa399d51d93d855cad60d3bbe463044/content/public/common/common_param_traits.h
[modify] https://crrev.com/3a69d4b4afa399d51d93d855cad60d3bbe463044/ui/accessibility/BUILD.gn
[modify] https://crrev.com/3a69d4b4afa399d51d93d855cad60d3bbe463044/ui/accessibility/ax_node_position_unittest.cc
[modify] https://crrev.com/3a69d4b4afa399d51d93d855cad60d3bbe463044/ui/accessibility/ax_position.h
[modify] https://crrev.com/3a69d4b4afa399d51d93d855cad60d3bbe463044/ui/accessibility/ax_tree.cc
[modify] https://crrev.com/3a69d4b4afa399d51d93d855cad60d3bbe463044/ui/accessibility/ax_tree_combiner.cc
[modify] https://crrev.com/3a69d4b4afa399d51d93d855cad60d3bbe463044/ui/accessibility/ax_tree_combiner_unittest.cc
[modify] https://crrev.com/3a69d4b4afa399d51d93d855cad60d3bbe463044/ui/accessibility/ax_tree_data.cc
[modify] https://crrev.com/3a69d4b4afa399d51d93d855cad60d3bbe463044/ui/accessibility/ax_tree_id.cc
[modify] https://crrev.com/3a69d4b4afa399d51d93d855cad60d3bbe463044/ui/accessibility/ax_tree_id.h
[modify] https://crrev.com/3a69d4b4afa399d51d93d855cad60d3bbe463044/ui/accessibility/ax_tree_id_registry.cc
[modify] https://crrev.com/3a69d4b4afa399d51d93d855cad60d3bbe463044/ui/accessibility/ax_tree_unittest.cc
[modify] https://crrev.com/3a69d4b4afa399d51d93d855cad60d3bbe463044/ui/accessibility/mojom/BUILD.gn
[modify] https://crrev.com/3a69d4b4afa399d51d93d855cad60d3bbe463044/ui/accessibility/mojom/ax_action_data.mojom
[modify] https://crrev.com/3a69d4b4afa399d51d93d855cad60d3bbe463044/ui/accessibility/mojom/ax_action_data_mojom_traits.h
[modify] https://crrev.com/3a69d4b4afa399d51d93d855cad60d3bbe463044/ui/accessibility/mojom/ax_action_data_mojom_traits_unittest.cc
[modify] https://crrev.com/3a69d4b4afa399d51d93d855cad60d3bbe463044/ui/accessibility/mojom/ax_host.mojom
[modify] https://crrev.com/3a69d4b4afa399d51d93d855cad60d3bbe463044/ui/accessibility/mojom/ax_tree_data.mojom
[modify] https://crrev.com/3a69d4b4afa399d51d93d855cad60d3bbe463044/ui/accessibility/mojom/ax_tree_data_mojom_traits.h
[modify] https://crrev.com/3a69d4b4afa399d51d93d855cad60d3bbe463044/ui/accessibility/mojom/ax_tree_data_mojom_traits_unittest.cc
[add] https://crrev.com/3a69d4b4afa399d51d93d855cad60d3bbe463044/ui/accessibility/mojom/ax_tree_id.mojom
[add] https://crrev.com/3a69d4b4afa399d51d93d855cad60d3bbe463044/ui/accessibility/mojom/ax_tree_id.typemap
[add] https://crrev.com/3a69d4b4afa399d51d93d855cad60d3bbe463044/ui/accessibility/mojom/ax_tree_id_mojom_traits.cc
[add] https://crrev.com/3a69d4b4afa399d51d93d855cad60d3bbe463044/ui/accessibility/mojom/ax_tree_id_mojom_traits.h
[add] https://crrev.com/3a69d4b4afa399d51d93d855cad60d3bbe463044/ui/accessibility/mojom/ax_tree_id_mojom_traits_unittest.cc
[modify] https://crrev.com/3a69d4b4afa399d51d93d855cad60d3bbe463044/ui/accessibility/mojom/typemaps.gni
[modify] https://crrev.com/3a69d4b4afa399d51d93d855cad60d3bbe463044/ui/accessibility/platform/aura_window_properties.cc
[modify] https://crrev.com/3a69d4b4afa399d51d93d855cad60d3bbe463044/ui/views/mus/ax_remote_host_unittest.cc
[modify] https://crrev.com/3a69d4b4afa399d51d93d855cad60d3bbe463044/ui/views/mus/ax_tree_source_mus.cc
[modify] https://crrev.com/3a69d4b4afa399d51d93d855cad60d3bbe463044/ui/views/mus/ax_tree_source_mus_unittest.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Dec 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e29985855382cc1726a1f62d02e087d06f3f0533

commit e29985855382cc1726a1f62d02e087d06f3f0533
Author: Dominic Mazzoni <dmazzoni@chromium.org>
Date: Wed Dec 05 01:48:27 2018

Make AXTreeID an unguessable token.

This is one step towards eventually using AXTreeID in
renderers in place of routing IDs.

Bug: 881986

Change-Id: I7e9d1e3456b44c3fc609eca1460f5605f22d318c
Reviewed-on: https://chromium-review.googlesource.com/c/1339463
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613807}
[modify] https://crrev.com/e29985855382cc1726a1f62d02e087d06f3f0533/ash/system/message_center/arc/arc_notification_content_view.cc
[modify] https://crrev.com/e29985855382cc1726a1f62d02e087d06f3f0533/chrome/browser/extensions/api/automation_internal/automation_event_router.cc
[modify] https://crrev.com/e29985855382cc1726a1f62d02e087d06f3f0533/chrome/browser/extensions/api/automation_internal/automation_internal_api.cc
[modify] https://crrev.com/e29985855382cc1726a1f62d02e087d06f3f0533/chromecast/browser/extensions/api/automation_internal/automation_event_router.cc
[modify] https://crrev.com/e29985855382cc1726a1f62d02e087d06f3f0533/components/exo/shell_surface_base.cc
[modify] https://crrev.com/e29985855382cc1726a1f62d02e087d06f3f0533/content/browser/accessibility/browser_accessibility_manager.cc
[modify] https://crrev.com/e29985855382cc1726a1f62d02e087d06f3f0533/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/e29985855382cc1726a1f62d02e087d06f3f0533/ui/accessibility/ax_enums.mojom
[modify] https://crrev.com/e29985855382cc1726a1f62d02e087d06f3f0533/ui/accessibility/ax_tree_combiner_unittest.cc
[modify] https://crrev.com/e29985855382cc1726a1f62d02e087d06f3f0533/ui/accessibility/ax_tree_id.cc
[modify] https://crrev.com/e29985855382cc1726a1f62d02e087d06f3f0533/ui/accessibility/ax_tree_id.h
[modify] https://crrev.com/e29985855382cc1726a1f62d02e087d06f3f0533/ui/accessibility/ax_tree_id_registry.cc
[modify] https://crrev.com/e29985855382cc1726a1f62d02e087d06f3f0533/ui/accessibility/ax_tree_id_registry.h
[modify] https://crrev.com/e29985855382cc1726a1f62d02e087d06f3f0533/ui/accessibility/ax_tree_unittest.cc
[modify] https://crrev.com/e29985855382cc1726a1f62d02e087d06f3f0533/ui/accessibility/mojom/ax_action_data_mojom_traits_unittest.cc
[modify] https://crrev.com/e29985855382cc1726a1f62d02e087d06f3f0533/ui/accessibility/mojom/ax_tree_data_mojom_traits_unittest.cc
[modify] https://crrev.com/e29985855382cc1726a1f62d02e087d06f3f0533/ui/accessibility/mojom/ax_tree_id.mojom
[modify] https://crrev.com/e29985855382cc1726a1f62d02e087d06f3f0533/ui/accessibility/mojom/ax_tree_id_mojom_traits.cc
[modify] https://crrev.com/e29985855382cc1726a1f62d02e087d06f3f0533/ui/accessibility/mojom/ax_tree_id_mojom_traits.h
[modify] https://crrev.com/e29985855382cc1726a1f62d02e087d06f3f0533/ui/accessibility/mojom/ax_tree_id_mojom_traits_unittest.cc
[modify] https://crrev.com/e29985855382cc1726a1f62d02e087d06f3f0533/ui/views/accessibility/ax_tree_source_views_unittest.cc
[modify] https://crrev.com/e29985855382cc1726a1f62d02e087d06f3f0533/ui/views/controls/webview/webview.cc
[modify] https://crrev.com/e29985855382cc1726a1f62d02e087d06f3f0533/ui/views/mus/ax_remote_host_unittest.cc
[modify] https://crrev.com/e29985855382cc1726a1f62d02e087d06f3f0533/ui/views/mus/ax_tree_source_mus_unittest.cc

Sign in to add a comment