New issue
Advanced search Search tips

Issue 881976 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 26
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
Proj-Servicification

Blocking:
issue 827532



Sign in to add a comment

Run interactive_ui_tests and layout tests with Network Service enabled on Mojo ChromiumOS bot

Project Member Reported by chongz@chromium.org, Sep 7

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Sep 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b563abfa3254df8b38a14fd07c8601ec76384cc

commit 9b563abfa3254df8b38a14fd07c8601ec76384cc
Author: Chong Zhang <chongz@chromium.org>
Date: Thu Sep 13 00:09:20 2018

Add Network Service tests to Mojo ChromiumOS

This patch adds the following test suites to Mojo ChromiumOS:
* browser_tests (~120 failing tests)
* components_browsertests (pass)
* content_browsertests (pass)
* extensions_browsertests (pass)

Note: interactive_ui_tests and layout tests have too many failures, and
I will add them later after browser_tests became healthier.

Bug:  881976 
Change-Id: I72cfb191c0de41fcbeda7ee10f67b3b2f544285b
Reviewed-on: https://chromium-review.googlesource.com/1211981
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Chong Zhang <chongz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590870}
[modify] https://crrev.com/9b563abfa3254df8b38a14fd07c8601ec76384cc/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/9b563abfa3254df8b38a14fd07c8601ec76384cc/testing/buildbot/filters/BUILD.gn
[add] https://crrev.com/9b563abfa3254df8b38a14fd07c8601ec76384cc/testing/buildbot/filters/mojo.fyi.chromeos.network_browser_tests.filter
[modify] https://crrev.com/9b563abfa3254df8b38a14fd07c8601ec76384cc/testing/buildbot/test_suites.pyl

Labels: Hotlist-KnownIssue
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a92ab0eb4d5c2af3d22dc48a3bda635df02eca9c

commit a92ab0eb4d5c2af3d22dc48a3bda635df02eca9c
Author: Chong Zhang <chongz@chromium.org>
Date: Wed Sep 19 22:22:59 2018

Expand * in Mojo ChromiumOS Network Service test filters

Count increased ~120 => ~370 due to the removal of asterisks.

Bug:  881976 
Change-Id: I3999b9d56f76a69c1284b17ca703f960c5078325
Reviewed-on: https://chromium-review.googlesource.com/1226135
Commit-Queue: Chong Zhang <chongz@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592577}
[modify] https://crrev.com/a92ab0eb4d5c2af3d22dc48a3bda635df02eca9c/testing/buildbot/filters/mojo.fyi.chromeos.network_browser_tests.filter

Status: Fixed (was: Started)
Cc: chongz@chromium.org
Owner: ----
Status: Available (was: Fixed)
Summary: Run interactive_ui_tests and layout tests with Network Service enabled on Mojo ChromiumOS bot (was: Run tests with Network Service enabled on Mojo ChromiumOS bot)
Remaining tests are interactive_ui_tests and layout tests. We want to add them after we got less failing browser tests.
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a2285f519d45a4ef2f2ce59d44ca8a1268720626

commit a2285f519d45a4ef2f2ce59d44ca8a1268720626
Author: Chong Zhang <chongz@chromium.org>
Date: Fri Sep 28 19:53:58 2018

NetworkService: Enable now passing tests on Chrome OS

Some tests (e.g. ArcSessionManagerTest.ConsumerAccount) are already
flaky on waterfall, and we don't want them here to avoid confusions.

Bug:  881976 
Change-Id: Iddc8fd5f18ab6abe54038a5078750bf16968c272
Reviewed-on: https://chromium-review.googlesource.com/1252011
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Chong Zhang <chongz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595186}
[modify] https://crrev.com/a2285f519d45a4ef2f2ce59d44ca8a1268720626/testing/buildbot/filters/mojo.fyi.chromeos.network_browser_tests.filter

Project Member

Comment 7 by bugdroid1@chromium.org, Oct 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8be05b00bf19ac9765ef92a002eb16f4c5809920

commit 8be05b00bf19ac9765ef92a002eb16f4c5809920
Author: Chong Zhang <chongz@chromium.org>
Date: Tue Oct 02 21:49:58 2018

NetworkService: Triage failing Chrome OS tests

Triaged failings tests with --enable-pixel-output-in-tests to give more
context.

Bug:  881976 
Change-Id: I086bbc5d367adb695dfa494b21a82de9d8149aa4
Reviewed-on: https://chromium-review.googlesource.com/c/1252586
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Chong Zhang <chongz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595995}
[modify] https://crrev.com/8be05b00bf19ac9765ef92a002eb16f4c5809920/testing/buildbot/filters/mojo.fyi.chromeos.network_browser_tests.filter

Project Member

Comment 8 by bugdroid1@chromium.org, Oct 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47ed9b8041cbc3e3394dae7febb714c503884c23

commit 47ed9b8041cbc3e3394dae7febb714c503884c23
Author: Robbie McElrath <rmcelrath@chromium.org>
Date: Fri Oct 05 18:43:09 2018

Add bug links to some filtered tests in chromeos with network service

Bug:  881976 
Change-Id: I39b93d0db822c341c7834ee100be957eaecbd15d
Reviewed-on: https://chromium-review.googlesource.com/c/1263046
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597212}
[modify] https://crrev.com/47ed9b8041cbc3e3394dae7febb714c503884c23/testing/buildbot/filters/mojo.fyi.chromeos.network_browser_tests.filter

Project Member

Comment 9 by bugdroid1@chromium.org, Oct 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1656401147dc8e723d219ca7b598c29510c30f44

commit 1656401147dc8e723d219ca7b598c29510c30f44
Author: John Abd-El-Malek <jam@chromium.org>
Date: Wed Oct 17 16:12:28 2018

Fix ChromeOS browser tests that use TestRequestInterceptor with network service.

That class didn't work with networking running out-of-process. Convert similar to r571184.

Bug:  881976 
Change-Id: If38e590e58ba6fb86921e606b87b1eb603e4a128
Reviewed-on: https://chromium-review.googlesource.com/c/1279960
Reviewed-by: Yury Khmel <khmel@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600410}
[modify] https://crrev.com/1656401147dc8e723d219ca7b598c29510c30f44/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/1656401147dc8e723d219ca7b598c29510c30f44/chrome/browser/chromeos/arc/arc_session_manager_browsertest.cc
[modify] https://crrev.com/1656401147dc8e723d219ca7b598c29510c30f44/chrome/browser/chromeos/arc/auth/arc_active_directory_enrollment_token_fetcher.cc
[modify] https://crrev.com/1656401147dc8e723d219ca7b598c29510c30f44/chrome/browser/chromeos/arc/auth/arc_active_directory_enrollment_token_fetcher_browsertest.cc
[modify] https://crrev.com/1656401147dc8e723d219ca7b598c29510c30f44/chrome/browser/chromeos/arc/auth/arc_auth_service.cc
[modify] https://crrev.com/1656401147dc8e723d219ca7b598c29510c30f44/chrome/browser/chromeos/arc/auth/arc_auth_service.h
[modify] https://crrev.com/1656401147dc8e723d219ca7b598c29510c30f44/chrome/browser/chromeos/arc/auth/arc_auth_service_browsertest.cc
[add] https://crrev.com/1656401147dc8e723d219ca7b598c29510c30f44/chrome/browser/chromeos/arc/auth/arc_fetcher_base.cc
[modify] https://crrev.com/1656401147dc8e723d219ca7b598c29510c30f44/chrome/browser/chromeos/arc/auth/arc_fetcher_base.h
[modify] https://crrev.com/1656401147dc8e723d219ca7b598c29510c30f44/chrome/browser/chromeos/arc/auth/arc_robot_auth_code_fetcher.cc
[modify] https://crrev.com/1656401147dc8e723d219ca7b598c29510c30f44/chrome/browser/chromeos/arc/auth/arc_robot_auth_code_fetcher_browsertest.cc
[modify] https://crrev.com/1656401147dc8e723d219ca7b598c29510c30f44/chrome/browser/policy/cloud/cloud_policy_manager_browsertest.cc
[modify] https://crrev.com/1656401147dc8e723d219ca7b598c29510c30f44/chrome/browser/policy/cloud/device_management_service_browsertest.cc
[delete] https://crrev.com/0d9526b0afb588ebe994108cfdd85d4b772862fc/chrome/browser/policy/cloud/test_request_interceptor.cc
[delete] https://crrev.com/0d9526b0afb588ebe994108cfdd85d4b772862fc/chrome/browser/policy/cloud/test_request_interceptor.h
[modify] https://crrev.com/1656401147dc8e723d219ca7b598c29510c30f44/chrome/browser/policy/policy_browsertest.cc
[modify] https://crrev.com/1656401147dc8e723d219ca7b598c29510c30f44/chrome/test/BUILD.gn
[modify] https://crrev.com/1656401147dc8e723d219ca7b598c29510c30f44/testing/buildbot/filters/mojo.fyi.chromeos.network_browser_tests.filter

Cc: -chongz@chromium.org
Owner: rmcelrath@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 12 by bugdroid1@chromium.org, Oct 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2211ee10fe0af5ee92ad7d98331709390c68fcc6

commit 2211ee10fe0af5ee92ad7d98331709390c68fcc6
Author: Robbie McElrath <rmcelrath@chromium.org>
Date: Thu Oct 25 21:47:46 2018

Fix mojo.fyi.chromeos.network_interactive_ui_tests.filter

Bug:  881976 
Change-Id: If0199e2a82405769f3953ad12d931c0b721f94c3
Reviewed-on: https://chromium-review.googlesource.com/c/1299920
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602869}
[modify] https://crrev.com/2211ee10fe0af5ee92ad7d98331709390c68fcc6/testing/buildbot/filters/BUILD.gn

Status: Fixed (was: Assigned)
We decided not to run layout_tests because they don't even run on the normal chromeos bot and don't pass there. We can add them to the chromeos mojo bot if/when they get enabled for the normal chromeos bots.

We have all the other tests running and will track test failures there as separate bugs.
Project Member

Comment 14 by bugdroid1@chromium.org, Nov 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b10115b2410b4bde18e094ad9fb8c5056134c87

commit 8b10115b2410b4bde18e094ad9fb8c5056134c87
Author: John Abd-El-Malek <jam@chromium.org>
Date: Tue Nov 13 18:08:01 2018

Fix ChromeResourceDispatcherHostDelegateMirrorBrowserTest.MirrorRequestHeader with network service.

The functionality worked, as part of converting DICE, however the test code didn't work since it
depended on accessing the net objects directly. Switch the tests to use the EmbeddedTestServer, to
better match production, which removes the dependency on net/.

Also:
-make GetFilePathWithReplacements replace strings in the mock headers if they're present
-add a global to google_util to ignore ports; that way other tests can be converted without having
  to modify each callsite to google_util

Bug:  881976 
Change-Id: Ic52023495c1c98c1248025c11cdf37f433fef058
Reviewed-on: https://chromium-review.googlesource.com/c/1328142
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607652}
[modify] https://crrev.com/8b10115b2410b4bde18e094ad9fb8c5056134c87/chrome/browser/loader/chrome_resource_dispatcher_host_delegate_browsertest.cc
[delete] https://crrev.com/f60bc42e73d321c81ec137009e89b4441f3d06a2/chrome/test/data/mirror_request_header/http.redirected_from_header_adder.html
[delete] https://crrev.com/f60bc42e73d321c81ec137009e89b4441f3d06a2/chrome/test/data/mirror_request_header/http.redirected_from_header_adder.html.mock-http-headers
[modify] https://crrev.com/8b10115b2410b4bde18e094ad9fb8c5056134c87/chrome/test/data/mirror_request_header/http.www.google.com.html.mock-http-headers
[modify] https://crrev.com/8b10115b2410b4bde18e094ad9fb8c5056134c87/chrome/test/data/mirror_request_header/http.www.header_adder.com.html.mock-http-headers
[delete] https://crrev.com/f60bc42e73d321c81ec137009e89b4441f3d06a2/chrome/test/data/mirror_request_header/http.www.redirected.com.html
[delete] https://crrev.com/f60bc42e73d321c81ec137009e89b4441f3d06a2/chrome/test/data/mirror_request_header/http.www.redirected.com.html.mock-http-headers
[modify] https://crrev.com/8b10115b2410b4bde18e094ad9fb8c5056134c87/chrome/test/data/mirror_request_header/https.www.google.com.html.mock-http-headers
[delete] https://crrev.com/f60bc42e73d321c81ec137009e89b4441f3d06a2/chrome/test/data/mirror_request_header/https.www.redirected.com.html
[delete] https://crrev.com/f60bc42e73d321c81ec137009e89b4441f3d06a2/chrome/test/data/mirror_request_header/https.www.redirected.com.html.mock-http-headers
[modify] https://crrev.com/8b10115b2410b4bde18e094ad9fb8c5056134c87/components/google/core/common/google_util.cc
[modify] https://crrev.com/8b10115b2410b4bde18e094ad9fb8c5056134c87/components/google/core/common/google_util.h
[modify] https://crrev.com/8b10115b2410b4bde18e094ad9fb8c5056134c87/net/test/embedded_test_server/request_handler_util.cc
[modify] https://crrev.com/8b10115b2410b4bde18e094ad9fb8c5056134c87/testing/buildbot/filters/mojo.fyi.chromeos.network_browser_tests.filter

Sign in to add a comment