New issue
Advanced search Search tips

Issue 881971 link

Starred by 1 user
Status: Fixed
Owner:
spang@chromium.org
Closed: Oct 26
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

NOTREACHED() hit in DrmGpuPlatformSupportHost

Project Member Reported by spang@chromium.org, Sep 7 
Non-CrOS builds are hitting NOTREACHED() in DrmGpuPlatformSupportHost, because viz thinks DRM mojo IPC is enabled but it is not.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 12 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf104c9fe9f11c6d48c42a1a9fe3bce98d2578d9

commit bf104c9fe9f11c6d48c42a1a9fe3bce98d2578d9
Author: Michael Spang <spang@chromium.org>
Date: Wed Sep 12 23:19:33 2018

ozone: Clean up features::IsOzoneDrmMojo() usage

Don't check OS_CHROMEOS as this is done inconsistently, and thus leads to
components being out of sync about mojo usage.

Bug:  881971 
Test: compile

Change-Id: I3f6c0f2eee6ef430e2147a1ce653789513ba8d6b
Reviewed-on: https://chromium-review.googlesource.com/1214166
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590852}
[modify] https://crrev.com/bf104c9fe9f11c6d48c42a1a9fe3bce98d2578d9/components/viz/host/gpu_host_impl.cc
[modify] https://crrev.com/bf104c9fe9f11c6d48c42a1a9fe3bce98d2578d9/gpu/ipc/service/gpu_init.cc

Comment 2 by spang@chromium.org, Oct 26

Status: Fixed (was: Started)
►

Sign in to add a comment