New issue
Advanced search Search tips

Issue 881961 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 11
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

devtools network panel shows "(from ServiceWorker)" for some resources loaded from memory cache

Project Member Reported by wanderview@chromium.org, Sep 7

Issue description

Steps to reproduce:

1. Load https://blog.wanderview.com and open devtools network monitor
2. Reload a few times
3. Note that the "highlighter-small.jpg" resource is marked as "(from ServiceWorker)".
4. Click on the resource and note that it has no service worker related timing information.

This resource is actually loaded from the memory cache.  It was initially loaded from the service worker when the memory cache was populated.  I think it would make most sense for the devtools to report that it loaded from memory cache since there will not be any observable FetchEvent in this case.

CL coming.
 
This fixes it for me, but I need to add a test still:

https://chromium-review.googlesource.com/c/chromium/src/+/1214046
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/82a2dd3499e33caf58ab9dd13124d2ac8fb724b3

commit 82a2dd3499e33caf58ab9dd13124d2ac8fb724b3
Author: Ben Kelly <wanderview@chromium.org>
Date: Tue Sep 11 17:05:50 2018

Display "(from memory cache)" when loading ServiceWorker-produced resources from memory cache.

Bug:  881961 
Change-Id: Ie58d071b3a80f48274991eaed799fc144da1d6a1
Reviewed-on: https://chromium-review.googlesource.com/1214046
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590358}
[modify] https://crrev.com/82a2dd3499e33caf58ab9dd13124d2ac8fb724b3/third_party/blink/renderer/devtools/front_end/network/NetworkDataGridNode.js
[modify] https://crrev.com/82a2dd3499e33caf58ab9dd13124d2ac8fb724b3/third_party/blink/renderer/devtools/front_end/network/RequestHeadersView.js

Status: Fixed (was: Started)

Sign in to add a comment