New issue
Advanced search Search tips

Issue 881957 link

Starred by 1 user
Status: Verified
Owner:
boliu@chromium.org
Closed: Sep 11
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Tile resource wasn't released when enable use-zoom-for-dsf

Project Member Reported by eirage@chromium.org, Sep 7 
When --use-zoom-for-dsf is enabled, some ReturnedResources added in RenderThreadManager::InsertReturnedResourcesOnRT wasn't returned. So they were kept as busy_resources. 
This causes memory regression like https://chromeperf.appspot.com/group_report?bug_id=871384
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d8d0e26871adce7024452945a9aec30ac18989c

commit 0d8d0e26871adce7024452945a9aec30ac18989c
Author: Bo Liu <boliu@chromium.org>
Date: Tue Sep 11 22:13:27 2018

aw: ReturnedResourceAvailable

Resources are only explicitly returned from OnDraw. This means it's
possible for resources to be stuck in RenderThreadManager
returned_resources_map_ indefinitely, if OnDraw stops.

Post a task with roughly 2 frames of delay to return these resources to
ensure that they don't get stuck indefinitely.

Bug:  881957 
Change-Id: I2a6331b9251b4057125761eb9fb0aaf29c881eeb
Reviewed-on: https://chromium-review.googlesource.com/1214700
Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590501}
[modify] https://crrev.com/0d8d0e26871adce7024452945a9aec30ac18989c/android_webview/browser/browser_view_renderer.cc
[modify] https://crrev.com/0d8d0e26871adce7024452945a9aec30ac18989c/android_webview/browser/browser_view_renderer.h
[modify] https://crrev.com/0d8d0e26871adce7024452945a9aec30ac18989c/android_webview/browser/compositor_frame_producer.h
[modify] https://crrev.com/0d8d0e26871adce7024452945a9aec30ac18989c/android_webview/browser/render_thread_manager.cc
[modify] https://crrev.com/0d8d0e26871adce7024452945a9aec30ac18989c/android_webview/browser/render_thread_manager.h

Comment 2 by boliu@chromium.org, Sep 11

Status: Verified (was: Assigned)

Comment 3 by eirage@chromium.org, Sep 12 

Thanks Bo for fixing this!
►

Sign in to add a comment