New issue
Advanced search Search tips

Issue 881944 link

Starred by 1 user
Status: Fixed
Owner:
zentaro@chromium.org
Closed: Sep 7
Cc:
baileyberro@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Enable SMB feature by default in M70 and merge

Project Member Reported by zentaro@chromium.org, Sep 7 
Requesting merge to M70 for these two CL's

These two CL's just missed the branch point. One enables our feature, and one fixes a test required to enable the feature.

https://chromium-review.googlesource.com/c/chromium/src/+/1197222
https://chromium-review.googlesource.com/c/chromium/src/+/1194790

They were originally landed against  crbug.com/757625  but that is a master bug that has a lot of CL's so I created this to make it clear which changes we are requesting be merged.

FYI launch bug is here crbug.com/865443
Project Member

Comment 1 by sheriffbot@chromium.org, Sep 8

Labels: -Merge-Request-70 Hotlist-Merge-Approved Merge-Approved-70
Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 2 by sheriffbot@chromium.org, Sep 12 

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 3 by baileyberro@chromium.org, Sep 12

Labels: -Merge-Approved-70 Merge-Merged
►

Sign in to add a comment