New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 881937 link

Starred by 0 users
Status: Fixed
Owner:
█ scottchen@chromium.org
Last visit > 30 days ago
Closed: Jan 2
Cc:
cyflee@chromium.org
█ scottchen@chromium.org
hcarmona@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 874193



Sign in to add a comment

[Navi] Add unit tests for both front and backend codes

Project Member Reported by scottchen@chromium.org, Sep 7 
see title

Comment 1 by scottchen@chromium.org, Sep 19

Components: UI>Browser>FirstRun

Comment 2 by scottchen@chromium.org, Sep 19

Components: -UI>Browser>WebUI
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc94bd1e55d2e874f634794fd23aecd7d733de8c

commit fc94bd1e55d2e874f634794fd23aecd7d733de8c
Author: Hector Carmona <hcarmona@chromium.org>
Date: Tue Oct 30 03:05:44 2018

Navi: Revert bookmark bar state back to normal if users don't want navi.

Both the email and google app modules will show the bookmark bar. This
change makes it so that the state of the bookmark bar is returned to the
way it was before it was shown if no bookmarks are added.

R=scottchen@chromium.org

Bug:  881937 
Change-Id: I64d0a03f6747589d594720dad406e14ee4483ca8
Reviewed-on: https://chromium-review.googlesource.com/c/1302316
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603761}
[modify] https://crrev.com/fc94bd1e55d2e874f634794fd23aecd7d733de8c/chrome/browser/resources/welcome/onboarding_welcome/email/BUILD.gn
[modify] https://crrev.com/fc94bd1e55d2e874f634794fd23aecd7d733de8c/chrome/browser/resources/welcome/onboarding_welcome/email/email_chooser.html
[modify] https://crrev.com/fc94bd1e55d2e874f634794fd23aecd7d733de8c/chrome/browser/resources/welcome/onboarding_welcome/email/email_chooser.js
[modify] https://crrev.com/fc94bd1e55d2e874f634794fd23aecd7d733de8c/chrome/browser/resources/welcome/onboarding_welcome/email/nux_email.html
[modify] https://crrev.com/fc94bd1e55d2e874f634794fd23aecd7d733de8c/chrome/browser/resources/welcome/onboarding_welcome/email/nux_email.js
[modify] https://crrev.com/fc94bd1e55d2e874f634794fd23aecd7d733de8c/chrome/browser/resources/welcome/onboarding_welcome/email/nux_email_proxy.js
[modify] https://crrev.com/fc94bd1e55d2e874f634794fd23aecd7d733de8c/chrome/browser/resources/welcome/onboarding_welcome/google_apps/apps_chooser.js
[modify] https://crrev.com/fc94bd1e55d2e874f634794fd23aecd7d733de8c/chrome/browser/resources/welcome/onboarding_welcome/google_apps/nux_google_apps.html
[modify] https://crrev.com/fc94bd1e55d2e874f634794fd23aecd7d733de8c/chrome/browser/resources/welcome/onboarding_welcome/google_apps/nux_google_apps.js
[modify] https://crrev.com/fc94bd1e55d2e874f634794fd23aecd7d733de8c/chrome/browser/resources/welcome/onboarding_welcome/shared/bookmark_proxy.js
[modify] https://crrev.com/fc94bd1e55d2e874f634794fd23aecd7d733de8c/chrome/browser/ui/webui/welcome/nux/bookmark_handler.cc
[modify] https://crrev.com/fc94bd1e55d2e874f634794fd23aecd7d733de8c/chrome/browser/ui/webui/welcome/nux/bookmark_handler.h
[modify] https://crrev.com/fc94bd1e55d2e874f634794fd23aecd7d733de8c/chrome/browser/ui/webui/welcome/nux/email_handler.cc
[modify] https://crrev.com/fc94bd1e55d2e874f634794fd23aecd7d733de8c/chrome/browser/ui/webui/welcome/welcome_ui.cc
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7767728e96f4c30609bb6e33537e3e8f23d15d66

commit 7767728e96f4c30609bb6e33537e3e8f23d15d66
Author: Scott Chen <scottchen@chromium.org>
Date: Tue Oct 30 03:12:19 2018

Nux Onboarding: add email-chooser browswertest

This CL adds the boilerplate codes for browser-testing the onboarding
welcome UI, and one simple test to verify it works. There will be
follow-up CLs to add more browser tests to all onboarding welcome elements.

Bug:  881937 
Change-Id: I1c1d33411ad55eff5fd4ab43bd3cc1b93a257d3e
Reviewed-on: https://chromium-review.googlesource.com/c/1300673
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603766}
[modify] https://crrev.com/7767728e96f4c30609bb6e33537e3e8f23d15d66/chrome/browser/ui/webui/welcome/nux_helper.cc
[modify] https://crrev.com/7767728e96f4c30609bb6e33537e3e8f23d15d66/chrome/browser/ui/webui/welcome/nux_helper.h
[modify] https://crrev.com/7767728e96f4c30609bb6e33537e3e8f23d15d66/chrome/test/data/webui/BUILD.gn
[add] https://crrev.com/7767728e96f4c30609bb6e33537e3e8f23d15d66/chrome/test/data/webui/welcome/email_chooser_test.js
[add] https://crrev.com/7767728e96f4c30609bb6e33537e3e8f23d15d66/chrome/test/data/webui/welcome/onboarding_welcome_browsertest.js
[add] https://crrev.com/7767728e96f4c30609bb6e33537e3e8f23d15d66/chrome/test/data/webui/welcome/test_nux_email_proxy.js
[modify] https://crrev.com/7767728e96f4c30609bb6e33537e3e8f23d15d66/testing/buildbot/filters/webui_polymer2_browser_tests.filter

Comment 6 by scottchen@chromium.org, Nov 1

Owner: scottchen@chromium.org
Status: Started (was: Available)
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa3218295ace83bf6287ddfcd3e74b0ceb9214c2

commit fa3218295ace83bf6287ddfcd3e74b0ceb9214c2
Author: Scott Chen <scottchen@chromium.org>
Date: Fri Nov 09 22:31:31 2018

Nux Onboarding: add browser tests for welcome-app

Bug:  881937 
Change-Id: Iac86251f6f6d7bba501b2add3260579d2f2ba53b
Reviewed-on: https://chromium-review.googlesource.com/c/1327569
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607006}
[modify] https://crrev.com/fa3218295ace83bf6287ddfcd3e74b0ceb9214c2/chrome/browser/resources/welcome/onboarding_welcome/welcome_app.js
[add] https://crrev.com/fa3218295ace83bf6287ddfcd3e74b0ceb9214c2/chrome/test/data/webui/welcome/.eslintrc.js
[modify] https://crrev.com/fa3218295ace83bf6287ddfcd3e74b0ceb9214c2/chrome/test/data/webui/welcome/onboarding_welcome_browsertest.js
[add] https://crrev.com/fa3218295ace83bf6287ddfcd3e74b0ceb9214c2/chrome/test/data/webui/welcome/test_nux_set_as_default_proxy.js
[add] https://crrev.com/fa3218295ace83bf6287ddfcd3e74b0ceb9214c2/chrome/test/data/webui/welcome/test_welcome_browser_proxy.js
[add] https://crrev.com/fa3218295ace83bf6287ddfcd3e74b0ceb9214c2/chrome/test/data/webui/welcome/welcome_app_test.js
[modify] https://crrev.com/fa3218295ace83bf6287ddfcd3e74b0ceb9214c2/testing/buildbot/filters/webui_polymer2_browser_tests.filter
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc230cd52df9770a83c6ffedc652099602f2fb03

commit fc230cd52df9770a83c6ffedc652099602f2fb03
Author: Scott Chen <scottchen@chromium.org>
Date: Thu Nov 15 22:03:46 2018

Nux Onboarding: add set-as-default status checking test.

Tests possible scenarios of the default status response.

Bug:  881937 
Change-Id: Ic19152b53a81571794fd82f0ce2bd6bed978cf0f
Reviewed-on: https://chromium-review.googlesource.com/c/1327525
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608535}
[modify] https://crrev.com/fc230cd52df9770a83c6ffedc652099602f2fb03/chrome/test/data/webui/welcome/onboarding_welcome_browsertest.js
[modify] https://crrev.com/fc230cd52df9770a83c6ffedc652099602f2fb03/chrome/test/data/webui/welcome/test_bookmark_proxy.js
[modify] https://crrev.com/fc230cd52df9770a83c6ffedc652099602f2fb03/chrome/test/data/webui/welcome/welcome_app_test.js

Comment 11 by scottchen@google.com, Nov 19

Labels: -Pri-1 Pri-2

Comment 12 by cyflee@google.com, Nov 19

Blocking: 874193
Once completed, please fill in testing form and flip "review requested" on launch bit - https://bugs.chromium.org/p/chromium/issues/approval?id=874193

Comment 13 by cyflee@chromium.org, Jan 2

Status: Fixed (was: Started)
test completed
►

Sign in to add a comment