New issue
Advanced search Search tips

Issue 881936 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 12
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

[MacViews] Long Bookmarks titles are stretching the Bookmarks Submenu of the Settings Menu

Reported by sugarcoo...@gmail.com, Sep 7

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3497.81 Safari/537.36

Steps to reproduce the problem:
1. Just open bookmarks
2. 
3. 

What is the expected behavior?
Bookmarks used to be a thin strip when open.

What went wrong?
Takes up half a page

Did this work before? Yes the one before.Version 69.0.3497.81 (Official Build) (64-bit)

Chrome version: 69.0.3497.81  Channel: stable
OS Version: OS X 10.10.5
Flash Version: Not enabled because of chrome

How to minimize.. Make thin again
 
Can you please attach a screenshot of the bug?
Bookmarks-- double the width it use to be.png
27.2 KB View Download
Cc: ellyjo...@chromium.org
Components: UI>Browser
Labels: Proj-MacViews
Status: Untriaged (was: Unconfirmed)
Summary: [MacViews] Long Bookmarks titles are stretching the Bookmarks Submenu of the Settings Menu (was: When bookmarks are open takes up half a page)
Thanks for your feedback. Yes, I can reproduce it easily.

ellyjones@: Here are the steps for you to reproduce.

1.) save a bookmark with a very long name on the Bookmarks Bar
2.) click on the 3-Dot-Settings icon on the Toolbar, so that its menu opens
3.) hover over the bookmarks item in that menu, so that the bookmarks submenu opens

Result: Please see my attached screenshot :(

(Not sure, if this is a Mac-only bug.)
Bildschirmfoto 2018-09-08 um 07.29.36.png
131 KB View Download
Labels: OS-Chrome OS-Linux OS-Windows
Owner: tapted@chromium.org
Status: Started (was: Untriaged)
Affects all platforms. Fix is probably https://chromium-review.googlesource.com/1215503

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/12b5c9b286dfca5991508e968db71c832ca05b3c

commit 12b5c9b286dfca5991508e968db71c832ca05b3c
Author: Trent Apted <tapted@chromium.org>
Date: Tue Sep 11 03:41:26 2018

Use the same max-width for Bookmarks folders and the Bookmarks submenu.

The Chrome app menu and its submenus have a max-width of 800px. Bookmarks
_subfolders_ have a max-width of 400px. But this doesn't apply to the
bookmarks menu itself.

Currently if a bookmark has a long title and appears in the bookmarks
bar top-level, it will push out the width of the `Bookmarks` submenu
when accessed via the Chrome app menu to a width that feels inconsistent.

Bug:  881936 
Change-Id: I1535b2b27f183e4106e21799ba91a5ab40287489
Reviewed-on: https://chromium-review.googlesource.com/1215503
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590191}
[modify] https://crrev.com/12b5c9b286dfca5991508e968db71c832ca05b3c/chrome/browser/ui/views/toolbar/app_menu.cc

When is there going to be a fix? This is extremely annoying. " other bookmarks" was not changed. Bookmarks should appear the same width
Status: Fixed (was: Started)
The fix will be in Chrome 71. Switching to Dev channel ( https://www.chromium.org/getting-involved/dev-channel ) will allow you to get the fix before ~December. Note the ">" button on the bookmarks toolbar and the `Bookmarks` menu in the macOS menu bar already use the narrower width.
Labels: TE-Verified-M71 TE-Verified-71.0.3550.0
Able to reproduce the issue on the build without fix #69.0.3497.81 using Mac OS 10.13.6 as per comment #3.

Verified the fix on Mac 10.13.6, Windows 10 and Ubuntu 17.10 as per comment#3 on chrome version #71.0.3550.0.
Attaching screencast for reference.
Observed the same max-width for Bookmarks folders and the Bookmarks submenu.
Adding the verified labels.

Thanks...!!
881936.mp4
740 KB View Download
MONTHS THIS HAS BEEN ANNOYING!! THIS NEEDS TO BE FIXED ONCE AND FOR ALL NOW!
#9:

This bug is already fixed in Chrome 71. It isn't severe enough to merit merging the fix back to 70 and earlier. 71 will go to Stable soon and then you will see this bug disappear.

Sign in to add a comment