Issue metadata
Sign in to add a comment
|
Add confirmation dialog for keyboard shortcut to rotate screen |
||||||||||||||||||||||
Issue descriptionOS: Chrome When a user presses Ctrl Shift Reload to rotate the screen, we should show a confirmation dialog making sure that they want to continue with that shortcut to rotate the screen. Otherwise, this could be a confusing experience if the user didn't know what they pressed and then didn't know how to revert.
,
Oct 18
,
Oct 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3338706b75a83107cf257c4f191d8dadd10ba924 commit 3338706b75a83107cf257c4f191d8dadd10ba924 Author: Sara Kato <sarakato@chromium.org> Date: Thu Oct 25 23:53:58 2018 Add dialog for screen rotation shortcut. Screen rotation may be triggered using Ctrl + Shift + Reload (F5). The screen will be rotated if the user presses "Continue". UI Strings for ash_strings are still in review. TEST: Manual Bug: 881929 Change-Id: Ie6c067f164b0a0d6f4d68f0d29360d7166937e70 Reviewed-on: https://chromium-review.googlesource.com/c/1272556 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by: Satoru Takabayashi <satorux@chromium.org> Reviewed-by: David Tseng <dtseng@chromium.org> Reviewed-by: Yuki Awano <yawano@chromium.org> Commit-Queue: Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#602934} [modify] https://crrev.com/3338706b75a83107cf257c4f191d8dadd10ba924/ash/accelerators/accelerator_controller.cc [modify] https://crrev.com/3338706b75a83107cf257c4f191d8dadd10ba924/ash/accelerators/accelerator_controller_unittest.cc [modify] https://crrev.com/3338706b75a83107cf257c4f191d8dadd10ba924/ash/accessibility/accessibility_controller.cc [modify] https://crrev.com/3338706b75a83107cf257c4f191d8dadd10ba924/ash/accessibility/accessibility_controller.h [modify] https://crrev.com/3338706b75a83107cf257c4f191d8dadd10ba924/ash/ash_strings.grd [modify] https://crrev.com/3338706b75a83107cf257c4f191d8dadd10ba924/ash/public/cpp/ash_pref_names.cc [modify] https://crrev.com/3338706b75a83107cf257c4f191d8dadd10ba924/ash/public/cpp/ash_pref_names.h [modify] https://crrev.com/3338706b75a83107cf257c4f191d8dadd10ba924/chrome/browser/chromeos/preferences.cc
,
Nov 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ab860a2d0ca3bd054acdda8f439cbff63bb96311 commit ab860a2d0ca3bd054acdda8f439cbff63bb96311 Author: Sara Kato <sarakato@chromium.org> Date: Mon Nov 05 07:54:37 2018 Add 'keyboard' to string for confirmation dialogs. String for dialogs was confirmed by jonann@, add word 'keyboard' to confirmation dialogs already implemented. Bug: 881929 Change-Id: Ibd3d13e95ff5b56eeabbf24ac1e6ba90fcf456a9 Reviewed-on: https://chromium-review.googlesource.com/c/1316951 Commit-Queue: Sara Kato <sarakato@chromium.org> Reviewed-by: Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#605277} [modify] https://crrev.com/ab860a2d0ca3bd054acdda8f439cbff63bb96311/ash/ash_strings.grd |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 Deleted