New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 881924 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 20
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 870130


Show other hotlists

Hotlists containing this issue:
Better-Together-Launch-Blockers


Sign in to add a comment

Update lockScreen settings section for SmartLock to remove Setup button

Project Member Reported by jhawkins@chromium.org, Sep 7

Issue description

In the multidevice world, this must be a toggle button that controls the local pref of whether SmartLock is enabled or not.
 
I don't think this is the right path to take as it will be much more difficult than just adding the Smart Lock settings page. I'd recommend closing out this issue and simply fixing  issue 870130 .
Status: WontFix (was: Started)
We have time to get the real fix in for M71.
Labels: -M-70 M-71
Status: Started (was: WontFix)
Opening this up to track the interim change of removing the Setup button, since it's getting in the user's way.
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/174387d0cf9393ab22d9c7ae1438c390040f2522

commit 174387d0cf9393ab22d9c7ae1438c390040f2522
Author: James Hawkins <jhawkins@chromium.org>
Date: Thu Sep 20 19:52:32 2018

Smart Lock: Remove the setup/disable button in lockScreen settings.

When multidevice flags are turned on. This is a stop-gap measure to
prevent users from running through the deprecated Smart Lock setup flow
when in the new multidevice world.

R=khorimoto@chromium.org

Bug:  881924 
Test: none
Change-Id: Ifec2bd324e55592f14a50fe6cb5331496f010eff
Reviewed-on: https://chromium-review.googlesource.com/1236840
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592914}
[modify] https://crrev.com/174387d0cf9393ab22d9c7ae1438c390040f2522/chrome/browser/resources/settings/people_page/lock_screen.html
[modify] https://crrev.com/174387d0cf9393ab22d9c7ae1438c390040f2522/chrome/browser/resources/settings/people_page/lock_screen.js

Status: Fixed (was: Started)

Sign in to add a comment