New issue
Advanced search Search tips

Issue 881923 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 9
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug


Participants' hotlists:
Harmony-Cast-Dialog


Sign in to add a comment

[Harmony Cast Dialog] Sink list height should be 6.5 items

Project Member Reported by taku...@chromium.org, Sep 7

Issue description

Per the mocks, the sink list height should be capped at 6.5 items.
 
Labels: -Target-71 Target-72 M-72
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d29f62bf65145e292758f6c439fd07b8b6c8c52

commit 8d29f62bf65145e292758f6c439fd07b8b6c8c52
Author: Takumi Fujimoto <takumif@chromium.org>
Date: Fri Nov 09 00:46:04 2018

[Harmony Cast Dialog] Change the sink list height limit to 6.5 items

Also use the correct button height const to reflect a recent change.

Bug:  881923 
Change-Id: I2553c3d8d891a25b981edce8f0578e516d7ebe43
Reviewed-on: https://chromium-review.googlesource.com/c/1327557
Reviewed-by: Brandon Tolsch <btolsch@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606678}
[modify] https://crrev.com/8d29f62bf65145e292758f6c439fd07b8b6c8c52/chrome/browser/ui/views/media_router/cast_dialog_view.cc

Status: Fixed (was: Started)

Sign in to add a comment