New issue
Advanced search Search tips

Issue 881910 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 12
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocked on:
issue 883641



Sign in to add a comment

Move devil's gn files from //build/secondary to devil itself

Project Member Reported by jbudorick@chromium.org, Sep 7

Issue description

^
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 7

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/f661ae83d884bc5fa5e0e1ed049052377ddcdc75

commit f661ae83d884bc5fa5e0e1ed049052377ddcdc75
Author: John Budorick <jbudorick@chromium.org>
Date: Fri Sep 07 17:54:05 2018

devil: move gn files over from chromium.

A follow-up CL will be necessary to complete the move once chromium
starts using these directly.

Change-Id: I1f81f99955d16883765acc2fa96514047f8b9ef8
Bug:  chromium:881910 
Reviewed-on: https://chromium-review.googlesource.com/1213882
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>

[add] https://crrev.com/f661ae83d884bc5fa5e0e1ed049052377ddcdc75/devil/BUILD.gn
[add] https://crrev.com/f661ae83d884bc5fa5e0e1ed049052377ddcdc75/devil/devil_arm.gni

Project Member

Comment 2 by bugdroid1@chromium.org, Sep 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd19a2123e6a476fb81010166b9661bfb8c74bbc

commit dd19a2123e6a476fb81010166b9661bfb8c74bbc
Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Fri Sep 07 21:07:52 2018

Roll src/third_party/catapult 32654a45d3da..febcf8764dc1 (6 commits)

https://chromium.googlesource.com/catapult.git/+log/32654a45d3da..febcf8764dc1


git log 32654a45d3da..febcf8764dc1 --date=short --no-merges --format='%ad %ae %s'
2018-09-07 nednguyen@google.com Ignore files/directory that are not tracked by git when generating BUILD.gn for Telemetry
2018-09-07 jbudorick@chromium.org devil: move gn files over from chromium.
2018-09-07 nastasoiuf@google.com Additional features for stacked plot
2018-09-07 simonhatch@chromium.org Dashboard - Remove TestMetadata._pre_put_hook
2018-09-07 simonhatch@chromium.org Dashboard - Remove stray print
2018-09-07 simonhatch@chromium.org Dashboard - Refactor find_anomalies to support stats later


Created with:
  gclient setdep -r src/third_party/catapult@febcf8764dc1

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:879554 , chromium:881910 ,chromium:866423,chromium:881523
TBR=sullivan@chromium.org

Change-Id: I1f41015a567033be0e588947b705ae02435521be
Reviewed-on: https://chromium-review.googlesource.com/1213776
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#589641}
[modify] https://crrev.com/dd19a2123e6a476fb81010166b9661bfb8c74bbc/DEPS

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8b06e9482c5140aa814d455577f1d4f826c4850

commit d8b06e9482c5140aa814d455577f1d4f826c4850
Author: John Budorick <jbudorick@chromium.org>
Date: Sat Sep 08 01:44:19 2018

Deprecate chromium versions of devil gn files.

Requires crrev.com/c/1213882

Bug:  881910 
Change-Id: I725b3c1776ab5f58f6c99624d5b90798b2f14da1
Reviewed-on: https://chromium-review.googlesource.com/1213723
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589750}
[modify] https://crrev.com/d8b06e9482c5140aa814d455577f1d4f826c4850/build/config/arm.gni
[delete] https://crrev.com/db6e880b79eed205babfcb2f5d0d5147f441afb4/build/secondary/third_party/catapult/devil/BUILD.gn
[modify] https://crrev.com/d8b06e9482c5140aa814d455577f1d4f826c4850/build/secondary/third_party/catapult/devil/devil_arm.gni

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 10

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/2ef3b9b4b7aebd6491780179b2e191509d1bf0f2

commit 2ef3b9b4b7aebd6491780179b2e191509d1bf0f2
Author: John Budorick <jbudorick@chromium.org>
Date: Mon Sep 10 17:28:18 2018

devil: remove references to chromium-side .gni.

Bug:  chromium:881910 
Change-Id: I1dd90c1c0893483aebae4ad6102e88a9ffc4e9d3
Reviewed-on: https://chromium-review.googlesource.com/1214842
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>

[modify] https://crrev.com/2ef3b9b4b7aebd6491780179b2e191509d1bf0f2/devil/BUILD.gn

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/733447a48315ad0191720f2f382204024964f6ee

commit 733447a48315ad0191720f2f382204024964f6ee
Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Mon Sep 10 19:58:18 2018

Roll src/third_party/catapult 0c8cc6141c62..77a15654a753 (2 commits)

https://chromium.googlesource.com/catapult.git/+log/0c8cc6141c62..77a15654a753


git log 0c8cc6141c62..77a15654a753 --date=short --no-merges --format='%ad %ae %s'
2018-09-10 simonhatch@chromium.org Dashboard - Make privileged and unprivileged access explicit
2018-09-10 jbudorick@chromium.org devil: remove references to chromium-side .gni.


Created with:
  gclient setdep -r src/third_party/catapult@77a15654a753

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:882504 , chromium:881910 
TBR=sullivan@chromium.org

Change-Id: I8dc56fda01b40bf75918241eb39845a1c2a28d3b
Reviewed-on: https://chromium-review.googlesource.com/1216866
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#590030}
[modify] https://crrev.com/733447a48315ad0191720f2f382204024964f6ee/DEPS

Project Member

Comment 6 by bugdroid1@chromium.org, Sep 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/40c7a8ae30883d9ee59974f387b76eb8fe1eeb48

commit 40c7a8ae30883d9ee59974f387b76eb8fe1eeb48
Author: John Budorick <jbudorick@chromium.org>
Date: Wed Sep 12 16:12:19 2018

Remove vestigial copy of devil_arm.gni.

Bug:  881910 
Change-Id: I46c23decb7700c744f6ecb06e93145fdf0659a98
Reviewed-on: https://chromium-review.googlesource.com/1221727
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590711}
[delete] https://crrev.com/bc87db8a3cd19aec3d4796d4fcc3b92e09e4a3fd/build/secondary/third_party/catapult/devil/devil_arm.gni

Status: Fixed (was: Started)
Thanks!
Blockedon: 883641

Sign in to add a comment