This test fails with PaintTouchActionRects: fullscreen/compositor-touch-hit-rects-fullscreen-video-controls.html I think we may just need to add a new expectation to virtual/painttouchactionrects/fullscreen/...
See discussion in https://chromium-review.googlesource.com/c/chromium/src/+/1237150: we now understand this difference and it is not a real failure.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/45013dfcc8f928d8e95c94378393fa06272df868 commit 45013dfcc8f928d8e95c94378393fa06272df868 Author: Xida Chen <xidachen@chromium.org> Date: Fri Sep 21 18:05:42 2018 Promote PaintTouchActionRects to stable This change enables PaintTouchActionRects by default. This is a new implementation of how the blink->cc logic works for the css touch-action feature. The big idea behind PaintTouchActionRects is to compute touch-action rects during paint, in paint order, as part of the background paint phase. With this change we expect better performance (primarily a drop in ScrollingCoordinator time: Blink.ScrollingCoordinator.UpdateTime) as well as observable bug fixes (e.g., https://crbug.com/826746 ). Bug: 836905, 881894 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I47a26250bad4c9e208b4f9b11e8eea3cf4d182aa Reviewed-on: https://chromium-review.googlesource.com/1233114 Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#593255} [modify] https://crrev.com/45013dfcc8f928d8e95c94378393fa06272df868/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 [modify] https://crrev.com/45013dfcc8f928d8e95c94378393fa06272df868/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/45013dfcc8f928d8e95c94378393fa06272df868/third_party/WebKit/LayoutTests/fast/events/touch/compositor-touch-hit-rects-global-expected.txt [modify] https://crrev.com/45013dfcc8f928d8e95c94378393fa06272df868/third_party/WebKit/LayoutTests/fast/events/touch/compositor-touch-hit-rects-many-expected.txt [modify] https://crrev.com/45013dfcc8f928d8e95c94378393fa06272df868/third_party/WebKit/LayoutTests/fast/events/touch/compositor-touch-hit-rects-non-composited-scroll-expected.txt [modify] https://crrev.com/45013dfcc8f928d8e95c94378393fa06272df868/third_party/WebKit/LayoutTests/fast/events/touch/compositor-touch-hit-rects-non-composited-scroll-overflow-with-handler-expected.txt [modify] https://crrev.com/45013dfcc8f928d8e95c94378393fa06272df868/third_party/WebKit/LayoutTests/fast/events/touch/compositor-touch-hit-rects-scroll-expected.txt [modify] https://crrev.com/45013dfcc8f928d8e95c94378393fa06272df868/third_party/WebKit/LayoutTests/fast/events/touch/compositor-touch-hit-rects-svg-container-expected.txt [modify] https://crrev.com/45013dfcc8f928d8e95c94378393fa06272df868/third_party/WebKit/LayoutTests/fast/events/touch/compositor-touch-hit-rects-svg-expected.txt [modify] https://crrev.com/45013dfcc8f928d8e95c94378393fa06272df868/third_party/WebKit/LayoutTests/fast/events/touch/compositor-touch-hit-rects-svg-image-expected.txt [modify] https://crrev.com/45013dfcc8f928d8e95c94378393fa06272df868/third_party/WebKit/LayoutTests/fast/events/touch/compositor-touch-hit-rects-svg-root-expected.txt [modify] https://crrev.com/45013dfcc8f928d8e95c94378393fa06272df868/third_party/WebKit/LayoutTests/fast/events/touch/compositor-touch-hit-rects-svg-text-expected.txt [modify] https://crrev.com/45013dfcc8f928d8e95c94378393fa06272df868/third_party/WebKit/LayoutTests/fullscreen/compositor-touch-hit-rects-fullscreen-video-controls-expected.txt [add] https://crrev.com/45013dfcc8f928d8e95c94378393fa06272df868/third_party/WebKit/LayoutTests/platform/linux/fast/events/touch/compositor-touch-hit-rects-svg-container-expected.txt [add] https://crrev.com/45013dfcc8f928d8e95c94378393fa06272df868/third_party/WebKit/LayoutTests/platform/linux/fast/events/touch/compositor-touch-hit-rects-svg-text-expected.txt [modify] https://crrev.com/45013dfcc8f928d8e95c94378393fa06272df868/third_party/WebKit/LayoutTests/platform/linux/virtual/android/fullscreen/compositor-touch-hit-rects-fullscreen-video-controls-expected.txt [modify] https://crrev.com/45013dfcc8f928d8e95c94378393fa06272df868/third_party/blink/renderer/platform/runtime_enabled_features.json5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c5a7fbb92f549ec56e22541634b613b3177ce2ed commit c5a7fbb92f549ec56e22541634b613b3177ce2ed Author: Philip Rogers <pdr@chromium.org> Date: Mon Sep 24 15:15:31 2018 Revert "Promote PaintTouchActionRects to stable" This reverts commit 45013dfcc8f928d8e95c94378393fa06272df868. Reason for revert: Performance regressions on touch_handler_scrolling.html This patch turned up a few performance regressions, primarily: tough_scheduling_cases/touch_handler_scrolling.html (see: https://crbug.com/888269 ). Other performance regressions: https://chromeperf.appspot.com/group_report?rev=593255 Original change's description: > Promote PaintTouchActionRects to stable > > This change enables PaintTouchActionRects by default. This is a > new implementation of how the blink->cc logic works for the css > touch-action feature. The big idea behind PaintTouchActionRects is to > compute touch-action rects during paint, in paint order, as part of the > background paint phase. > > With this change we expect better performance (primarily a drop in > ScrollingCoordinator time: Blink.ScrollingCoordinator.UpdateTime) as > well as observable bug fixes (e.g., https://crbug.com/826746 ). > > Bug: 836905, 881894 > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I47a26250bad4c9e208b4f9b11e8eea3cf4d182aa > Reviewed-on: https://chromium-review.googlesource.com/1233114 > Reviewed-by: Philip Rogers <pdr@chromium.org> > Commit-Queue: Xida Chen <xidachen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#593255} TBR=pdr@chromium.org,xidachen@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 836905, 881894 Change-Id: I775e60074f4d5bca5a907a1da104f5441212769a Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1240184 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Reviewed-by: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#593540} [modify] https://crrev.com/c5a7fbb92f549ec56e22541634b613b3177ce2ed/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 [modify] https://crrev.com/c5a7fbb92f549ec56e22541634b613b3177ce2ed/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/c5a7fbb92f549ec56e22541634b613b3177ce2ed/third_party/WebKit/LayoutTests/fast/events/touch/compositor-touch-hit-rects-global-expected.txt [modify] https://crrev.com/c5a7fbb92f549ec56e22541634b613b3177ce2ed/third_party/WebKit/LayoutTests/fast/events/touch/compositor-touch-hit-rects-many-expected.txt [modify] https://crrev.com/c5a7fbb92f549ec56e22541634b613b3177ce2ed/third_party/WebKit/LayoutTests/fast/events/touch/compositor-touch-hit-rects-non-composited-scroll-expected.txt [modify] https://crrev.com/c5a7fbb92f549ec56e22541634b613b3177ce2ed/third_party/WebKit/LayoutTests/fast/events/touch/compositor-touch-hit-rects-non-composited-scroll-overflow-with-handler-expected.txt [modify] https://crrev.com/c5a7fbb92f549ec56e22541634b613b3177ce2ed/third_party/WebKit/LayoutTests/fast/events/touch/compositor-touch-hit-rects-scroll-expected.txt [modify] https://crrev.com/c5a7fbb92f549ec56e22541634b613b3177ce2ed/third_party/WebKit/LayoutTests/fast/events/touch/compositor-touch-hit-rects-svg-container-expected.txt [modify] https://crrev.com/c5a7fbb92f549ec56e22541634b613b3177ce2ed/third_party/WebKit/LayoutTests/fast/events/touch/compositor-touch-hit-rects-svg-expected.txt [modify] https://crrev.com/c5a7fbb92f549ec56e22541634b613b3177ce2ed/third_party/WebKit/LayoutTests/fast/events/touch/compositor-touch-hit-rects-svg-image-expected.txt [modify] https://crrev.com/c5a7fbb92f549ec56e22541634b613b3177ce2ed/third_party/WebKit/LayoutTests/fast/events/touch/compositor-touch-hit-rects-svg-root-expected.txt [modify] https://crrev.com/c5a7fbb92f549ec56e22541634b613b3177ce2ed/third_party/WebKit/LayoutTests/fast/events/touch/compositor-touch-hit-rects-svg-text-expected.txt [modify] https://crrev.com/c5a7fbb92f549ec56e22541634b613b3177ce2ed/third_party/WebKit/LayoutTests/fullscreen/compositor-touch-hit-rects-fullscreen-video-controls-expected.txt [delete] https://crrev.com/8f3cb30f77b4f4156a11e6ca3ab2ab3e7562edc2/third_party/WebKit/LayoutTests/platform/linux/fast/events/touch/compositor-touch-hit-rects-svg-container-expected.txt [delete] https://crrev.com/8f3cb30f77b4f4156a11e6ca3ab2ab3e7562edc2/third_party/WebKit/LayoutTests/platform/linux/fast/events/touch/compositor-touch-hit-rects-svg-text-expected.txt [modify] https://crrev.com/c5a7fbb92f549ec56e22541634b613b3177ce2ed/third_party/WebKit/LayoutTests/platform/linux/virtual/android/fullscreen/compositor-touch-hit-rects-fullscreen-video-controls-expected.txt [modify] https://crrev.com/c5a7fbb92f549ec56e22541634b613b3177ce2ed/third_party/blink/renderer/platform/runtime_enabled_features.json5
Comment 1 by xidac...@chromium.org
, Sep 7Owner: xidac...@chromium.org