New issue
Advanced search Search tips

Issue 881893 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 7
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Promote KeyEvent properties to Event

Project Member Reported by sky@chromium.org, Sep 7

Issue description

This way we can add arbitrary key/value pairs to any event. This will be used as a way to add viz specific information to events so that content can route correctly with oopifs for mus.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aacceb94cb150433b0e71e821a25c2ce0655a38d

commit aacceb94cb150433b0e71e821a25c2ce0655a38d
Author: Scott Violet <sky@chromium.org>
Date: Fri Sep 07 21:17:10 2018

events: move properties from KeyEvent to Event

This also fixs a bug when using operator= with an event. Specifically we
were not correctly calling ReleaseCopiedNativeEvent() as well as
CopyNativeEvent(). I suspect not many places use operator=, so it wasn't
really an issue. I was tempted to make Event's operator= private, but KeyEvent
explicitly has operator=, which implies we need to support at Event as well.

BUG= 881893 
TEST=covered by tests

Change-Id: I16480937b04d881849ca7ac222f2df48d20e763d
Reviewed-on: https://chromium-review.googlesource.com/1213584
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589657}
[modify] https://crrev.com/aacceb94cb150433b0e71e821a25c2ce0655a38d/ui/events/event.cc
[modify] https://crrev.com/aacceb94cb150433b0e71e821a25c2ce0655a38d/ui/events/event.h
[modify] https://crrev.com/aacceb94cb150433b0e71e821a25c2ce0655a38d/ui/events/event_unittest.cc
[modify] https://crrev.com/aacceb94cb150433b0e71e821a25c2ce0655a38d/ui/events/mojo/event.mojom
[modify] https://crrev.com/aacceb94cb150433b0e71e821a25c2ce0655a38d/ui/events/mojo/event_struct_traits.cc
[modify] https://crrev.com/aacceb94cb150433b0e71e821a25c2ce0655a38d/ui/events/mojo/event_struct_traits.h

Status: Fixed (was: Started)

Sign in to add a comment