New issue
Advanced search Search tips

Issue 881884 link

Starred by 1 user
Status: Fixed
Owner:
alph@chromium.org
Closed: Sep 9
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Native heap snapshots do not open in DevTools.

Project Member Reported by alph@chromium.org, Sep 7 
Open DevTools.
Take native Renderer heap snapshot.
Snapshot is empty, and there's an error in console.

Uncaught (in promise) TypeError: Cannot convert a BigInt value to a number
    at Array.sort (<anonymous>)
    at Profiler.HeapProfileView.populateTextView (profiler_module.js:formatted:2182)
    at Profiler.HeapProfileView._ensureTextViewCreated (profiler_module.js:formatted:847)
    at Profiler.HeapProfileView._changeView (profiler_module.js:formatted:898)
    at Profiler.HeapProfileView.initialize (profiler_module.js:formatted:765)
    at new Profiler.HeapProfileView (profiler_module.js:formatted:2160)
    at Profiler.SamplingHeapProfileHeader.createView (profiler_module.js:formatted:2405)
    at Profiler.HeapProfilerPanel.viewForProfile (profiler_module.js:formatted:422)
    at Profiler.HeapProfilerPanel.showProfile (profiler_module.js:formatted:397)
    at Profiler.HeapProfilerPanel.profileComplete (profiler_module.js:formatted:353)
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d5a0e8a4b89e61d9086b61a07d9bc1712fdf930

commit 6d5a0e8a4b89e61d9086b61a07d9bc1712fdf930
Author: Alexei Filippov <alph@chromium.org>
Date: Sat Sep 08 00:17:31 2018

DevTools: Fix Native heap snapshots do not open in DevTools.

Array.p.sort does not expect comparator result of BigInt.

BUG= 881884 

Change-Id: I3215e4dab8dcfc1e4e830cebf07d1dcf674d0d2e
Reviewed-on: https://chromium-review.googlesource.com/1213928
Reviewed-by: Erik Luo <luoe@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589731}
[modify] https://crrev.com/6d5a0e8a4b89e61d9086b61a07d9bc1712fdf930/third_party/blink/renderer/devtools/front_end/profiler/HeapProfileView.js

Comment 2 by alph@chromium.org, Sep 8

Labels: Merge-Request-70
Project Member

Comment 3 by sheriffbot@chromium.org, Sep 9

Labels: -Merge-Request-70 Hotlist-Merge-Approved Merge-Approved-70
Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 9

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/38a6c0b775a8c707b87c26dd53711729f6c2980a

commit 38a6c0b775a8c707b87c26dd53711729f6c2980a
Author: Alexei Filippov <alph@chromium.org>
Date: Sun Sep 09 01:29:00 2018

DevTools: Fix Native heap snapshots do not open in DevTools.

Array.p.sort does not expect comparator result of BigInt.

BUG= 881884 
TBR=alph@chromium.org

(cherry picked from commit 6d5a0e8a4b89e61d9086b61a07d9bc1712fdf930)

Change-Id: I3215e4dab8dcfc1e4e830cebf07d1dcf674d0d2e
Reviewed-on: https://chromium-review.googlesource.com/1213928
Reviewed-by: Erik Luo <luoe@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#589731}
Reviewed-on: https://chromium-review.googlesource.com/1215243
Reviewed-by: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#191}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/38a6c0b775a8c707b87c26dd53711729f6c2980a/third_party/blink/renderer/devtools/front_end/profiler/HeapProfileView.js

Comment 5 by alph@chromium.org, Sep 9

Status: Fixed (was: Assigned)
►

Sign in to add a comment