Why is this a blocker of deprecating TBMv1 bug? TBMv1 wont' be able to compute the  SF metrics in newer android devices either, I think

I marked it as a blocker for now, because I'm not sure if we want to fix this or delete SF metrics? The issue has been existed for a long time. The answer to this question, not fixing the bug, is blocking crbug.com/760553: If people don't care about SF metrics, there is no point in rewriting them in TBMv2; otherwise we should add TBMv2 versions and fix this bug.

#4: that makes sense to me, thanks! 


*For historical context, I recall people say surface flinger metrics are a lot more realistic & stable than other smoothness metrics. 

If this is a p1, then it needs an owner.

#5: We really need to keep SurfaceFlinger stats, until the new FrameMetrics can be used and produce good data.  The smoothness stats without SF are close to useless.

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/5f6da8a57db16291c01a894083137c294b3b4e5f

commit 5f6da8a57db16291c01a894083137c294b3b4e5f
Author: Ehsan Chiniforooshan <chiniforooshan@chromium.org>
Date: Thu Sep 13 15:54:10 2018

Telemetry: fix a SF stats collector bug

The following command does not work on Android O and later:

adb shell dumpsys SurfaceFlinger --latency SurfaceView

The new format requires activity name, too, e.g.

adb shell dumpsys SurfaceFlinger --latency
  \"SurfaceView -  - com.android.chrome/com.google.android.apps.chrome.Main#0\"

pinpoint job: https://pinpoint-dot-chromeperf.appspot.com/job/16fb3e6b640000

Bug:  chromium:881873 
Change-Id: Ida686372047bbb7869c6ea45cf01a1c0c5431234
Reviewed-on: https://chromium-review.googlesource.com/1216504
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org>

[modify] https://crrev.com/5f6da8a57db16291c01a894083137c294b3b4e5f/devil/devil/android/perf/surface_stats_collector.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b2b2dca23cca0862f674758c9a3933e685c27d5

commit 7b2b2dca23cca0862f674758c9a3933e685c27d5
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Thu Sep 13 18:48:20 2018

Roll src/third_party/catapult 994bb1389b1d..5f6da8a57db1 (3 commits)

https://chromium.googlesource.com/catapult.git/+log/994bb1389b1d..5f6da8a57db1


git log 994bb1389b1d..5f6da8a57db1 --date=short --no-merges --format='%ad %ae %s'
2018-09-13 chiniforooshan@chromium.org Telemetry: fix a SF stats collector bug
2018-09-13 cbruni@chromium.org Include hash for wprgo archive names to reduce name collisions
2018-09-13 pasko@chromium.org clear_system_cache: update binaries


Created with:
  gclient setdep -r src/third_party/catapult@5f6da8a57db1

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:881873 ,chromium:878390, chromium:881384 
TBR=sullivan@chromium.org

Change-Id: Ic86872f9c2fef3f27bfc693e9927e56235561f4b
Reviewed-on: https://chromium-review.googlesource.com/1224596
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#591088}
[modify] https://crrev.com/7b2b2dca23cca0862f674758c9a3933e685c27d5/DEPS

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8323f92cb0c81332c00abfe5a3bad012a400fd35

commit 8323f92cb0c81332c00abfe5a3bad012a400fd35
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Fri Sep 14 16:52:21 2018

Roll src/third_party/catapult 3e071665b9f9..9f36d9f78813 (14 commits)

https://chromium.googlesource.com/catapult.git/+log/3e071665b9f9..9f36d9f78813


git log 3e071665b9f9..9f36d9f78813 --date=short --no-merges --format='%ad %ae %s'
2018-09-14 pasko@chromium.org FlushOsPageCaches: wait for dust to settle
2018-09-14 ulan@chromium.org Revert "Output DevTools error messages as warnings while running a story."
2018-09-13 simonhatch@chromium.org Dashboard - Error out on empty or uncompressed uploads
2018-09-13 sadrul@chromium.org rendering: Ignore trace-events for canceled draws.
2018-09-13 vovoy@chromium.org Only download files for filtered stories in story_runner
2018-09-13 chiniforooshan@chromium.org Telemetry: fix a SF stats collector bug
2018-09-13 cbruni@chromium.org Include hash for wprgo archive names to reduce name collisions
2018-09-13 pasko@chromium.org clear_system_cache: update binaries
2018-09-13 anthonyalridge@google.com Create a link to traces from the CFG.
2018-09-13 anthonyalridge@google.com Add clip path at to prevent overlap with x axis label.
2018-09-13 wangge@google.com Add functions to include APK, generate isolate and upload it.
2018-09-13 cbruni@chromium.org Add more helpers in preparation for v8.loading.cluster_telemetry benchmark
2018-09-13 anthonyalridge@google.com Add padding to numeric labels for stacked bar plotter.
2018-09-13 ulan@chromium.org Output DevTools error messages as warnings while running a story.


Created with:
  gclient setdep -r src/third_party/catapult@9f36d9f78813

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:811244, chromium:881384 , chromium:883892 ,chromium:880432, chromium:883735 ,chromium:883592, chromium:882291 , chromium:881873 ,chromium:878390, chromium:881384 ,chromium:866423,chromium:866423, chromium:863390 , chromium:883322 ,chromium:866423,chromium:880432
TBR=sullivan@chromium.org

Change-Id: I934e7e9b842518c75edbeb4a1604c2e06b577861
Reviewed-on: https://chromium-review.googlesource.com/1226380
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#591375}
[modify] https://crrev.com/8323f92cb0c81332c00abfe5a3bad012a400fd35/DEPS