New issue
Advanced search Search tips

Issue 881869 link

Starred by 1 user
Status: Verified
Owner:
mahmadi@chromium.org
Closed: Sep 11
Cc:
ftirelo@chromium.org
se...@chromium.org
ma...@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

autofill::prefs::kAutofillCreditCardEnabled must be syncable

Project Member Reported by mahmadi@chromium.org, Sep 7 
This pref must be a syncable pref similar to autofill::prefs::kAutofillProfileEnabled
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a150b9696d3df03c030cc3a068ed3eca79d4cb1e

commit a150b9696d3df03c030cc3a068ed3eca79d4cb1e
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Tue Sep 11 15:20:47 2018

[AF] Make autofill::prefs::kAutofillCreditCardEnabled syncable

Bug:  881869 
Change-Id: Ib20092ce09f53b2b79280f3e79a7ab0785a66068
Reviewed-on: https://chromium-review.googlesource.com/1213868
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590314}
[modify] https://crrev.com/a150b9696d3df03c030cc3a068ed3eca79d4cb1e/components/autofill/core/common/autofill_prefs.cc

Comment 2 by mahmadi@chromium.org, Sep 11

Labels: Merge-Request-70

Comment 3 by mahmadi@chromium.org, Sep 11

Status: Fixed (was: Started)

Comment 4 by abdulsyed@chromium.org, Sep 11 

Let's wait until this is verified in canary first.
Project Member

Comment 5 by sheriffbot@chromium.org, Sep 12

Labels: -Merge-Request-70 Hotlist-Merge-Approved Merge-Approved-70
Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by mahmadi@chromium.org, Sep 13

Status: Verified (was: Fixed)
Verified on Canary 71.0.3551.0
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 13

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e79b5516306f417ee68da04fba3f779fce27e7a1

commit e79b5516306f417ee68da04fba3f779fce27e7a1
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Thu Sep 13 13:41:40 2018

[AF] Make autofill::prefs::kAutofillCreditCardEnabled syncable

Bug:  881869 
Change-Id: Ib20092ce09f53b2b79280f3e79a7ab0785a66068
Reviewed-on: https://chromium-review.googlesource.com/1213868
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#590314}(cherry picked from commit a150b9696d3df03c030cc3a068ed3eca79d4cb1e)
Reviewed-on: https://chromium-review.googlesource.com/1224650
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#367}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/e79b5516306f417ee68da04fba3f779fce27e7a1/components/autofill/core/common/autofill_prefs.cc
►

Sign in to add a comment