New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 881852 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 7
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: ----



Sign in to add a comment

network_service_browser_tests failing on chromium.mac/Mac10.12 Tests

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Sep 7

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of jdonnelly@google.com

network_service_browser_tests failing on chromium.mac/Mac10.12 Tests

Builders failed on: 
- Mac10.12 Tests: 
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests

The failing test is CrSettingsPrivacyPageTest.All ('"Uncaught AssertionError: expected true to be false", source: file:///b/s/w/ir/third_party/chaijs/chai.js (206)')

The failure started at https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/15219. The next run (15220) shows Success but if you look in the logs the same test fails multiple times then manages to pass on the third retry. Every run since then has failed.

I suspect https://chromium-review.googlesource.com/1211430 ('Reland "Add the ability for AndroidSmsAppHelperDelegate to launch the PWA."').

But there are a few other changes in the blame list that mention "settings":
- https://chromium-review.googlesource.com/1203478 ("[Jumbo] Rename collision functions and enable jumbo build")
- https://chromium-review.googlesource.com/1208900 ("[CrOS MultiDevice] Reflect policy prohibition in Settings.")
- https://chromium-review.googlesource.com/1208822 ("Settings WebUI: prevent settings-subpage from removing itself as a FindShortcutListener if it was not already added as one.")
- https://chromium-review.googlesource.com/1208954 ('Revert "[CrOS MultiDevice] Update password requirements for Connected Devices."')
 
Description: Show this description
Cc: msramek@chromium.org codei...@gmail.com tommycli@chromium.org aee@chromium.org jordynass@chromium.org khorimoto@chromium.org hansberry@chromium.org hcarmona@chromium.org dpa...@chromium.org
Owner: jlklein@chromium.org
Because of the high degree of uncertainty here, I'm not reverting any of these changes. jlklein, could you please take a look at the error and report on what you think may be the cause?
Labels: -Pri-2 Pri-1
Status: Started (was: Available)
Cc: jlklein@chromium.org
Owner: jam@chromium.org
This is almost certainly caused by https://chromium-review.googlesource.com/1200308 (Run network service browser tests on Mac 10.12 bots). jam@, can you take a look?
I have a cl in the CQ to disable this https://chromium-review.googlesource.com/c/chromium/src/+/1213506
jlklein: thanks for identifying the issue.
jam: thanks for the fix.
Status: Fixed (was: Started)

Sign in to add a comment