Issue metadata
Sign in to add a comment
|
Launcher icons overlapping with highest screen size |
||||||||||||||||||||||||
Issue descriptionGoogle Chrome 70.0.3538.7 (Official Build) dev (64-bit) Firmware Version Google_Caroline.7820.384.0 Steps to reproduce: # Set the display size to largest either via settings pages or with ctrl + shift + plus sign # Open the launcher Expected: icons do not overlap, titles can be read Actual: overlapping icons and titles, please see screenshot
,
Sep 12
Moving to M-71 to investigate
,
Sep 12
+sgabriel for UX input
,
Sep 13
I think that as soon as we are reaching icon holder overlap, we should scale the icons accordingly. We maintain 0 padding but we scale them to remove overlap. Does that make sense?
,
Sep 13
That sounds good, thanks!
,
Sep 18
,
Sep 18
,
Sep 26
,
Oct 3
,
Oct 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b210f5920e487195555b32dfad47030a7efccc05 commit b210f5920e487195555b32dfad47030a7efccc05 Author: Weidong Guo <weidongg@chromium.org> Date: Thu Oct 04 17:16:25 2018 Fit the apps grid in small size display 1. Scale down apps grid view when it does not fit inside small display via transform. 2. Remove box layout in app list main view to avoid duplicate layouts in each dragging frame. 3. Update Y position of views instead of calling Layout function during dragging to avoid jitter issue due to rounding error. 4. Avoid resizing apps grid view in dragging and animation, which is an expensive operation. Bug: 881851 Change-Id: I78e2605727e8c7f0d93177bcf8877d796b746b86 Reviewed-on: https://chromium-review.googlesource.com/c/1259463 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#596724} [modify] https://crrev.com/b210f5920e487195555b32dfad47030a7efccc05/ash/app_list/presenter/app_list_presenter_impl.cc [modify] https://crrev.com/b210f5920e487195555b32dfad47030a7efccc05/ash/app_list/views/app_list_main_view.cc [modify] https://crrev.com/b210f5920e487195555b32dfad47030a7efccc05/ash/app_list/views/app_list_main_view.h [modify] https://crrev.com/b210f5920e487195555b32dfad47030a7efccc05/ash/app_list/views/app_list_view.cc [modify] https://crrev.com/b210f5920e487195555b32dfad47030a7efccc05/ash/app_list/views/app_list_view.h [modify] https://crrev.com/b210f5920e487195555b32dfad47030a7efccc05/ash/app_list/views/apps_container_view.cc [modify] https://crrev.com/b210f5920e487195555b32dfad47030a7efccc05/ash/app_list/views/apps_container_view.h [modify] https://crrev.com/b210f5920e487195555b32dfad47030a7efccc05/ash/app_list/views/apps_grid_view.cc [modify] https://crrev.com/b210f5920e487195555b32dfad47030a7efccc05/ash/app_list/views/contents_view.cc [modify] https://crrev.com/b210f5920e487195555b32dfad47030a7efccc05/ash/app_list/views/contents_view.h [modify] https://crrev.com/b210f5920e487195555b32dfad47030a7efccc05/ash/app_list/views/horizontal_page_container.cc |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by leberly@chromium.org
, Sep 7