New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 881845 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug
Team-Accessibility



Sign in to add a comment

Chromevox_tests flakily failing in linux-chromeos-rel bot

Project Member Reported by mcasas@chromium.org, Sep 7

Issue description

Chromevox_tests is flaky in linux-chromeos-rel bot, see e.g.:

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel?limit=200

Concretely seems to be a CursorsTest.DeepEquivalency touble:

https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8936144778139607056/+/steps/chromevox_tests/0/logs/CursorsTest.DeepEquivalency/0

dtseng@ tentatively assigning to you to take a look 
 
Labels: -Pri-3 Pri-2
Yikes, over 30 failures in the past 100 builds. That's pretty flaky.

Strange that the CQ version of that bot doesn't seem to be exhibiting the same flakiness:
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux-chromeos-rel?limit=200
Status: Available (was: Unconfirmed)

Comment 3 Deleted

Comment 4 Deleted

Comment 5 Deleted

[ RUN      ] EditingTest.TextButNoSelectionChange
13588:13588:0910/022341.841042:INFO:CONSOLE(7739)] "Running TestCase EditingTest.TextButNoSelectionChange", source: file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs (7739)
[13588:13588:0910/022341.841254:INFO:CONSOLE(7024)] "ReferenceError: axs is not defined
    at EditingTest.get accessibilityAuditConfig [as accessibilityAuditConfig] (file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs:6695:44)
    at EditingTest.setUp (file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs:6836:10)
    at TestCase.setUp (file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs:6982:20)
    at TestCase.run (file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs:7020:12)
    at RUN_TEST_F (file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs:7740:19)
    at file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs:7533:18
    at runTestFunction (file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs:7602:35)
    at runTest (file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs:7577:16)
    at file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs:10195:1", source: file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs (7024)
[1,995682240:09:23:41.862525] Native Client module will be loaded at base address 0x0000502c00000000
[1:1:0910/022341.890655:WARNING:logging_native_handler.cc(61)] Got locationChanged event on unknown node: 367; this: 311
[1:1:0910/022341.893027:WARNING:logging_native_handler.cc(61)] Got locationChanged event on unknown node: 369; this: 311
[1:1:0910/022341.894805:WARNING:logging_native_handler.cc(61)] Got locationChanged event on unknown node: 367; this: 311
[1:1:0910/022341.895774:WARNING:logging_native_handler.cc(61)] Got locationChanged event on unknown node: 369; this: 311
[1:1:0910/022341.897815:WARNING:logging_native_handler.cc(61)] Got locationChanged event on unknown node: 136; this: 311
[1:1:0910/022341.898771:WARNING:logging_native_handler.cc(61)] Got locationChanged event on unknown node: 136; this: 311
[1:1:0910/022341.902665:WARNING:logging_native_handler.cc(61)] Got locationChanged event on unknown node: 367; this: 311
[1:1:0910/022341.904879:WARNING:logging_native_handler.cc(61)] Got locationChanged event on unknown node: 369; this: 311
[1:1:0910/022341.925845:WARNING:logging_native_handler.cc(61)] Got locationChanged event on unknown node: 134; this: 311
[1:1:0910/022341.977704:WARNING:logging_native_handler.cc(61)] Got textChanged event on unknown node: 2; this: 1
[1:1:0910/022341.984113:WARNING:logging_native_handler.cc(61)] Got locationChanged event on unknown node: 134; this: 311
[1:1:0910/022341.993574:WARNING:logging_native_handler.cc(61)] Got locationChanged event on unknown node: 134; this: 311
../../chrome/test/base/extension_js_browser_test.cc:65: Failure
Failed
Failed: RUN_TEST_F("EditingTest","TextButNoSelectionChange")
TypeError: Cannot read property 'focus' of null
    at EditingTest.<anonymous> (file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs:9372:13)
    at CallbackHelper.<anonymous> (file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs:8398:16)
    at CallFunctionAction.invoke (file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs:7888:22)
    at RunAllAction.invoke (file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs:8049:35)
    at file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs:8408:14
    at Object.listener [as callback] (file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs:8609:21)
    at Object.fireEventListeners_ (extensions::automationNode:817:22)
    at Object.dispatchEventAtCapturing_ (extensions::automationNode:778:12)
    at Object.dispatchEvent (extensions::automationNode:745:14)
    at Object.onAccessibilityEvent (extensions::automationNode:1372:22)
Stack trace:
#0 0x00000072890c testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop()
#1 0x0000007282e9 testing::internal::AssertHelper::operator=()
#2 0x0000005317dd ExtensionJSBrowserTest::RunJavascriptTestF()
#3 0x00000054b715 EditingTest_TextButNoSelectionChange_Test::RunTestOnMainThread()
#4 0x000002b46e4b content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
#5 0x00000286c338 ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
#6 0x00000286b281 ChromeBrowserMainParts::PreMainMessageLoopRun()
#7 0x000001b6e6b3 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun()
#8 0x0000012534c1 content::BrowserMainLoop::PreMainMessageLoopRun()
#9 0x0000015cb797 content::StartupTaskRunner::RunAllTasksNow()
#10 0x000001251e4d content::BrowserMainLoop::CreateStartupTasks()
#11 0x000001255963 content::BrowserMainRunnerImpl::Initialize()
#12 0x00000124fe44 content::BrowserMain()
#13 0x0000027629bb content::ContentMainRunnerImpl::Run()
#14 0x0000041d5b50 service_manager::Main()
#15 0x000002760f54 content::ContentMain()
#16 0x000002b46a7d content::BrowserTestBase::SetUp()
#17 0x000002b44e68 InProcessBrowserTest::SetUp()
gen/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test-gen.cc:101: Failure
Value of: RunJavascriptTestF( true, "EditingTest", "TextButNoSelectionChange")
  Actual: false
Expected: true
Stack trace:
#0 0x00000072890c testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop()
#1 0x0000007282e9 testing::internal::AssertHelper::operator=()
#2 0x00000054b7c0 EditingTest_TextButNoSelectionChange_Test::RunTestOnMainThread()
#3 0x000002b46e4b content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
#4 0x00000286c338 ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
#5 0x00000286b281 ChromeBrowserMainParts::PreMainMessageLoopRun()
#6 0x000001b6e6b3 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun()
#7 0x0000012534c1 content::BrowserMainLoop::PreMainMessageLoopRun()
#8 0x0000015cb797 content::StartupTaskRunner::RunAllTasksNow()
#9 0x000001251e4d content::BrowserMainLoop::CreateStartupTasks()
#10 0x000001255963 content::BrowserMainRunnerImpl::Initialize()
#11 0x00000124fe44 content::BrowserMain()
#12 0x0000027629bb content::ContentMainRunnerImpl::Run()
#13 0x0000041d5b50 service_manager::Main()
#14 0x000002760f54 content::ContentMain()
#15 0x000002b46a7d content::BrowserTestBase::SetUp()
#16 0x000002b44e68 InProcessBrowserTest::SetUp()
[13588:13588:0910/022342.107029:INFO:CONSOLE(648)] "loaded liblouis Native Client instance", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (648)
[13588:13588:0910/022342.107112:INFO:CONSOLE(1262)] "Injecting into 1955319198", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (1262)
[1:1:0910/022342.121292:WARNING:logging_native_handler.cc(61)] Got locationChanged event on unknown node: 134; this: 311
[13588:13588:0910/022342.173948:ERROR:http_bridge.cc(126)] Not implemented reached in virtual void syncer::HttpBridgeFactory::OnSignalReceived()
[13588:13588:0910/022342.174355:INFO:remote_commands_invalidator.cc(45)] Shutdown RemoteCommandsInvalidator.
[13588:13588:0910/022342.174409:INFO:remote_commands_invalidator.cc(68)] Stopping RemoteCommandsInvalidator.
[13588:13588:0910/022342.174421:INFO:remote_commands_invalidator.cc(167)] Unregister RemoteCommandsInvalidator.
[13588:13588:0910/022342.192698:WARNING:pref_notifier_impl.cc(23)] Pref observer found at shutdown.
[13588:13588:0910/022342.192720:WARNING:pref_notifier_impl.cc(23)] Pref observer found at shutdown.
[  FAILED  ] EditingTest.TextButNoSelectionChange, where TypeParam =  and GetParam() =  (1111 ms)
[ RUN      ] EditingTest.RichTextMoveByCharacter
[13855:13855:0910/022343.149470:INFO:CONSOLE(1002)] "Speak (Q) "ChromeVox spoken feedback is ready"", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (1002)
[13855:13855:0910/022343.161995:INFO:CONSOLE(7739)] "Running TestCase EditingTest.RichTextMoveByCharacter", source: file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs (7739)
[13855:13855:0910/022343.162286:INFO:CONSOLE(7024)] "ReferenceError: axs is not defined
    at EditingTest.get accessibilityAuditConfig [as accessibilityAuditConfig] (file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs:6695:44)
    at EditingTest.setUp (file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs:6836:10)
    at TestCase.setUp (file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs:6982:20)
    at TestCase.run (file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs:7020:12)
    at RUN_TEST_F (file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs:7740:19)
    at file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs:7533:18
    at runTestFunction (file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs:7602:35)
    at runTest (file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs:7577:16)
    at file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs:10195:1", source: file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs (7024)
[1,1088051136:09:23:43.181967] Native Client module will be loaded at base address 0x0000190600000000
[1:1:0910/022343.212913:WARNING:logging_native_handler.cc(61)] Got locationChanged event on unknown node: 367; this: 311
[1:1:0910/022343.218430:WARNING:logging_native_handler.cc(61)] Got locationChanged event on unknown node: 369; this: 311
[1:1:0910/022343.219792:WARNING:logging_native_handler.cc(61)] Got locationChanged event on unknown node: 367; this: 311
[1:1:0910/022343.220601:WARNING:logging_native_handler.cc(61)] Got locationChanged event on unknown node: 369; this: 311
[1:1:0910/022343.222182:WARNING:logging_native_handler.cc(61)] Got locationChanged event on unknown node: 136; this: 311
[1:1:0910/022343.222881:WARNING:logging_native_handler.cc(61)] Got locationChanged event on unknown node: 136; this: 311
[1:1:0910/022343.225614:WARNING:logging_native_handler.cc(61)] Got locationChanged event on unknown node: 367; this: 311
[1:1:0910/022343.228623:WARNING:logging_native_handler.cc(61)] Got locationChanged event on unknown node: 369; this: 311
[1:1:0910/022343.245799:WARNING:logging_native_handler.cc(61)] Got locationChanged event on unknown node: 134; this: 311
[1:1:0910/022343.311299:WARNING:logging_native_handler.cc(61)] Got locationChanged event on unknown node: 134; this: 311
[1:1:0910/022343.311492:WARNING:logging_native_handler.cc(61)] Got textChanged event on unknown node: 2; this: 1
[1:1:0910/022343.319978:WARNING:logging_native_handler.cc(61)] Got locationChanged event on unknown node: 134; this: 311
../../chrome/test/base/extension_js_browser_test.cc:65: Failure
Failed
Failed: RUN_TEST_F("EditingTest","RichTextMoveByCharacter")
TypeError: Cannot read property 'doDefault' of null
    at EditingTest.<anonymous> (file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs:9454:28)
    at CallbackHelper.<anonymous> (file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs:8398:16)
    at CallFunctionAction.invoke (file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs:7888:22)
    at RunAllAction.invoke (file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs:8049:35)
    at file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs:8408:14
    at Object.listener [as callback] (file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs:8609:21)
    at Object.fireEventListeners_ (extensions::automationNode:817:22)
    at Object.dispatchEventAtCapturing_ (extensions::automationNode:778:12)
    at Object.dispatchEvent (extensions::automationNode:745:14)
    at Object.onAccessibilityEvent (extensions::automationNode:1372:22)
Stack trace:
#0 0x00000072890c testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop()
#1 0x0000007282e9 testing::internal::AssertHelper::operator=()
#2 0x0000005317dd ExtensionJSBrowserTest::RunJavascriptTestF()
#3 0x00000054bda5 EditingTest_RichTextMoveByCharacter_Test::RunTestOnMainThread()
#4 0x000002b46e4b content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
#5 0x00000286c338 ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
#6 0x00000286b281 ChromeBrowserMainParts::PreMainMessageLoopRun()
#7 0x000001b6e6b3 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun()
#8 0x0000012534c1 content::BrowserMainLoop::PreMainMessageLoopRun()
#9 0x0000015cb797 content::StartupTaskRunner::RunAllTasksNow()
#10 0x000001251e4d content::BrowserMainLoop::CreateStartupTasks()
#11 0x000001255963 content::BrowserMainRunnerImpl::Initialize()
#12 0x00000124fe44 content::BrowserMain()
#13 0x0000027629bb content::ContentMainRunnerImpl::Run()
#14 0x0000041d5b50 service_manager::Main()
#15 0x000002760f54 content::ContentMain()
#16 0x000002b46a7d content::BrowserTestBase::SetUp()
#17 0x000002b44e68 InProcessBrowserTest::SetUp()
gen/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test-gen.cc:159: Failure
Value of: RunJavascriptTestF( true, "EditingTest", "RichTextMoveByCharacter")
  Actual: false
Expected: true
Stack trace:
#0 0x00000072890c testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop()
#1 0x0000007282e9 testing::internal::AssertHelper::operator=()
#2 0x00000054be50 EditingTest_RichTextMoveByCharacter_Test::RunTestOnMainThread()
#3 0x000002b46e4b content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
#4 0x00000286c338 ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
#5 0x00000286b281 ChromeBrowserMainParts::PreMainMessageLoopRun()
#6 0x000001b6e6b3 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun()
#7 0x0000012534c1 content::BrowserMainLoop::PreMainMessageLoopRun()
#8 0x0000015cb797 content::StartupTaskRunner::RunAllTasksNow()
#9 0x000001251e4d content::BrowserMainLoop::CreateStartupTasks()
#10 0x000001255963 content::BrowserMainRunnerImpl::Initialize()
#11 0x00000124fe44 content::BrowserMain()
#12 0x0000027629bb content::ContentMainRunnerImpl::Run()
#13 0x0000041d5b50 service_manager::Main()
#14 0x000002760f54 content::ContentMain()
#15 0x000002b46a7d content::BrowserTestBase::SetUp()
#16 0x000002b44e68 InProcessBrowserTest::SetUp()
[13855:13855:0910/022343.450323:INFO:CONSOLE(648)] "loaded liblouis Native Client instance", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (648)
[13855:13855:0910/022343.450373:INFO:CONSOLE(1262)] "Injecting into 2128968783", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (1262)
[1:1:0910/022343.464320:WARNING:logging_native_handler.cc(61)] Got locationChanged event on unknown node: 134; this: 311
[13855:13855:0910/022343.530607:ERROR:http_bridge.cc(126)] Not implemented reached in virtual void syncer::HttpBridgeFactory::OnSignalReceived()
[13855:13855:0910/022343.530923:INFO:remote_commands_invalidator.cc(45)] Shutdown RemoteCommandsInvalidator.
[13855:13855:0910/022343.530971:INFO:remote_commands_invalidator.cc(68)] Stopping RemoteCommandsInvalidator.
[13855:13855:0910/022343.530983:INFO:remote_commands_invalidator.cc(167)] Unregister RemoteCommandsInvalidator.
[13855:13855:0910/022343.549628:WARNING:pref_notifier_impl.cc(23)] Pref observer found at shutdown.
[13855:13855:0910/022343.549651:WARNING:pref_notifier_impl.cc(23)] Pref observer found at shutdown.
[  FAILED  ] EditingTest.RichTextMoveByCharacter, where TypeParam =  and GetParam() =  (1157 ms)
Labels: Sheriff-Chromium
Status: Assigned (was: Available)
Moving this back to sheriff queue for transparency. There is no use in disabling single tests if you look at the flakiness dashboard:

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chromevox_tests&builder=chromium.chromiumos%3Alinux-chromeos-rel&sortOrder=forward&sortColumn=test

Basically everything is extremely flaky.

Surprisingly, though, this is only the case for linux-chromeos-rel. linux-chromeos-dbg is in an excellent condition.
I'll take a look today. Would have been nice to get a hold of the regressing change which at this point appears to be something deeper down the stack.
Project Member

Comment 10 by bugdroid1@chromium.org, Sep 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bec3e98e347a9fb346774474eb4d7e688c2abd06

commit bec3e98e347a9fb346774474eb4d7e688c2abd06
Author: David Tseng <dtseng@chromium.org>
Date: Mon Sep 10 16:21:27 2018

Revert "Defer AX events to avoid problems with transient focus events."

This reverts commit b9c37a4d0ff00e4f5f190b8c5a5577707ba2f568.

Reason for revert: <INSERT REASONING HERE>
Likey change that causes many tests to flake (in chromevox_tests target).
Bug:  881845 
Original change's description:
> Defer AX events to avoid problems with transient focus events.
> 
> Some dialog boxes, like the accelerator confirmation dialog that appears
> when you press Search+Control+M, focus the dialog and then immediately
> after focus one of the buttons. This was causing ChromeVox to suppress
> information about the context of the dialog.
> 
> Fix this by using PostTask to defer all events from Views. This doesn't
> even add any delay, it just pushes the event firing to after the current
> call stack so that transient changes get suppressed.
> 
> Manually confirmed that the experience with this particular dialog is
> improved, other dialogs and views seem to continue to work fine.
> 
> Bug: 729449
> Change-Id: I278c0c0b1dbdd26a654799fb5b314341942c1373
> Reviewed-on: https://chromium-review.googlesource.com/1176207
> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: David Tseng <dtseng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#589201}

TBR=jamescook@chromium.org,dmazzoni@chromium.org,sky@chromium.org,dtseng@chromium.org,yawano@chromium.org,sarakato@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 729449
Change-Id: I3275d959e96d05fdcfeac3c6b7839f7f36f75735
Reviewed-on: https://chromium-review.googlesource.com/1216664
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589939}
[modify] https://crrev.com/bec3e98e347a9fb346774474eb4d7e688c2abd06/chrome/browser/ui/aura/accessibility/automation_manager_aura.cc
[modify] https://crrev.com/bec3e98e347a9fb346774474eb4d7e688c2abd06/chrome/browser/ui/aura/accessibility/automation_manager_aura.h
[modify] https://crrev.com/bec3e98e347a9fb346774474eb4d7e688c2abd06/chrome/browser/ui/aura/accessibility/automation_manager_aura_browsertest.cc
[modify] https://crrev.com/bec3e98e347a9fb346774474eb4d7e688c2abd06/ui/views/accessibility/ax_aura_obj_cache.cc
[modify] https://crrev.com/bec3e98e347a9fb346774474eb4d7e688c2abd06/ui/views/accessibility/ax_aura_obj_cache.h
[modify] https://crrev.com/bec3e98e347a9fb346774474eb4d7e688c2abd06/ui/views/mus/ax_remote_host_unittest.cc

Cc: yhirano@chromium.org dtseng@chromium.org
 Issue 881434  has been merged into this issue.
Cc: dmazz...@chromium.org nek...@chromium.org aleventhal@chromium.org dougt@chromium.org newcomer@chromium.org achuith@chromium.org aboxhall@chromium.org
 Issue 881485  has been merged into this issue.
Status: Fixed (was: Assigned)
Status: Assigned (was: Fixed)
Reopening:

Please check https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chromevox_tests&builder=chromium.chromiumos%3Alinux-chromeos-rel&sortOrder=forward&sortColumn=test

Even after the revert the bots seem very flaky. I would say that the number of flakes has approximately halved. So that's good news but I think that the tests are still way too flaky to declare victory.

Comment 15 Deleted

These tests are particularly demanding performance wise since they're essentially interactive ui tests (which I believe still get run with 10 parallel jobs).

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel

shows clean runs for at least half a day. 

Lowering priority for that reason. If this crops up again, we should lower the test launcher jobs count.


We have another chromevox flake on the waterfall.

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/13273

Failed: RUN_TEST_F("AutomationUtilE2ETest","FindLastNodeSimple")
TypeError: Cannot read property 'name' of null
    at AutomationUtilE2ETest.<anonymous> (file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util_test.extjs:8979:11)
    at CallbackHelper.<anonymous> (file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util_test.extjs:8398:16)
    at CallFunctionAction.invoke (file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util_test.extjs:7888:22)
    at RunAllAction.invoke (file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util_test.extjs:8049:35)
    at file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util_test.extjs:8408:14
    at Object.listener [as callback] (file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util_test.extjs:8609:21)
    at Object.fireEventListeners_ (extensions::automationNode:817:22)
    at Object.dispatchEventAtCapturing_ (extensions::automationNode:778:12)
    at Object.dispatchEvent (extensions::automationNode:745:14)
    at Object.onAccessibilityEvent (extensions::automationNode:1372:22)
Stack trace:
#0 0x00000072a36c testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop()
#1 0x000000729d49 testing::internal::AssertHelper::operator=()
#2 0x00000053321d ExtensionJSBrowserTest::RunJavascriptTestF()
#3 0x00000053c1ad AutomationUtilE2ETest_FindLastNodeSimple_Test::RunTestOnMainThread()
#4 0x000002b52a7b content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
#5 0x0000028779a8 ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
#6 0x0000028768f1 ChromeBrowserMainParts::PreMainMessageLoopRun()
#7 0x000001b78b53 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun()
#8 0x000001259b41 content::BrowserMainLoop::PreMainMessageLoopRun()
#9 0x0000015d3ff7 content::StartupTaskRunner::RunAllTasksNow()
#10 0x0000012584cd content::BrowserMainLoop::CreateStartupTasks()
#11 0x00000125bfe3 content::BrowserMainRunnerImpl::Initialize()
#12 0x0000012564b4 content::BrowserMain()
#13 0x00000276d27b content::ContentMainRunnerImpl::Run()
#14 0x0000041e52d0 service_manager::Main()
#15 0x00000276b814 content::ContentMain()
#16 0x000002b526b1 content::BrowserTestBase::SetUp()
#17 0x000002b50a08 InProcessBrowserTest::SetUp()
Labels: -Pri-3 Pri-1
Flaky tests should not be P3
Alright, waiting for someone to review
https://chromium-review.googlesource.com/c/chromium/src/+/1222704

which should fix the issue.

Project Member

Comment 20 by bugdroid1@chromium.org, Sep 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9965c86c9d56328bf04bc576385cec22179838c

commit a9965c86c9d56328bf04bc576385cec22179838c
Author: David Tseng <dtseng@chromium.org>
Date: Fri Sep 14 15:29:19 2018

Split chromevox_tests into two targets

- large chromevox tests will move to interactive_ui_tests
These tests drive the user interface by using automation and wait for text to speech feedback that comes from a real tts extension running in memory.

These tests run within the context of an extension background page (so have access to all of the chrome extension apis available to ChromeVox).

- chromevox_tests

These tests will run in a content script-like environment and test js at a class level and not involve things like chrome extension apis.

Bug:  881845 
Change-Id: I88ff32d2831017cfa350348dae20ed49d9fabe50
Reviewed-on: https://chromium-review.googlesource.com/1222704
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591351}
[modify] https://crrev.com/a9965c86c9d56328bf04bc576385cec22179838c/chrome/browser/resources/chromeos/chromevox/BUILD.gn
[modify] https://crrev.com/a9965c86c9d56328bf04bc576385cec22179838c/chrome/browser/resources/chromeos/chromevox/braille/braille_table_test.extjs
[modify] https://crrev.com/a9965c86c9d56328bf04bc576385cec22179838c/chrome/browser/resources/chromeos/chromevox/braille/braille_translator_manager_test.extjs
[modify] https://crrev.com/a9965c86c9d56328bf04bc576385cec22179838c/chrome/browser/resources/chromeos/chromevox/braille/liblouis_test.extjs
[modify] https://crrev.com/a9965c86c9d56328bf04bc576385cec22179838c/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util_test.extjs
[modify] https://crrev.com/a9965c86c9d56328bf04bc576385cec22179838c/chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs
[modify] https://crrev.com/a9965c86c9d56328bf04bc576385cec22179838c/chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs
[modify] https://crrev.com/a9965c86c9d56328bf04bc576385cec22179838c/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs
[modify] https://crrev.com/a9965c86c9d56328bf04bc576385cec22179838c/chrome/browser/resources/chromeos/chromevox/cvox2/background/i_search_test.extjs
[modify] https://crrev.com/a9965c86c9d56328bf04bc576385cec22179838c/chrome/browser/resources/chromeos/chromevox/cvox2/background/live_regions_test.extjs
[modify] https://crrev.com/a9965c86c9d56328bf04bc576385cec22179838c/chrome/browser/resources/chromeos/chromevox/cvox2/background/log_store_test.extjs
[modify] https://crrev.com/a9965c86c9d56328bf04bc576385cec22179838c/chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs
[modify] https://crrev.com/a9965c86c9d56328bf04bc576385cec22179838c/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_test.extjs
[modify] https://crrev.com/a9965c86c9d56328bf04bc576385cec22179838c/chrome/browser/resources/chromeos/chromevox/cvox2/background/recovery_strategy_test.extjs
[modify] https://crrev.com/a9965c86c9d56328bf04bc576385cec22179838c/chrome/browser/resources/chromeos/chromevox/cvox2/background/tree_walker_test.extjs
[modify] https://crrev.com/a9965c86c9d56328bf04bc576385cec22179838c/chrome/browser/resources/chromeos/chromevox/host/chrome/tts_background_test.extjs
[modify] https://crrev.com/a9965c86c9d56328bf04bc576385cec22179838c/chrome/test/BUILD.gn

Project Member

Comment 21 by bugdroid1@chromium.org, Sep 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f80e40ed996a3ad7c787487e9595a3d6e0743e31

commit f80e40ed996a3ad7c787487e9595a3d6e0743e31
Author: David Tseng <dtseng@chromium.org>
Date: Fri Sep 14 17:40:38 2018

Revert "Split chromevox_tests into two targets"

This reverts commit a9965c86c9d56328bf04bc576385cec22179838c.

Reason for revert: <INSERT REASONING HERE>
still seems to flake even when run serially on bots

Original change's description:
> Split chromevox_tests into two targets
> 
> - large chromevox tests will move to interactive_ui_tests
> These tests drive the user interface by using automation and wait for text to speech feedback that comes from a real tts extension running in memory.
> 
> These tests run within the context of an extension background page (so have access to all of the chrome extension apis available to ChromeVox).
> 
> - chromevox_tests
> 
> These tests will run in a content script-like environment and test js at a class level and not involve things like chrome extension apis.
> 
> Bug:  881845 
> Change-Id: I88ff32d2831017cfa350348dae20ed49d9fabe50
> Reviewed-on: https://chromium-review.googlesource.com/1222704
> Commit-Queue: David Tseng <dtseng@chromium.org>
> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#591351}

TBR=dmazzoni@chromium.org,sky@chromium.org,dtseng@chromium.org

Change-Id: If7537afdfb30abbf7effe65062b798b6dd9b36a6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  881845 
Reviewed-on: https://chromium-review.googlesource.com/1226357
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591384}
[modify] https://crrev.com/f80e40ed996a3ad7c787487e9595a3d6e0743e31/chrome/browser/resources/chromeos/chromevox/BUILD.gn
[modify] https://crrev.com/f80e40ed996a3ad7c787487e9595a3d6e0743e31/chrome/browser/resources/chromeos/chromevox/braille/braille_table_test.extjs
[modify] https://crrev.com/f80e40ed996a3ad7c787487e9595a3d6e0743e31/chrome/browser/resources/chromeos/chromevox/braille/braille_translator_manager_test.extjs
[modify] https://crrev.com/f80e40ed996a3ad7c787487e9595a3d6e0743e31/chrome/browser/resources/chromeos/chromevox/braille/liblouis_test.extjs
[modify] https://crrev.com/f80e40ed996a3ad7c787487e9595a3d6e0743e31/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util_test.extjs
[modify] https://crrev.com/f80e40ed996a3ad7c787487e9595a3d6e0743e31/chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs
[modify] https://crrev.com/f80e40ed996a3ad7c787487e9595a3d6e0743e31/chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs
[modify] https://crrev.com/f80e40ed996a3ad7c787487e9595a3d6e0743e31/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs
[modify] https://crrev.com/f80e40ed996a3ad7c787487e9595a3d6e0743e31/chrome/browser/resources/chromeos/chromevox/cvox2/background/i_search_test.extjs
[modify] https://crrev.com/f80e40ed996a3ad7c787487e9595a3d6e0743e31/chrome/browser/resources/chromeos/chromevox/cvox2/background/live_regions_test.extjs
[modify] https://crrev.com/f80e40ed996a3ad7c787487e9595a3d6e0743e31/chrome/browser/resources/chromeos/chromevox/cvox2/background/log_store_test.extjs
[modify] https://crrev.com/f80e40ed996a3ad7c787487e9595a3d6e0743e31/chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs
[modify] https://crrev.com/f80e40ed996a3ad7c787487e9595a3d6e0743e31/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_test.extjs
[modify] https://crrev.com/f80e40ed996a3ad7c787487e9595a3d6e0743e31/chrome/browser/resources/chromeos/chromevox/cvox2/background/recovery_strategy_test.extjs
[modify] https://crrev.com/f80e40ed996a3ad7c787487e9595a3d6e0743e31/chrome/browser/resources/chromeos/chromevox/cvox2/background/tree_walker_test.extjs
[modify] https://crrev.com/f80e40ed996a3ad7c787487e9595a3d6e0743e31/chrome/browser/resources/chromeos/chromevox/host/chrome/tts_background_test.extjs
[modify] https://crrev.com/f80e40ed996a3ad7c787487e9595a3d6e0743e31/chrome/test/BUILD.gn

Project Member

Comment 22 by bugdroid1@chromium.org, Sep 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95f616c9ecd2c339525a3e196fe88f6240f58bae

commit 95f616c9ecd2c339525a3e196fe88f6240f58bae
Author: David Tseng <dtseng@chromium.org>
Date: Sat Sep 15 00:17:42 2018

Speculative fix for chromevox_tests

TBR=dmazzoni@chromium.org

Bug:  881845 
Change-Id: I4b95fe46c6d5c07ad94b17eaf76257e81767763d
Reviewed-on: https://chromium-review.googlesource.com/1225984
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591535}
[modify] https://crrev.com/95f616c9ecd2c339525a3e196fe88f6240f58bae/chrome/browser/resources/chromeos/chromevox/testing/chromevox_next_e2e_test_base.js

Project Member

Comment 23 by bugdroid1@chromium.org, Sep 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd680447881449fba2edcf0589320e7253719212

commit fd680447881449fba2edcf0589320e7253719212
Author: David Tseng <dtseng@chromium.org>
Date: Sat Sep 15 13:28:48 2018

Reland "Defer AX events to avoid problems with transient focus events."

This reverts commit bec3e98e347a9fb346774474eb4d7e688c2abd06.

Reason for revert: <INSERT REASONING HERE>
Core issue likely fixed by
https://chromium-review.googlesource.com/c/chromium/src/+/1225984

Original change's description:
> Revert "Defer AX events to avoid problems with transient focus events."
> 
> This reverts commit b9c37a4d0ff00e4f5f190b8c5a5577707ba2f568.
> 
> Reason for revert: <INSERT REASONING HERE>
> Likey change that causes many tests to flake (in chromevox_tests target).
> Bug:  881845 
> Original change's description:
> > Defer AX events to avoid problems with transient focus events.
> > 
> > Some dialog boxes, like the accelerator confirmation dialog that appears
> > when you press Search+Control+M, focus the dialog and then immediately
> > after focus one of the buttons. This was causing ChromeVox to suppress
> > information about the context of the dialog.
> > 
> > Fix this by using PostTask to defer all events from Views. This doesn't
> > even add any delay, it just pushes the event firing to after the current
> > call stack so that transient changes get suppressed.
> > 
> > Manually confirmed that the experience with this particular dialog is
> > improved, other dialogs and views seem to continue to work fine.
> > 
> > Bug: 729449
> > Change-Id: I278c0c0b1dbdd26a654799fb5b314341942c1373
> > Reviewed-on: https://chromium-review.googlesource.com/1176207
> > Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
> > Reviewed-by: Scott Violet <sky@chromium.org>
> > Reviewed-by: David Tseng <dtseng@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#589201}
> 
> TBR=jamescook@chromium.org,dmazzoni@chromium.org,sky@chromium.org,dtseng@chromium.org,yawano@chromium.org,sarakato@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 729449
> Change-Id: I3275d959e96d05fdcfeac3c6b7839f7f36f75735
> Reviewed-on: https://chromium-review.googlesource.com/1216664
> Reviewed-by: David Tseng <dtseng@chromium.org>
> Commit-Queue: David Tseng <dtseng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#589939}

TBR=jamescook@chromium.org,dmazzoni@chromium.org,sky@chromium.org,dtseng@chromium.org,yawano@chromium.org,sarakato@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  881845 , 729449
Change-Id: I29d828cd47753408e977c243113ae2eb6a6e93f0
Reviewed-on: https://chromium-review.googlesource.com/1227672
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591585}
[modify] https://crrev.com/fd680447881449fba2edcf0589320e7253719212/chrome/browser/ui/aura/accessibility/automation_manager_aura.cc
[modify] https://crrev.com/fd680447881449fba2edcf0589320e7253719212/chrome/browser/ui/aura/accessibility/automation_manager_aura.h
[modify] https://crrev.com/fd680447881449fba2edcf0589320e7253719212/chrome/browser/ui/aura/accessibility/automation_manager_aura_browsertest.cc
[modify] https://crrev.com/fd680447881449fba2edcf0589320e7253719212/ui/views/accessibility/ax_aura_obj_cache.cc
[modify] https://crrev.com/fd680447881449fba2edcf0589320e7253719212/ui/views/accessibility/ax_aura_obj_cache.h
[modify] https://crrev.com/fd680447881449fba2edcf0589320e7253719212/ui/views/mus/ax_remote_host_unittest.cc

Status: Fixed (was: Assigned)
Seems fixed!

Sign in to add a comment