New issue
Advanced search Search tips

Issue 881837 link

Starred by 1 user
Status: Fixed
Owner:
amaralp@chromium.org
Closed: Sep 11
Cc:
mdjones@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

[Duet] Theme color incorrect when opening incognito from shortcut

Project Member Reported by mdjones@chromium.org, Sep 7 
Got some helpful feedback from the play store:

"After most recent update, the bottom menu bar is not the correct color when using the shortcut to go straight into incognito mode."

https://play.google.com/store/apps/details?id=com.chrome.canary&reviewId=gp%3AAOqpTOFYEJdRj2mKOCL2VWmtU2mBJlr5KVUcvA9lHv7Jrx2iFba1wHOQgew-yVbwaPOfJ0dBXZvp2JW1RUoUhRw

This only seems to occur on cold start, so you'll have to kill chrome before using the shortcut to reopen it.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/40d837cae62e543d8bc5289712dfad4547884951

commit 40d837cae62e543d8bc5289712dfad4547884951
Author: Pedro Amaral <amaralp@chromium.org>
Date: Fri Sep 07 21:21:21 2018

Set bottom bar incognito state on initialize native

Previously we assumed that Chrome would always start-up
on regular browsing mode (never in incognito). The linked
bugs prove that this is not true - sometimes the app starts
in incognito. This CL sets the incognito state on initialize
with native.

Bug:  881837 , 880178
Change-Id: I67cf33b4be10997c5f62a85d893febde0c278b87
Reviewed-on: https://chromium-review.googlesource.com/1213313
Commit-Queue: Pedro Amaral <amaralp@chromium.org>
Reviewed-by: Pedro Amaral <amaralp@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589664}
[modify] https://crrev.com/40d837cae62e543d8bc5289712dfad4547884951/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarCoordinator.java
[modify] https://crrev.com/40d837cae62e543d8bc5289712dfad4547884951/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java

Comment 2 by amaralp@chromium.org, Sep 11

Labels: Merge-Request-70

Comment 3 by amaralp@chromium.org, Sep 11

Labels: -Merge-Request-70
Actually, this revision requested merge in crbug.com/880178
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 11

Labels: merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71d1eec4b401b54b17e7f7e65b8ca5a64b730bcb

commit 71d1eec4b401b54b17e7f7e65b8ca5a64b730bcb
Author: Pedro Amaral <amaralp@chromium.org>
Date: Tue Sep 11 20:55:16 2018

Set bottom bar incognito state on initialize native

Previously we assumed that Chrome would always start-up
on regular browsing mode (never in incognito). The linked
bugs prove that this is not true - sometimes the app starts
in incognito. This CL sets the incognito state on initialize
with native.

TBR=amaralp@chromium.org

(cherry picked from commit 40d837cae62e543d8bc5289712dfad4547884951)

Bug:  881837 , 880178
Change-Id: I67cf33b4be10997c5f62a85d893febde0c278b87
Reviewed-on: https://chromium-review.googlesource.com/1213313
Commit-Queue: Pedro Amaral <amaralp@chromium.org>
Reviewed-by: Pedro Amaral <amaralp@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#589664}
Reviewed-on: https://chromium-review.googlesource.com/1220041
Cr-Commit-Position: refs/branch-heads/3538@{#294}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/71d1eec4b401b54b17e7f7e65b8ca5a64b730bcb/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarCoordinator.java
[modify] https://crrev.com/71d1eec4b401b54b17e7f7e65b8ca5a64b730bcb/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java

Comment 5 by amaralp@chromium.org, Sep 11

Status: Fixed (was: Assigned)
►

Sign in to add a comment