New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 881829 link

Starred by 1 user
Status: Fixed
Owner:
gambard@chromium.org
Closed: Sep 11
Cc:
marq@chromium.org
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
█ nyquist@chromium.org
dtrainor@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug-Regression



Sign in to add a comment

FeatureEngagementTestCase fails with WKBasedNavigationManager

Project Member Reported by danyao@chromium.org, Sep 7 
Failing test with --enable-features=SlimNavigationManager:

FeatureEngagementTestCase/testLongPressTipAppearAfterBottomToolbar

Error:
../../ios/chrome/browser/feature_engagement/feature_engagement_egtest.mm:504: error: -[FeatureEngagementTestCase testLongPressTipAppearAfterBottomToolbar] : Exception: AssertionFailedException
Exception Name: AssertionFailedException
Exception Reason: ((WaitUntilConditionOrTimeout(kWaitForUIElementTimeout, condition)) is true) failed
Exception Details: Waiting for the Bottom Toolbar tip.

Comment 1 by danyao@chromium.org, Sep 7

Cc: gambard@chromium.org marq@chromium.org
Something is weird. I can only reproduce this failure when running the entire FeatureEngagementTestCase together, but not if I just run the single test case.

i.e. this causes the above test to fail (everything else passes):
./out/Debug-iphonesimulator/iossim -t FeatureEngagementTestCase -c --enable-features=SlimNavigationManager ./out/Debug-iphonesimulator/ios_chrome_integration_egtests.app ./out/Debug-iphonesimulator/ios_chrome_integration_egtests_module.xctest

But this doesn't fail:
./out/Debug-iphonesimulator/iossim -t FeatureEngagementTestCase/testLongPressTipAppearAfterBottomToolbart -c --enable-features=SlimNavigationManager ./out/Debug-iphonesimulator/ios_chrome_integration_egtests.app ./out/Debug-iphonesimulator/ios_chrome_integration_egtests_module.xctest

Maybe there are states leaking between test cases? gambard@ - do you have any suggestions?

Comment 2 by danyao@chromium.org, Sep 7

Cc: -gambard@chromium.org
Owner: gambard@chromium.org
I can reproduce this breakage without SlimNav enabled.

gambard@ - can you take a look?

Comment 3 by danyao@chromium.org, Sep 7

Blocking: -807428
Labels: -Proj-WKBackForwardList

Comment 4 by danyao@chromium.org, Sep 7

Components: -UI>Browser>Navigation Internals>FeatureEngagement
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec8115ebf2ec33f026f909f915adf65e2a1cb199

commit ec8115ebf2ec33f026f909f915adf65e2a1cb199
Author: Gauthier Ambard <gambard@chromium.org>
Date: Tue Sep 11 09:20:31 2018

[iOS] Do not check for user engagement for bottom tip

The bottom toolbar tip doesn't use the isUserEngaged variable.
This allows us to display the tip multiple time during the isUserEngaged
period, for example during test.

Bug:  881829 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ia4559353aaf831abeb34fd01bf4f4911d1a3267e
Reviewed-on: https://chromium-review.googlesource.com/1215208
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590250}
[modify] https://crrev.com/ec8115ebf2ec33f026f909f915adf65e2a1cb199/ios/chrome/browser/ui/bubble/bubble_presenter.mm

Comment 6 by gambard@chromium.org, Sep 11

Status: Fixed (was: Assigned)
►

Sign in to add a comment