New issue
Advanced search Search tips

Issue 881807 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 3
Type: Bug


Participants' hotlists:
Translate-Fixit


Sign in to add a comment

[Translate] Remove the .reset(new...) pattern for std::unique_ptr

Project Member Reported by ma...@chromium.org, Sep 7

Issue description

In this case

my_unique_ptr.reset(new MyClass(...));

Correct pattern is now to avoid "new" and write things like

my_unique_ptr = std::make_unique<MyClass>(...);

Here's a naive search to find some of those cases in Translate.

https://cs.chromium.org/search/?q=file:components/translate+%22new%22+case:yes&p=2&sq=package:chromium&type=cs
 
Labels: TranslateiOS
Labels: -TranslateiOS Hotlist-TranslateiOS
Labels: -Hotlist-TranslateiOS
Owner: anthonyvd@chromium.org
Status: Assigned (was: Available)

Sign in to add a comment