Chrome Version: 71.0.3545.0 (Official Build) Revision 38ca181b5b0849226f5f15de263301b40cd36b5d-refs/branch-heads/3545@{#1} (32/64-bit)
OS: Mac (10.12.6, 10.13.1, 10.13.6, 10.14), Win (7, 8, 8.1, 10) & Linux (14.04 LTS)

Pre-condition: Enable the flag 'Enable using the Google local NTP' and 'New Tab Page Custom Links' from chrome://flags/

What steps will reproduce the problem?
(1) Launch chrome and open NTP.
(2) Traverse the focus using 'Tab' key on 'Add shortcut'.
(3) Now hold the 'Space bar' key and Observe.

Actual Result:
1) 'Add shortcut' overlay opens up before releasing the 'Space bar' key hold.
2) Unnecessary spaces are entered on holding the 'Space bar' key on 'Add shortcut' overlay.

Expected Result:
1) 'Add shortcut' overlay should open after releasing the 'Space bar' key hold.
2) Unnecessary spaces should not get entered on holding the 'Space bar' key on "Add shortcut" overlay.

This is a Regression issue seen from 'M-71' and providing the bisect info below:
Good Build: 71.0.3543.0 (Revision: 588719)
Bad Build:  71.0.3544.0 (Revision: 589076)

(Unable to provide bisect using 1) Per-revision script as "[Errno 2] No such file or directory" error message is thrown. Also, tried bisecting on multiple machines and same error is thrown. Hence, providing Chromium bisect.)

You are probably looking for a change made after 588719 (known good), but no later than 588746 (first known bad).

CHANGELOG URL:

https://chromium.googlesource.com/chromium/src/+log/d91362969aec8b531a17ecfccbe411dab55a3447..67a71bb8f222f16b93fd8bdf478cc7a10de52f35

Suspecting: r588741 ?

@sweilun: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Please refer the attached screen-cast.

Thank You.

 

Deleted: Actual Video.mov 4.7 MB

	Actual Video.mov 4.7 MB View Download

Deleted: Expected Video.mov 4.5 MB

	Expected Video.mov 4.5 MB View Download