Non-Regression : 'PIN may be easy to guess' text is seen even after 'PIN' field is empty in 'Enter your PIN' overlay of chrome://settings/lockScreen page |
|||
Issue descriptionChrome Version: 69.0.3497.87 / 10895.49.0 beta channel Daisy,Kip and Celes OS: Chrome What steps will reproduce the problem? (1)Sign into User -> Go to chrome://settings -> Now under 'People' section click on 'Screen lock' option (2)Now enter User Password in 'Confirm your password' dialog box -> At 'screen lock options' section select 'PIN or Password' option -> click on 'SET UP PIN' ->'Enter your PIN' overlay is seen and observe 'PIN must be at least 6 digits' text (3)Now enter required digits(6 digits) and observe 'PIN may be easy to guess' text is seen-> now press 'Tab'until focus is on digit '1' (4)Now press 'Shift+Tab' key to bring back focus on 'PIN' field -> press 'Backspace' key so that pin will be erased -> observe 'PIN may be easy to guess' text is still seen (Please refer Video and Screenshot) Expected: 'PIN must be at least 6 digits' text should be seen after PIN is erased and when 'PIN' field is empty Actual: Instead 'PIN may be easy to guess' text is seen This is Non-Regression Issue as 'Screen lock' option is introduced from M-57 @sammiequon : Please confirm the Issue
,
Sep 24
,
Nov 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a0ef725be055cbf7d9e47b33211d66bbec884297 commit a0ef725be055cbf7d9e47b33211d66bbec884297 Author: Sammie Quon <sammiequon@google.com> Date: Tue Nov 13 22:29:08 2018 cros: Show correct PIN setup error message after highlight and delete. Also fix issue where users could not backspace by using keyboard tab and space. Test: manual Bug: 881756 , 862924 Change-Id: I0523784ad05d2a02219e95e90cd02b2d275da94f Reviewed-on: https://chromium-review.googlesource.com/c/1329748 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#607768} [modify] https://crrev.com/a0ef725be055cbf7d9e47b33211d66bbec884297/ui/webui/resources/cr_components/chromeos/quick_unlock/pin_keyboard.html [modify] https://crrev.com/a0ef725be055cbf7d9e47b33211d66bbec884297/ui/webui/resources/cr_components/chromeos/quick_unlock/pin_keyboard.js [modify] https://crrev.com/a0ef725be055cbf7d9e47b33211d66bbec884297/ui/webui/resources/cr_components/chromeos/quick_unlock/setup_pin_keyboard.js
,
Nov 13
,
Nov 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/924da3ba93abef2063a3b6bfdebe4ad802f39f77 commit 924da3ba93abef2063a3b6bfdebe4ad802f39f77 Author: Sammie Quon <sammiequon@google.com> Date: Wed Nov 28 02:16:18 2018 cros: Fix regression with pin message persistent in confirm stage. Partial reverted the cl which introduced this regression. I will reopen the original bug and try a better fix later. Test: manual Bug: 881756 , 907002 Change-Id: Idbe3a587caad485968d78b0b4841f1bfa0105366 Reviewed-on: https://chromium-review.googlesource.com/c/1344221 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#611517} [modify] https://crrev.com/924da3ba93abef2063a3b6bfdebe4ad802f39f77/ui/webui/resources/cr_components/chromeos/quick_unlock/setup_pin_keyboard.js |
|||
►
Sign in to add a comment |
|||
Comment 1 by cindyb@chromium.org
, Sep 10