Regression: [NTP] Applied Chrome background wallpaper doesn't reflect on NTP.
Reported by
dchau...@etouch.net,
Sep 7
|
||||||
Issue descriptionChrome Version: 71.0.3545.0 (Official Build) Revision 38ca181b5b0849226f5f15de263301b40cd36b5d-refs/branch-heads/3545@{#1} (32/64-bit) OS: Windows(7,8,8.1,10), Mac(10.12.6, 10.13.1, 10.14, 10.13.6) and Linux(14.04 LTs) Pre-condition: Enable "Enable using the Google local NTP" and "New Tab Page Background Selection" flags from chrome://flags. Test-URL: https://chrome.google.com/webstore/detail/%D0%BB%D0%B5%D1%82%D1%8F%D1%89%D0%B8%D0%B5-%D0%BA%D1%80%D0%B0%D1%81%D0%BA%D0%B8/iaddkdiibkddhdbcmmplkhcpgeinggfo?hl=en What steps will reproduce the problem? 1. Launch Chrome, go to NTP and click on gear icon to open 'Customize this page' menu list. 2. Click on Chrome background option to open 'Select a collection' overlay and select any wallpaper from it. 3. Go to above URL or add any theme from Chrome web store and go to NTP so that 'Undo' button appears on NTP. 4. Now click on 'Undo' button and observe the NTP. Actual: Applied Chrome background wallpaper doesn't reflect on NTP after clicking on 'Undo' button. Expected: Applied Chrome background wallpaper should reflect on NTP after clicking on 'Undo' button. This is a regression issue, broken in M-69 series, below is manual regression range: Good build: 69.0.3472.0 (Revision: 569949) Bad build: 69.0.3473.0 (Revision: 570288) Using the 'per-revision' script providing the bisect result: You are probably looking for a change made after 570050 (known good), but no later than 570051 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/36818434a5be94d42702991733526ce02c9a6492..fb37a7751767042a073aec2769fb1dd7a027b381 Suspecting: https://chromium.googlesource.com/chromium/src/+/fb37a7751767042a073aec2769fb1dd7a027b381 @kmilka: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. NOTE: This issue is also reproducible on Stable & Beta #69.0.3497.81 & Dev #70.0.3538.9 Kindly review the attached screen-cast for reference. Thank you.
,
Sep 10
,
Sep 11
More specifically, it looks like the issue is that open NTPs do not revert back to the custom background unless reloaded - navigating to another tab & back to the NTP causes the background to be loaded. Also, new NTPs have the custom background image. Given the rarity of this issue, I'm lowering the priority & removing M69 / M70 targets.
,
Sep 11
,
Sep 28
,
Sep 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1751f079222707da44a6f398cc74565afe2f8bd7 commit 1751f079222707da44a6f398cc74565afe2f8bd7 Author: Kyle Milka <kmilka@chromium.org> Date: Fri Sep 28 20:37:46 2018 [NTP] Show custom background when undoing a theme installation When undo is pressed on the theme installation info bar the background should be reset to the selected custom background. To accomplish this run the same update theme info logic whenever the theme is changed. Bug: 881750 Change-Id: I1fe5d8d2f8c6d9459a65a4cd801b5583b8f21935 Reviewed-on: https://chromium-review.googlesource.com/1252461 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#595199} [modify] https://crrev.com/1751f079222707da44a6f398cc74565afe2f8bd7/chrome/browser/search/instant_service.cc
,
Sep 28
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by kmilka@chromium.org
, Sep 7Labels: -Pri-1 OS-Chrome Pri-2