New issue
Advanced search Search tips

Issue 881745 link

Starred by 1 user
Status: Verified
Owner:
aee@chromium.org
Closed: Sep 24
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Spellcheck is seen for entered text in 'chrome://settings/manageProfile'.

Reported by pranjali...@etouch.net, Sep 7 
Chrome version :71.0.3545.0 (Official Build) 38ca181b5b0849226f5f15de263301b40cd36b5d-refs/branch-heads/3545@{#1}(32/64 bit)

OS:  Win(7,8,8.1,10) , Mac(10.12.6 , 10.13.1 , 10.13.6 , 10.14)  and Linux(14.04 LTS) OS

What steps will reproduce the problem?
1.Launch chrome and navigate to'chrome://settings/manageProfile'.
2. Now enter random text in textfield and observe.

Actual  : Spellcheck is seen for entered text in 'chrome://settings/manageProfile'.
Expected:Spellcheck should not be seen for entered text in 'chrome://settings/manageProfile'.

This is a regression issue broken in ‘M-68’ and below is bisect info.
Good build: 68.0.3401.0 
Bad build: 68.0.3402.0 

You are probably looking for a change made after 552269 (known good), but no later than 552270 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/527433a7047fd56a0db0189a80a422087a1ab951..8712023f7d10238966ed56d02d27f10e02c8c394

Suspect: https://chromium.googlesource.com/chromium/src/+/8712023f7d10238966ed56d02d27f10e02c8c394

@xiaochengh: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Thank You
Actual Result.mp4
325 KB View Download
Expected Result.mp4
318 KB View Download

Comment 1 by rbasuvula@chromium.org, Sep 7 

@xiaochengh: As per change log its look like intentional behavior. Could you please confirm.

Thank You!

Comment 2 by xiaoche...@chromium.org, Sep 7

Owner: dpa...@chromium.org
dpapad@: I guess this text box doesn't want spellchecking, either. Could you take a look? Thanks!

Comment 3 by dpa...@chromium.org, Sep 7

Owner: aee@chromium.org
@aee: Could you take a look? This might be one more case where we should disable spellcheck, similar to  issue 865418  and  issue 866359 .

Comment 4 by aee@chromium.org, Sep 20

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bbda8940c6d83dc526e46f6697e3d01a0f8a94da

commit bbda8940c6d83dc526e46f6697e3d01a0f8a94da
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Thu Sep 20 23:02:47 2018

Settings: turn off spellcheck for profile name inputs

Bug:  881745 
Change-Id: I46d30ba82182ce47d9f78a9765db76fba835febf
Reviewed-on: https://chromium-review.googlesource.com/1237258
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592989}
[modify] https://crrev.com/bbda8940c6d83dc526e46f6697e3d01a0f8a94da/chrome/browser/resources/md_user_manager/create_profile.html
[modify] https://crrev.com/bbda8940c6d83dc526e46f6697e3d01a0f8a94da/chrome/browser/resources/settings/people_page/manage_profile.html

Comment 6 by pranjali...@etouch.net, Sep 21

Labels: TE-Verified-M71 TE-Verified-71.0.3558.0
Update:

Rechecked the above issue using latest canary build#71.0.3558.0 on  Win(7,8,8.1,10) , Mac(10.12.6 , 10.13.1 , 10.13.6 , 10.14)  and Linux(14.04 LTS) OS and issue s fixed.

Please refer attached screen cast.

Thank You...
Canary Behaviour.mp4
301 KB View Download

Comment 7 by aee@chromium.org, Sep 24

Status: Verified (was: Started)
►

Sign in to add a comment