New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 881742 link

Starred by 2 users
Status: Fixed
Owner:
█ raymes@chromium.org
OOO until 4th Feb
Closed: Sep 10
Cc:
yyushkina@chromium.org
timloh@chromium.org
nyerramilli@chromium.org
rbasuvula@chromium.org
█ ramyan@chromium.org
treib@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression
Team-Security-UX



Sign in to add a comment

Regression : Chrome doesn't show permission bubble after clicking on 'Microphone' icon on NTP.

Reported by avsha...@etouch.net, Sep 7 
Chrome Version : 71.0.3545.0 (Official Build) 38ca181b5b0849226f5f15de263301b40cd36b5d-refs/branch-heads/3545@{#1} 32/64 bit
OS : Windows (7, 8, 8.1, 10), Linux(14.04 LTS), Mac(10.12.6, 10.13.1, 10.14, 10.13.6)

Precondition : Install a fresh copy of chrome canary.

What steps will reproduce the problem?
1. Launch chrome and open two NTPs.
2. On second NTP, click on 'Microphone' icon present inside fake box.
3. Observe.

Actual Result : Chrome doesn't show permission bubble after clicking on 'Microphone' icon on NTP. (Instead, chrome automatically 'Allows' the 'Microphone' permission.)

Expected Result : Chrome should show permission bubble when user click on 'Microphone' icon.

This is a regression issue broken in ‘M-71’ and below is the 'per-revision' bisect information:
Good Build : 71.0.3543.0 (Revision : 586475)
Bad Build : 71.0.3544.0 (Revision : 587136)

Change Log URL :
https://chromium.googlesource.com/chromium/src/+log/08441c418c6c1d84f91dd72f7b7eb2a4eaca0df7..5e9f806410de4daa95cc0f57061e12270391fdff

Suspecting : https://chromium.googlesource.com/chromium/src/+/5e9f806410de4daa95cc0f57061e12270391fdff

Raymes@ : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note : 
This issue is not observed in latest branch build #70.0.3538.11
This issue is seen only for the NTP 'Microphone' icon.

Thank you..!
Expected_Result.mp4
326 KB View Download
Actual_Result.mp4
407 KB View Download

Comment 1 by avsha...@etouch.net, Sep 7 

Correction in revision number,

Please find below the correct revisions :
Good Build : 71.0.3543.0 (Revision : 588719)
Bad Build : 71.0.3544.0 (Revision : 589076)

Comment 2 by rbasuvula@chromium.org, Sep 7 

@raymes: Change log Looks like intentional change could you please confirm.

Thank You!

Comment 3 by raymes@chromium.org, Sep 10

Cc: treib@chromium.org timloh@chromium.org
Components: Internals>Permissions
I can't reproduce this on linux on 71.0.3548.0. Can anyone else reproduce this?

Comment 4 by raymes@chromium.org, Sep 10 

This could be repro'd by disabling the new local NTP. I've got a patch.

Comment 5 by treib@chromium.org, Sep 10

Cc: ramyan@chromium.org
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d561ffcfbc599ca64178e097ad073ac4944dcf5

commit 9d561ffcfbc599ca64178e097ad073ac4944dcf5
Author: Raymes Khoury <raymes@chromium.org>
Date: Mon Sep 10 08:18:17 2018

Ensure a permission prompt is shown for voice search on the old NTP

The old NTP should show a permission prompt when the first voice search
happens. However when permission delegation was enabled it caused the
wrong origin to be used for the request: chrome://newtab instead of the
search origin (e.g. google.com). This CL fixes the origin so that the
search origin is again used for the request.

This bug does not impact the new NTP.

Bug:  881742 
Change-Id: Ic70c39d2adb2efafbea3f5c8b89d462c9f01352c
Reviewed-on: https://chromium-review.googlesource.com/1214976
Reviewed-by: Timothy Loh <timloh@chromium.org>
Commit-Queue: Raymes Khoury <raymes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589852}
[modify] https://crrev.com/9d561ffcfbc599ca64178e097ad073ac4944dcf5/chrome/browser/permissions/permission_manager.cc
[modify] https://crrev.com/9d561ffcfbc599ca64178e097ad073ac4944dcf5/chrome/browser/permissions/permission_manager_unittest.cc

Comment 7 by ramyan@chromium.org, Sep 10

Cc: yyushkina@chromium.org
Thanks for the heads up & for fixing this so quickly!

Comment 8 by raymes@chromium.org, Sep 10

Status: Fixed (was: Assigned)
►

Sign in to add a comment