New issue
Advanced search Search tips

Issue 881735 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Sep 8
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in blink::JankTracker::AccumulateJank

Project Member Reported by ClusterFuzz, Sep 7

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5975344899948544

Fuzzer: ochang_domfuzzer
Job Type: linux_asan_content_shell_drt
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000000
Crash State:
  blink::JankTracker::AccumulateJank
  blink::CompositedLayerMapping::UpdateMainGraphicsLayerGeometry
  blink::PaintLayerCompositor::UpdateIfNeeded
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=589262:589272

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5975344899948544

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Sep 7

Labels: OS-Mac
Project Member

Comment 2 by ClusterFuzz, Sep 7

Components: Blink>Compositing Blink>Layout
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 3 by ClusterFuzz, Sep 7

Labels: Test-Predator-Auto-Owner
Owner: skobes@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/a60db65dec5655f0944484a01bd34573f2292765 (Track layout jank from composited layer movement.).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ecca624af2441174fc6c72fd6a23508faa0e87ed

commit ecca624af2441174fc6c72fd6a23508faa0e87ed
Author: Steve Kobes <skobes@chromium.org>
Date: Fri Sep 07 21:11:41 2018

Check for fragment data in JankTracker::NotifyCompositedLayerMoved.

If we haven't gone through prepaint since the LayoutObject was attached,
we will crash accessing the transform node.

Bug: 881921,  881735 ,  881643 
Change-Id: I3c27c045a87319a3da2f1803707d42139d41cbfd
Reviewed-on: https://chromium-review.googlesource.com/1213805
Commit-Queue: Steve Kobes <skobes@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589648}
[modify] https://crrev.com/ecca624af2441174fc6c72fd6a23508faa0e87ed/third_party/blink/renderer/core/layout/jank_tracker.cc
[modify] https://crrev.com/ecca624af2441174fc6c72fd6a23508faa0e87ed/third_party/blink/renderer/core/layout/jank_tracker_test.cc

Project Member

Comment 5 by ClusterFuzz, Sep 8

ClusterFuzz has detected this issue as fixed in range 589630:589665.

Detailed report: https://clusterfuzz.com/testcase?key=5975344899948544

Fuzzer: ochang_domfuzzer
Job Type: linux_asan_content_shell_drt
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000000
Crash State:
  blink::JankTracker::AccumulateJank
  blink::CompositedLayerMapping::UpdateMainGraphicsLayerGeometry
  blink::PaintLayerCompositor::UpdateIfNeeded
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=589262:589272
Fixed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=589630:589665

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5975344899948544

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 6 by ClusterFuzz, Sep 8

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5975344899948544 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment