New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 881730 link

Starred by 1 user
Status: Fixed
Owner:
se...@chromium.org
Closed: Sep 11
Cc:
treib@chromium.org
jkrcal@chromium.org
mastiz@chromium.org
ftirelo@chromium.org
█ tschumann@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Google Pay save is not offered in Butter mode

Project Member Reported by feuunk@google.com, Sep 7 
On top-of-tree, with the flags in go/butter-food enabled, the following test fails for me locally:

1. Go to https://dump-truck.appspot.com/usecase-address_and_cc_on_same_page/address_and_cc.html

2. Enter a card that was not saved on the device or account yet

3. Submit the form

4. Verify that you’re prompted to “Save card to Google Pay”.  

Here, I only get the local save prompt, and I confirmed that pressing save on that prompt indeed only saves the card locally.

This is a blocker for the 1% Butter experiment, which is planned for M70.

Comment 1 by feuunk@google.com, Sep 7 

(I used my gcard to test this, with my test account: test.feuunk@gmail.com)

You have my permission to look at my account data if that helps with debugging.

Comment 2 by feuunk@google.com, Sep 7 

Maybe relevant: Unmasking a card that I have previously saved to the account through payments.google.com works for this account and setup.

Comment 3 by se...@chromium.org, Sep 7

Status: Started (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/99e4e0f3c851a93c897de63864b0536ff7050bfa

commit 99e4e0f3c851a93c897de63864b0536ff7050bfa
Author: sebsg <sebsg@chromium.org>
Date: Fri Sep 07 19:02:04 2018

[AF] Make IsCreditCardUploadEnabled use ActiveAccount email if in Butter

It used to get the Primary Account's email but should get the active
account's one instead if in Butter state.

Bug:  881730 
Change-Id: I1e48d39bd1c908bee82034e1eb7b40231f6c788d
Reviewed-on: https://chromium-review.googlesource.com/1213444
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589617}
[modify] https://crrev.com/99e4e0f3c851a93c897de63864b0536ff7050bfa/components/autofill/core/browser/account_info_getter.h
[modify] https://crrev.com/99e4e0f3c851a93c897de63864b0536ff7050bfa/components/autofill/core/browser/autofill_experiments.cc
[modify] https://crrev.com/99e4e0f3c851a93c897de63864b0536ff7050bfa/components/autofill/core/browser/credit_card_save_manager.cc
[modify] https://crrev.com/99e4e0f3c851a93c897de63864b0536ff7050bfa/components/autofill/core/browser/payments/full_card_request_unittest.cc
[modify] https://crrev.com/99e4e0f3c851a93c897de63864b0536ff7050bfa/components/autofill/core/browser/payments/payments_client.cc
[modify] https://crrev.com/99e4e0f3c851a93c897de63864b0536ff7050bfa/components/autofill/core/browser/payments/payments_client_unittest.cc
[modify] https://crrev.com/99e4e0f3c851a93c897de63864b0536ff7050bfa/components/autofill/core/browser/personal_data_manager.cc
[modify] https://crrev.com/99e4e0f3c851a93c897de63864b0536ff7050bfa/components/autofill/core/browser/personal_data_manager.h
[modify] https://crrev.com/99e4e0f3c851a93c897de63864b0536ff7050bfa/components/autofill/core/browser/personal_data_manager_unittest.cc
[modify] https://crrev.com/99e4e0f3c851a93c897de63864b0536ff7050bfa/components/autofill/core/browser/test_personal_data_manager.cc
[modify] https://crrev.com/99e4e0f3c851a93c897de63864b0536ff7050bfa/components/autofill/core/browser/test_personal_data_manager.h
[modify] https://crrev.com/99e4e0f3c851a93c897de63864b0536ff7050bfa/components/autofill/core/browser/test_sync_service.cc
[modify] https://crrev.com/99e4e0f3c851a93c897de63864b0536ff7050bfa/components/autofill/core/browser/test_sync_service.h
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26fbd76cc1a4da4a46117dfd20e3e1a53c9bd177

commit 26fbd76cc1a4da4a46117dfd20e3e1a53c9bd177
Author: John Budorick <jbudorick@chromium.org>
Date: Fri Sep 07 19:30:17 2018

Revert "[AF] Make IsCreditCardUploadEnabled use ActiveAccount email if in Butter"

This reverts commit 99e4e0f3c851a93c897de63864b0536ff7050bfa.

Reason for revert: Looks like this broke compile, possibly due to conflicts w/ https://chromium.googlesource.com/chromium/src/+/19e91cc9aefac767e9482351123b11f1bb6e2c70

Original change's description:
> [AF] Make IsCreditCardUploadEnabled use ActiveAccount email if in Butter
> 
> It used to get the Primary Account's email but should get the active
> account's one instead if in Butter state.
> 
> Bug:  881730 
> Change-Id: I1e48d39bd1c908bee82034e1eb7b40231f6c788d
> Reviewed-on: https://chromium-review.googlesource.com/1213444
> Reviewed-by: Mathieu Perreault <mathp@chromium.org>
> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#589617}

TBR=mathp@chromium.org,sebsg@chromium.org,feuunk@chromium.org

Change-Id: Ida5dc715c7eb6618d213a676f00a0476b0cd2cad
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  881730 
Reviewed-on: https://chromium-review.googlesource.com/1214105
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589619}
[modify] https://crrev.com/26fbd76cc1a4da4a46117dfd20e3e1a53c9bd177/components/autofill/core/browser/account_info_getter.h
[modify] https://crrev.com/26fbd76cc1a4da4a46117dfd20e3e1a53c9bd177/components/autofill/core/browser/autofill_experiments.cc
[modify] https://crrev.com/26fbd76cc1a4da4a46117dfd20e3e1a53c9bd177/components/autofill/core/browser/credit_card_save_manager.cc
[modify] https://crrev.com/26fbd76cc1a4da4a46117dfd20e3e1a53c9bd177/components/autofill/core/browser/payments/full_card_request_unittest.cc
[modify] https://crrev.com/26fbd76cc1a4da4a46117dfd20e3e1a53c9bd177/components/autofill/core/browser/payments/payments_client.cc
[modify] https://crrev.com/26fbd76cc1a4da4a46117dfd20e3e1a53c9bd177/components/autofill/core/browser/payments/payments_client_unittest.cc
[modify] https://crrev.com/26fbd76cc1a4da4a46117dfd20e3e1a53c9bd177/components/autofill/core/browser/personal_data_manager.cc
[modify] https://crrev.com/26fbd76cc1a4da4a46117dfd20e3e1a53c9bd177/components/autofill/core/browser/personal_data_manager.h
[modify] https://crrev.com/26fbd76cc1a4da4a46117dfd20e3e1a53c9bd177/components/autofill/core/browser/personal_data_manager_unittest.cc
[modify] https://crrev.com/26fbd76cc1a4da4a46117dfd20e3e1a53c9bd177/components/autofill/core/browser/test_personal_data_manager.cc
[modify] https://crrev.com/26fbd76cc1a4da4a46117dfd20e3e1a53c9bd177/components/autofill/core/browser/test_personal_data_manager.h
[modify] https://crrev.com/26fbd76cc1a4da4a46117dfd20e3e1a53c9bd177/components/autofill/core/browser/test_sync_service.cc
[modify] https://crrev.com/26fbd76cc1a4da4a46117dfd20e3e1a53c9bd177/components/autofill/core/browser/test_sync_service.h
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf4b4df3f6ce8a0ebef1eac5824e42e044fb88f3

commit cf4b4df3f6ce8a0ebef1eac5824e42e044fb88f3
Author: sebsg <sebsg@chromium.org>
Date: Fri Sep 07 21:33:07 2018

Reland [AF] Make IsCreditCardUploadEnabled use ActiveAccount if Butter

CL was reverted here:
https://chromium-review.googlesource.com/c/chromium/src/+/1214105

The issue was another CL that renamed a function landed at the same
time.

It used to get the Primary Account's email but should get the active
account's one instead if in Butter state.

Bug:  881730 
Change-Id: I9b5b489bc5237d044e7e36fde5eda7f7da7ada27
Reviewed-on: https://chromium-review.googlesource.com/1214063
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589668}
[modify] https://crrev.com/cf4b4df3f6ce8a0ebef1eac5824e42e044fb88f3/components/autofill/core/browser/account_info_getter.h
[modify] https://crrev.com/cf4b4df3f6ce8a0ebef1eac5824e42e044fb88f3/components/autofill/core/browser/autofill_experiments.cc
[modify] https://crrev.com/cf4b4df3f6ce8a0ebef1eac5824e42e044fb88f3/components/autofill/core/browser/autofill_experiments.h
[modify] https://crrev.com/cf4b4df3f6ce8a0ebef1eac5824e42e044fb88f3/components/autofill/core/browser/credit_card_save_manager.cc
[modify] https://crrev.com/cf4b4df3f6ce8a0ebef1eac5824e42e044fb88f3/components/autofill/core/browser/payments/full_card_request_unittest.cc
[modify] https://crrev.com/cf4b4df3f6ce8a0ebef1eac5824e42e044fb88f3/components/autofill/core/browser/payments/payments_client.cc
[modify] https://crrev.com/cf4b4df3f6ce8a0ebef1eac5824e42e044fb88f3/components/autofill/core/browser/payments/payments_client_unittest.cc
[modify] https://crrev.com/cf4b4df3f6ce8a0ebef1eac5824e42e044fb88f3/components/autofill/core/browser/personal_data_manager.cc
[modify] https://crrev.com/cf4b4df3f6ce8a0ebef1eac5824e42e044fb88f3/components/autofill/core/browser/personal_data_manager.h
[modify] https://crrev.com/cf4b4df3f6ce8a0ebef1eac5824e42e044fb88f3/components/autofill/core/browser/personal_data_manager_unittest.cc
[modify] https://crrev.com/cf4b4df3f6ce8a0ebef1eac5824e42e044fb88f3/components/autofill/core/browser/test_personal_data_manager.cc
[modify] https://crrev.com/cf4b4df3f6ce8a0ebef1eac5824e42e044fb88f3/components/autofill/core/browser/test_personal_data_manager.h
[modify] https://crrev.com/cf4b4df3f6ce8a0ebef1eac5824e42e044fb88f3/components/autofill/core/browser/test_sync_service.cc
[modify] https://crrev.com/cf4b4df3f6ce8a0ebef1eac5824e42e044fb88f3/components/autofill/core/browser/test_sync_service.h

Comment 7 by se...@chromium.org, Sep 10

Labels: Merge-Request-70
Project Member

Comment 8 by sheriffbot@chromium.org, Sep 10

Labels: -Merge-Request-70 Merge-Review-70 Hotlist-Merge-Review
This bug requires manual review: Reverts referenced in bugdroid comments after merge request.
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 9 by abdulsyed@chromium.org, Sep 10 

is this well tested in canary? Change seems fairly large.

Comment 10 by se...@chromium.org, Sep 10 

The change has been tested by multiple team members on Canary, so I'm pretty confident :)

Comment 11 by abdulsyed@chromium.org, Sep 11

Labels: -Merge-Review-70 Merge-Approved-70
Approved - branch:3538
Project Member

Comment 12 by bugdroid1@chromium.org, Sep 11

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27b0b1c97039baabb303bd75f6e7033131b8d326

commit 27b0b1c97039baabb303bd75f6e7033131b8d326
Author: sebsg <sebsg@chromium.org>
Date: Tue Sep 11 19:17:07 2018

Merge70 [AF] Make IsCreditCardUploadEnabled use ActiveAccount if Butter

CL was reverted here:
https://chromium-review.googlesource.com/c/chromium/src/+/1214105

The issue was another CL that renamed a function landed at the same
time.

It used to get the Primary Account's email but should get the active
account's one instead if in Butter state.

TBR=sebsg@chromium.org

(cherry picked from commit cf4b4df3f6ce8a0ebef1eac5824e42e044fb88f3)

Bug:  881730 
Change-Id: I9b5b489bc5237d044e7e36fde5eda7f7da7ada27
Reviewed-on: https://chromium-review.googlesource.com/1214063
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#589668}
Reviewed-on: https://chromium-review.googlesource.com/1219993
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#282}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/27b0b1c97039baabb303bd75f6e7033131b8d326/components/autofill/core/browser/account_info_getter.h
[modify] https://crrev.com/27b0b1c97039baabb303bd75f6e7033131b8d326/components/autofill/core/browser/autofill_experiments.cc
[modify] https://crrev.com/27b0b1c97039baabb303bd75f6e7033131b8d326/components/autofill/core/browser/autofill_experiments.h
[modify] https://crrev.com/27b0b1c97039baabb303bd75f6e7033131b8d326/components/autofill/core/browser/credit_card_save_manager.cc
[modify] https://crrev.com/27b0b1c97039baabb303bd75f6e7033131b8d326/components/autofill/core/browser/payments/full_card_request_unittest.cc
[modify] https://crrev.com/27b0b1c97039baabb303bd75f6e7033131b8d326/components/autofill/core/browser/payments/payments_client.cc
[modify] https://crrev.com/27b0b1c97039baabb303bd75f6e7033131b8d326/components/autofill/core/browser/payments/payments_client_unittest.cc
[modify] https://crrev.com/27b0b1c97039baabb303bd75f6e7033131b8d326/components/autofill/core/browser/personal_data_manager.cc
[modify] https://crrev.com/27b0b1c97039baabb303bd75f6e7033131b8d326/components/autofill/core/browser/personal_data_manager.h
[modify] https://crrev.com/27b0b1c97039baabb303bd75f6e7033131b8d326/components/autofill/core/browser/personal_data_manager_unittest.cc
[modify] https://crrev.com/27b0b1c97039baabb303bd75f6e7033131b8d326/components/autofill/core/browser/test_personal_data_manager.cc
[modify] https://crrev.com/27b0b1c97039baabb303bd75f6e7033131b8d326/components/autofill/core/browser/test_personal_data_manager.h
[modify] https://crrev.com/27b0b1c97039baabb303bd75f6e7033131b8d326/components/autofill/core/browser/test_sync_service.cc
[modify] https://crrev.com/27b0b1c97039baabb303bd75f6e7033131b8d326/components/autofill/core/browser/test_sync_service.h

Comment 13 by se...@chromium.org, Sep 11

Status: Fixed (was: Started)

Comment 14 by jkrcal@chromium.org, Sep 12

Labels: butter-hotlist
►

Sign in to add a comment