New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 881710 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit 18 days ago
Closed: Sep 7
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Unnecessarily text caret moves to disabled NTP search field when 'Shortcut added' notification bar disappears.

Reported by rp...@etouch.net, Sep 7

Issue description

Chrome Version: 71.0.3545.0 (Official Build)Revision 38ca181b5b0849226f5f15de263301b40cd36b5d-refs/branch-heads/3545@{#1}(32/64-bit)
OS: Windows(7,8,8.1,10),Mac(10.12.6 , 10.13.1 , 10.13.6, 10.14) and Linux(14.04 LTS)

Pre-Condition: Enable "Enable using the Google local NTP" and  "New Tab Page Custom Links" flags under chrome://flags

What steps will reproduce the problem?
1. Launch chrome, navigate to NTP and click on 'Add shortcut' icon to open the overlay.
2. Enter the 'URL' text-fields and click on 'Done' button to create a shortcut so that 'Shortcut added' notification bar floats up.
3. Now immediately click on 'Add shortcut' icon and enter text in URL field and observe caret blinking after 'Shortcut added' notification bar disappears

Actual Result: Unnecessarily text caret moves to disabled NTP 'Search Google' search field when 'Shortcut added' notification bar disappears
Expected Result: Text caret should remain in URL textfield even after 'Shortcut added' notification bar disappears

This is regression issue broken in ‘M-71’ and below is the bisect info:
Good build: 71.0.3543.0 (Revision: 588719)
Bad build : 71.0.3544.0 (Revision: 589076)

Narrow Bisect info:
https://chromium.googlesource.com/chromium/src/+log/212d5c5369080305b74a1bb65fab755b2dec2a72..f107e6c78054dca34047d4a029f92b9d3bff7177

Suspect: r588741 ?

@sweilun: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note: 
1. Tried performing 'per revision' bisect on multiple Mac, Windows and Linux machines but unable to perform the same since getting following error: 
   (a) Error message on Mac, Windows and Linux OS : Unable to find locale data files 
   Hence providing suspect from chromium bisect.

Thank You!
 
Actual_video.mp4
449 KB View Download
Expected_video.mp4
362 KB View Download

Comment 1 Deleted

Status: Started (was: Assigned)
This is working as expected. Currently, whenever the notification bar floats down (either by clicking button on the bar or timeout), we will refocus on the omnibox. If we want to fix this, we can change the logic to if we type enter on the buttons, we refocus on the omnibox. If we click it or wait until timeout, we blur the onfocus button(lose focus). But I don't know if it's worth to introduce the extra logic. wdyt?

I don't think it's worth it.
Status: WontFix (was: Started)

Sign in to add a comment