"SitePerProcessHitTestDataGenerationBrowserTest.PointerEventsNoneOOPIF/2" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 32 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyUgsSBUZsYWtlIkdTaXRlUGVyUHJvY2Vzc0hpdFRlc3REYXRhR2VuZXJhdGlvbkJyb3dzZXJUZXN0LlBvaW50ZXJFdmVudHNOb25lT09QSUYvMgw. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
+sunxd, assigning as the flaky test was introduced in https://chromium-review.googlesource.com/c/chromium/src/+/1127440
Issue 881789 has been merged into this issue.
Adding a few relevant CCs. This test is *really* janking the bots, so it would be nice to find a fix fairly soon, or if not disable the /2 variant.
It looks like this test enables pointer events on the OOPIF. However it then only waits for hit test data on the root. That wait would be racing vs the child frame submitting its hit test data.
I'll disable the test first then investigate.
Issue 881888 has been merged into this issue.
The original patch has been reverted. I'll land it with a solution for the test.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c02c059891de67fa3b2ef879a322f5b01db87ab8 commit c02c059891de67fa3b2ef879a322f5b01db87ab8 Author: sunxd <sunxd@chromium.org> Date: Wed Sep 12 18:27:22 2018 Reland: Do not hit test OOPIFs with pointer-events: none Frame owners may have pointer-events: none property which blocks them from receiving mouse and touch events. Currently in V2 viz hit testing hit test data provider has no information about whether OOPIFs have pointer-events: none property. This CL plumbs pointer-events: none property from HTMLFrameOwnerElement to cc::SurfaceLayer so that the hit test data provider in LayerTreeHostImpl will be able to generate proper hit test data for pointer-events: none OOPIFs. The patch was reverted due to flaky browser test, we are relanding it by fixing the flakiness. The original patch also triggered a clusterfuzz bug, it is also fixed in this one. Bug: 841358 , 881917 , 881703 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I66bf72095e5501c37b01beda134a583bf216c5b7 Reviewed-on: https://chromium-review.googlesource.com/1213538 Commit-Queue: Xianda Sun <sunxd@chromium.org> Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Jonathan Ross <jonross@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Reviewed-by: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#590755} [modify] https://crrev.com/c02c059891de67fa3b2ef879a322f5b01db87ab8/cc/layers/surface_layer.cc [modify] https://crrev.com/c02c059891de67fa3b2ef879a322f5b01db87ab8/cc/layers/surface_layer.h [modify] https://crrev.com/c02c059891de67fa3b2ef879a322f5b01db87ab8/cc/layers/surface_layer_impl.cc [modify] https://crrev.com/c02c059891de67fa3b2ef879a322f5b01db87ab8/cc/layers/surface_layer_impl.h [modify] https://crrev.com/c02c059891de67fa3b2ef879a322f5b01db87ab8/cc/trees/layer_tree_host_impl.cc [modify] https://crrev.com/c02c059891de67fa3b2ef879a322f5b01db87ab8/components/viz/common/features.cc [modify] https://crrev.com/c02c059891de67fa3b2ef879a322f5b01db87ab8/content/browser/site_per_process_hit_test_browsertest.cc [modify] https://crrev.com/c02c059891de67fa3b2ef879a322f5b01db87ab8/content/renderer/browser_plugin/browser_plugin.cc [modify] https://crrev.com/c02c059891de67fa3b2ef879a322f5b01db87ab8/content/renderer/browser_plugin/browser_plugin.h [modify] https://crrev.com/c02c059891de67fa3b2ef879a322f5b01db87ab8/content/renderer/child_frame_compositing_helper.cc [modify] https://crrev.com/c02c059891de67fa3b2ef879a322f5b01db87ab8/content/renderer/child_frame_compositing_helper.h [modify] https://crrev.com/c02c059891de67fa3b2ef879a322f5b01db87ab8/content/renderer/child_frame_compositing_helper_unittest.cc [modify] https://crrev.com/c02c059891de67fa3b2ef879a322f5b01db87ab8/content/renderer/child_frame_compositor.h [modify] https://crrev.com/c02c059891de67fa3b2ef879a322f5b01db87ab8/content/renderer/render_frame_proxy.cc [modify] https://crrev.com/c02c059891de67fa3b2ef879a322f5b01db87ab8/content/renderer/render_frame_proxy.h [modify] https://crrev.com/c02c059891de67fa3b2ef879a322f5b01db87ab8/content/test/data/frame_tree/page_with_positioned_frame_pointer-events_none.html [modify] https://crrev.com/c02c059891de67fa3b2ef879a322f5b01db87ab8/third_party/blink/public/web/web_remote_frame.h [modify] https://crrev.com/c02c059891de67fa3b2ef879a322f5b01db87ab8/third_party/blink/public/web/web_remote_frame_client.h [modify] https://crrev.com/c02c059891de67fa3b2ef879a322f5b01db87ab8/third_party/blink/renderer/core/exported/web_remote_frame_impl.cc [modify] https://crrev.com/c02c059891de67fa3b2ef879a322f5b01db87ab8/third_party/blink/renderer/core/exported/web_remote_frame_impl.h [modify] https://crrev.com/c02c059891de67fa3b2ef879a322f5b01db87ab8/third_party/blink/renderer/core/frame/remote_frame.cc [modify] https://crrev.com/c02c059891de67fa3b2ef879a322f5b01db87ab8/third_party/blink/renderer/core/frame/remote_frame.h [modify] https://crrev.com/c02c059891de67fa3b2ef879a322f5b01db87ab8/third_party/blink/renderer/core/frame/remote_frame_client.h [modify] https://crrev.com/c02c059891de67fa3b2ef879a322f5b01db87ab8/third_party/blink/renderer/core/frame/remote_frame_client_impl.cc [modify] https://crrev.com/c02c059891de67fa3b2ef879a322f5b01db87ab8/third_party/blink/renderer/core/frame/remote_frame_client_impl.h [modify] https://crrev.com/c02c059891de67fa3b2ef879a322f5b01db87ab8/third_party/blink/renderer/core/html/html_frame_owner_element.cc [modify] https://crrev.com/c02c059891de67fa3b2ef879a322f5b01db87ab8/third_party/blink/renderer/core/html/html_frame_owner_element.h [modify] https://crrev.com/c02c059891de67fa3b2ef879a322f5b01db87ab8/third_party/blink/renderer/core/layout/layout_embedded_content.cc [modify] https://crrev.com/c02c059891de67fa3b2ef879a322f5b01db87ab8/ui/compositor/layer_unittest.cc
Comment 1 by lizeb@chromium.org
, Sep 7Status: Assigned (was: Untriaged)