New issue
Advanced search Search tips

Issue 881700 link

Starred by 1 user
Status: Fixed
Owner:
f...@opera.com
Closed: Sep 7
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Updating clipPath transform not working on Chrome

Reported by alexande...@gmail.com, Sep 7 
Chrome Version       : 69.0.3497.81
OS Version: OS X 10.13.1
URLs (if applicable) : https://codesandbox.io/s/4rz9zmvj79
Other browsers tested:
  Add OK or FAIL after other browsers where you have tested this issue:
     Safari: FAIL
    Firefox: OK

What steps will reproduce the problem?
1. Go to that codesandbox link
2. Click on the button
3. See that the transform changes in the DOM, but the div that uses that clipPath doesn't update 

What is the expected result?
The clipPath transform updates, and the div is revealed

What happens instead of that?
Nothing

Please provide any additional information below. Attach a screenshot if
possible.

UserAgentString: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3497.81 Safari/537.36

Comment 1 by f...@opera.com, Sep 7

Components: Blink>SVG
Labels: -Pri-3 OS-Android OS-Linux OS-Windows Pri-2
Status: Available (was: Unconfirmed)
Confirmed. Presumably this is also true for other attributes (and in the case of 'transform' also if specifying it as a CSS property.)

Comment 2 by f...@opera.com, Sep 7 

'clipPathUnits' appears to be working fine, so hopefully "only" 'transform' is affected.
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2303c8fe0f48572d6acc2be70057681b3a5008d8

commit 2303c8fe0f48572d6acc2be70057681b3a5008d8
Author: Fredrik Söderquist <fs@opera.com>
Date: Fri Sep 07 14:14:46 2018

Invalidate clipPath clients after mutating 'transform'

When the 'transform' presentation attribute (or CSS property) was
mutated on a <clipPath>, its clients were not notified. Make sure they
are.

Bug:  881700 
Change-Id: Id42aedf814472d8156804a955e6bbf2aa2792ec2
Reviewed-on: https://chromium-review.googlesource.com/1213142
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#589511}
[add] https://crrev.com/2303c8fe0f48572d6acc2be70057681b3a5008d8/third_party/WebKit/LayoutTests/css3/masking/clip-path-css-transform-mutated-expected.html
[add] https://crrev.com/2303c8fe0f48572d6acc2be70057681b3a5008d8/third_party/WebKit/LayoutTests/css3/masking/clip-path-css-transform-mutated.html
[add] https://crrev.com/2303c8fe0f48572d6acc2be70057681b3a5008d8/third_party/WebKit/LayoutTests/css3/masking/clip-path-transform-mutated-expected.html
[add] https://crrev.com/2303c8fe0f48572d6acc2be70057681b3a5008d8/third_party/WebKit/LayoutTests/css3/masking/clip-path-transform-mutated.html
[modify] https://crrev.com/2303c8fe0f48572d6acc2be70057681b3a5008d8/third_party/blink/renderer/core/layout/svg/layout_svg_resource_clipper.cc
[modify] https://crrev.com/2303c8fe0f48572d6acc2be70057681b3a5008d8/third_party/blink/renderer/core/layout/svg/layout_svg_resource_clipper.h
[modify] https://crrev.com/2303c8fe0f48572d6acc2be70057681b3a5008d8/third_party/blink/renderer/core/layout/svg/layout_svg_resource_container.h

Comment 4 by f...@opera.com, Sep 7

Owner: f...@opera.com
Status: Fixed (was: Available)
►

Sign in to add a comment