Issue 881697  has been merged into this issue.

It seems like that the code size on mac rel increased by 44kb.

Regression ranges: chromium: 589275 - 589324

findit Findit (?) suspects CL 589284 with 80% confidence.
https://chromium-review.googlesource.com/c/chromium/src/+/1187231
findit Findit (?) suspects CL 589415 with 83% confidence.
https://chromium-review.googlesource.com/c/chromium/src/+/1205477

https://findit-for-me.appspot.com/waterfall/failure?url=https://build.chromium.org/p/chromium/builders/mac-rel/builds/546

I'm not sure whether or not this is expected and/or acceptable.  ccameron@ and ekaramad@, would you please address the issue and update the expected code size appropriately if this is expected?

I find r589415 unlikely, but that change is a necessary change.

I doubt r589284 is the cause. Nonetheless it has been reverted here:
https://chromium-review.googlesource.com/c/chromium/src/+/1213148

It's not the code size change we care about, it's the addition of a static initializer.

I think  you need to move kSupportedMimeTypes inside an accessor function. See https://chromium.googlesource.com/chromium/src/+/master/docs/static_initializers.md .

I am sending a reland soon to remove the static init. 

That said, the bot is still red even after the revert:

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/mac-rel/554

The bot is still red because in the meantime, more static initializers were added in https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/mac-rel/552.

I'm going to revert https://chromium-review.googlesource.com/c/chromium/src/+/1212862.

Revert: https://crrev.com/c/1213705

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dce6d45e03ac15b11191948e51f4157f03d18047

commit dce6d45e03ac15b11191948e51f4157f03d18047
Author: Ehsan Karamad <ekaramad@chromium.org>
Date: Sun Sep 09 18:49:19 2018

Reland "Implement MimeHandlerViewFrameController"

The initial attempt was causeing build failures in "mac-rel" bot.

The cause seems to be the use of static initializers. This CL
moves them to a method.

This is a reland of 92df23c1ce15615ba52698264485e8785103492c

Original change's description:
> Implement MimeHandlerViewFrameController
>
> This CL implements the renderer side of MimeHandlerView based on
> cross-process frames (behind a flag).
>
> The new subclass of MimeHandlerViewContainerBase will use a content
> frame inside a plugin element for loading the MimeHandlerViewGuest's
> extension.
>
> The current implementation is not complete and the missing features
> such as postMessage support will be added in the follow-up CLs.
>
> This CL also introduces a new class of parametric browser tests
> (MimeHandlerViewCrossProcessTest) which will be the destination of
> the current MimeHandlerViewTests as more features are integrated into
> the frame-based version. The new test class runs the test on both
> BrowserPlugin-based and cross-process-frame-based versions.
>
> Document: https://docs.google.com/document/d/10g7Y9cprYKkch9JZ0TBUWaEnHBJT1nzhskQIt1nHbWM/edit#heading=h.qw81a2bk3v6w
>
> Bug: 659750
> TBR=thestig@chromium.org
>
> Change-Id: Ia69aeed47f4fa1c7f5b81cdde71a8d8b5ff59165
> Reviewed-on: https://chromium-review.googlesource.com/1187231
> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
> Reviewed-by: Sam McNally <sammc@chromium.org>
> Reviewed-by: Ehsan Karamad <ekaramad@chromium.org>
> Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
> Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
> Reviewed-by: James MacLean <wjmaclean@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#589284}

TBR=alexmos@chromium.org,lazyboy@chromium.org,sammc@chromium.org,wjmaclean@chromium.org

Bug: 659750,  881696 
Change-Id: I94c779664981738222c8d79ca0b10ab06174a4a7
Reviewed-on: https://chromium-review.googlesource.com/1213369
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Ehsan Karamad <ekaramad@chromium.org>
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589807}
[modify] https://crrev.com/dce6d45e03ac15b11191948e51f4157f03d18047/chrome/renderer/chrome_content_renderer_client.cc
[modify] https://crrev.com/dce6d45e03ac15b11191948e51f4157f03d18047/chrome/renderer/chrome_content_renderer_client.h
[modify] https://crrev.com/dce6d45e03ac15b11191948e51f4157f03d18047/chrome/renderer/extensions/chrome_extensions_renderer_client.cc
[modify] https://crrev.com/dce6d45e03ac15b11191948e51f4157f03d18047/chrome/renderer/extensions/chrome_extensions_renderer_client.h
[modify] https://crrev.com/dce6d45e03ac15b11191948e51f4157f03d18047/components/guest_view/renderer/guest_view_container_dispatcher.h
[modify] https://crrev.com/dce6d45e03ac15b11191948e51f4157f03d18047/content/browser/browser_plugin/browser_plugin_guest.cc
[modify] https://crrev.com/dce6d45e03ac15b11191948e51f4157f03d18047/content/browser/browser_plugin/browser_plugin_guest.h
[modify] https://crrev.com/dce6d45e03ac15b11191948e51f4157f03d18047/content/public/browser/guest_host.h
[modify] https://crrev.com/dce6d45e03ac15b11191948e51f4157f03d18047/content/public/renderer/content_renderer_client.cc
[modify] https://crrev.com/dce6d45e03ac15b11191948e51f4157f03d18047/content/public/renderer/content_renderer_client.h
[modify] https://crrev.com/dce6d45e03ac15b11191948e51f4157f03d18047/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/dce6d45e03ac15b11191948e51f4157f03d18047/extensions/browser/guest_view/extensions_guest_view_message_filter.cc
[modify] https://crrev.com/dce6d45e03ac15b11191948e51f4157f03d18047/extensions/browser/guest_view/extensions_guest_view_message_filter.h
[modify] https://crrev.com/dce6d45e03ac15b11191948e51f4157f03d18047/extensions/browser/guest_view/mime_handler_view/mime_handler_view_constants.cc
[modify] https://crrev.com/dce6d45e03ac15b11191948e51f4157f03d18047/extensions/browser/guest_view/mime_handler_view/mime_handler_view_constants.h
[modify] https://crrev.com/dce6d45e03ac15b11191948e51f4157f03d18047/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc
[modify] https://crrev.com/dce6d45e03ac15b11191948e51f4157f03d18047/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.h
[modify] https://crrev.com/dce6d45e03ac15b11191948e51f4157f03d18047/extensions/common/mojo/guest_view.mojom
[modify] https://crrev.com/dce6d45e03ac15b11191948e51f4157f03d18047/extensions/renderer/BUILD.gn
[modify] https://crrev.com/dce6d45e03ac15b11191948e51f4157f03d18047/extensions/renderer/guest_view/extensions_guest_view_container_dispatcher.cc
[modify] https://crrev.com/dce6d45e03ac15b11191948e51f4157f03d18047/extensions/renderer/guest_view/extensions_guest_view_container_dispatcher.h
[modify] https://crrev.com/dce6d45e03ac15b11191948e51f4157f03d18047/extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc
[modify] https://crrev.com/dce6d45e03ac15b11191948e51f4157f03d18047/extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.h
[modify] https://crrev.com/dce6d45e03ac15b11191948e51f4157f03d18047/extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container_base.cc
[modify] https://crrev.com/dce6d45e03ac15b11191948e51f4157f03d18047/extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container_base.h
[add] https://crrev.com/dce6d45e03ac15b11191948e51f4157f03d18047/extensions/renderer/guest_view/mime_handler_view/mime_handler_view_frame_container.cc
[add] https://crrev.com/dce6d45e03ac15b11191948e51f4157f03d18047/extensions/renderer/guest_view/mime_handler_view/mime_handler_view_frame_container.h