New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 881695 link

Starred by 1 user
Status: Fixed
Owner:
yawano@chromium.org
Closed: Sep 12
Cc:
dtseng@chromium.org
lpalmaro@chromium.org
█ shihuis@chromium.org
Components:
EstimatedDays: 1
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug
Team-Accessibility



Sign in to add a comment

TalkBack doesn't work properly if it's switched with Search+A then [ or ]

Project Member Reported by yawano@chromium.org, Sep 7 
Chrome Version: M70 or newer
OS: Chrome

What steps will reproduce the problem?
(1) Enable spoken feedback.
(2) Open any Android window.
(3) Press Search+A then ].

What is the expected result?
TalkBack should work.

What happens instead?
Keyboard navigation and touch explorer is not working properly.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa303f2d8a4733e02ebd5fcb4ccc916a101f8156

commit aa303f2d8a4733e02ebd5fcb4ccc916a101f8156
Author: Yuki Awano <yawano@chromium.org>
Date: Tue Sep 11 00:31:48 2018

Fix TalkBack fallback keyboard shortcut

- Update window properties and detach ax child tree when user switches
  back to TalkBack.

  ]. Confirm that TalkBack works well.

Bug:  881695 
Test: Open any android app with spoken feedback and press Search+A then
Change-Id: I2b5db2d77e49e674e98c1b3cfbb18b2567d69388
Reviewed-on: https://chromium-review.googlesource.com/1212210
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Yuki Awano <yawano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590136}
[modify] https://crrev.com/aa303f2d8a4733e02ebd5fcb4ccc916a101f8156/chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge.cc
[modify] https://crrev.com/aa303f2d8a4733e02ebd5fcb4ccc916a101f8156/chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge.h
[modify] https://crrev.com/aa303f2d8a4733e02ebd5fcb4ccc916a101f8156/components/exo/shell_surface_base.cc

Comment 2 by yawano@chromium.org, Sep 11

Labels: Merge-Request-70
We want to merge the above CL to M70 as ChromeVox native support would become on by default from M70.
Project Member

Comment 3 by sheriffbot@chromium.org, Sep 12

Labels: -Merge-Request-70 Hotlist-Merge-Approved Merge-Approved-70
Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 12

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/116dbde200d83c3bae176b0c53ae10c69121fab5

commit 116dbde200d83c3bae176b0c53ae10c69121fab5
Author: Yuki Awano <yawano@chromium.org>
Date: Wed Sep 12 07:49:24 2018

Fix TalkBack fallback keyboard shortcut

- Update window properties and detach ax child tree when user switches
  back to TalkBack.

  ]. Confirm that TalkBack works well.

Bug:  881695 
Test: Open any android app with spoken feedback and press Search+A then
Change-Id: I2b5db2d77e49e674e98c1b3cfbb18b2567d69388
Reviewed-on: https://chromium-review.googlesource.com/1212210
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Yuki Awano <yawano@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#590136}(cherry picked from commit aa303f2d8a4733e02ebd5fcb4ccc916a101f8156)
Reviewed-on: https://chromium-review.googlesource.com/1220950
Reviewed-by: Yuki Awano <yawano@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#313}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/116dbde200d83c3bae176b0c53ae10c69121fab5/chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge.cc
[modify] https://crrev.com/116dbde200d83c3bae176b0c53ae10c69121fab5/chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge.h
[modify] https://crrev.com/116dbde200d83c3bae176b0c53ae10c69121fab5/components/exo/shell_surface_base.cc

Comment 5 by yawano@chromium.org, Sep 12

Status: Fixed (was: Started)
►

Sign in to add a comment