Issue metadata
Sign in to add a comment
|
Omnibox disappears on loading itunes app URL |
||||||||||||||||||||||
Issue descriptionApp Version: 70.0.3538.8 beta iOS Version: 11.4.1, 10.3.3, 12 beta 12 Device: Phone Other applicable labels: Proj-UIRefresh Steps to reproduce: 1. Launch chrome 2. Go to ‘https://itunes.apple.com/en/app/google-street-view/id904418768?mt=8’ 3. Store kit screen opens up 4. Tap on the Done button Observed results: Notice that omnibox disappears in the tab page Expected results: Omnibox shouldn’t disappear in the tab page and the loaded URL should be displayed in omnibox Note: In iPad the empty omnibox is displayed after dismissing the store kit popup Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: Not tested Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA Bug reproducible on current stable build (App Version, iOS Version): No on M69 Bug reproducible on the current beta channel build (App Version, iOS Version): Yes on M70 beta Link to video: https://drive.google.com/file/d/1s8Jg7yyrt8feOq-X6Alss7Yt4-aP4Qb4/view?usp=sharing
,
Sep 10
Seems like the entire toolbar disappears
,
Sep 11
,
Sep 13
This is way worse. I don't really know what is happening but it is only happening from the NTP. I think we are navigating to the page then trying to navigate back to the NTP but we end up in an about:blank page with a URL of type chrome://newtab/. So the page appears blank. Reloading the app triggers a crash, so marking this as RBS. Adding some ios/web people and people working on itunes link handling.
,
Sep 13
Also adding danyao@ since the empty about:blank page is mentioned here.
,
Sep 19
,
Sep 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8e50c41cb7de428d619c4b853c8de228dcdf6b94 commit 8e50c41cb7de428d619c4b853c8de228dcdf6b94 Author: mrefaat <mrefaat@chromium.org> Date: Thu Sep 20 21:48:23 2018 Fix Omnibox disappears on loading itunes app URL The problem is we discard the last committed item, if the request was blocked, instead we should only discard that when the last item was not native view. Bug: 881690 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I3de1649da8a4d1c198c7f5386cfeb2ef3608033a Reviewed-on: https://chromium-review.googlesource.com/1234953 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#592958} [modify] https://crrev.com/8e50c41cb7de428d619c4b853c8de228dcdf6b94/ios/web/web_state/ui/crw_web_controller.mm
,
Sep 20
,
Sep 20
This bug requires manual review: Less than 22 days to go before AppStore submit on M70 Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 24
Canary verification please.
,
Sep 25
Verified in Build: 71.0.3561.0 Canary Devices: iPhone 6(iOS 11), iPhoneX(iOS 12.0), iPhone 7plus(iOS 10.3.3) Omnibox appears fine on dismissig itunes app URL
,
Sep 26
Approved! Please merge ASAP.
,
Sep 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/539ab45b55a7ba714f9f969d020a0cff79fc85fc commit 539ab45b55a7ba714f9f969d020a0cff79fc85fc Author: mrefaat <mrefaat@chromium.org> Date: Thu Sep 27 03:12:24 2018 [M70] Fix Omnibox disappears on loading itunes app URL The problem is we discard the last committed item, if the request was blocked, instead we should only discard that when the last item was not native view. Bug: 881690 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I3de1649da8a4d1c198c7f5386cfeb2ef3608033a Reviewed-on: https://chromium-review.googlesource.com/1234953 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#592958}(cherry picked from commit 8e50c41cb7de428d619c4b853c8de228dcdf6b94) Reviewed-on: https://chromium-review.googlesource.com/1246461 Cr-Commit-Position: refs/branch-heads/3538@{#699} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/539ab45b55a7ba714f9f969d020a0cff79fc85fc/ios/web/web_state/ui/crw_web_controller.mm
,
Sep 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/539ab45b55a7ba714f9f969d020a0cff79fc85fc Commit: 539ab45b55a7ba714f9f969d020a0cff79fc85fc Author: mrefaat@chromium.org Commiter: mrefaat@chromium.org Date: 2018-09-27 03:12:24 +0000 UTC [M70] Fix Omnibox disappears on loading itunes app URL The problem is we discard the last committed item, if the request was blocked, instead we should only discard that when the last item was not native view. Bug: 881690 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I3de1649da8a4d1c198c7f5386cfeb2ef3608033a Reviewed-on: https://chromium-review.googlesource.com/1234953 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#592958}(cherry picked from commit 8e50c41cb7de428d619c4b853c8de228dcdf6b94) Reviewed-on: https://chromium-review.googlesource.com/1246461 Cr-Commit-Position: refs/branch-heads/3538@{#699} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
,
Oct 3
Verified in: App Version: 70.0.3538.44 beta iOS Versions: 11.4.1, 12.1 beta 2 Devices: iPhone 8, iPad Mini, iPhone 8 Plus Omnibox is displayed on dismissing iTunes app URL |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by olivierrobin@chromium.org
, Sep 7Owner: stkhapugin@chromium.org
Status: Assigned (was: Untriaged)