New issue
Advanced search Search tips

Issue 881685 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 875443



Sign in to add a comment

"MaterialHistoryListTest.All" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Sep 7

Issue description

"MaterialHistoryListTest.All" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 11 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyJgsSBUZsYWtlIhtNYXRlcmlhbEhpc3RvcnlMaXN0VGVzdC5BbGwM.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs

This flaky test/step was previously tracked in  issue 870861 .
 
Detected 6 new flakes for test/step "MaterialHistoryListTest.All". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyJgsSBUZsYWtlIhtNYXRlcmlhbEhpc3RvcnlMaXN0VGVzdC5BbGwM. This message was posted automatically by the chromium-try-flakes app.
Detected 4 new flakes for test/step "MaterialHistoryListTest.All". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyJgsSBUZsYWtlIhtNYXRlcmlhbEhpc3RvcnlMaXN0VGVzdC5BbGwM. This message was posted automatically by the chromium-try-flakes app.
Owner: pkasting@chromium.org
Status: Assigned (was: Untriaged)
Flakes once again on waterfall this morning :

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%281%29/83460

[ RUN      ] MaterialHistoryListTest.All
[2896:6164:0910/065654.671:WARNING:discovery_network_list_win.cc(195)] Failed to open Wlan client handle: 1062
[2896:2520:0910/065654.672:WARNING:chrome_browser_main_win.cc(643)] Command line too long for RegisterApplicationRestart:  --brave-new-test-launcher --cfi-diag=0 --disable-gpu-process-for-dx12-vulkan-info-collection --gtest_also_run_disabled_tests --gtest_filter=MaterialHistoryListTest.All --single_process --test-launcher-bot-mode --test-launcher-filter-file=../../testing/buildbot/filters/webui_polymer2_browser_tests.filter --test-launcher-output="e:\b\s\w\itell43d\scoped_dir6944_1707\results6944_29157\test_results.xml" --test-launcher-summary-output="e:\b\s\w\ioxg4u1z\output.json" --user-data-dir="e:\b\s\w\itell43d\scoped_dir6944_1707\d6944_5096" --disable-offline-auto-reload --enable-blink-features=MojoJSTest --no-first-run --no-default-browser-check --enable-logging=stderr --disable-default-apps --wm-window-animations-disabled --disable-component-update --test-type=browser --force-color-profile=srgb --disable-zero-browsers-open-for-tests --ipc-connection-timeout=30 --allow-file-access-from-files --dom-automation --log-gpu-control-list-decisions --disable-backgrounding-occluded-windows --disable-gl-drawing-for-tests --override-use-software-gl-for-tests --force-color-profile=srgb --disable-compositor-ukm-for-tests --enable-features=TestFeatureForBrowserTest1,WebUIPolymer2 --disable-features=TestFeatureForBrowserTest2 --disable-gpu-process-for-dx12-vulkan-info-collection --flag-switches-begin --flag-switches-end --file-url-path-alias="/gen=e:\b\s\w\ir\out\Release\gen" --restore-last-session about:blank
[2896:2520:0910/065654.778:ERROR:input_method_base.cc(146)] NOT IMPLEMENTEDUsing InputMethodKeyboardControllerStub
[2896:2520:0910/065655.252:WARNING:CONSOLE(0)] "HTML Imports is deprecated and will be removed in M73, around March 2019. Please use ES modules instead. See https://www.chromestatus.com/features/5144752345317376 for more details.", source:  (0)
[2896:2520:0910/065655.418:INFO:CONSOLE(1236)] "Running TestCase MaterialHistoryListTest.MAYBE_All", source: file:///E:/b/s/w/ir/chrome/test/data/webui/test_api.js (1236)
[2896:2520:0910/065656.584:ERROR:CONSOLE(48)] "Mocha test failed: <history-list> updating history results
TypeError: Cannot read property 'isCardEnd' of undefined
    at file:///E:/b/s/w/ir/chrome/test/data/webui/md_history/history_list_test.js:223:27
", source: file:///E:/b/s/w/ir/chrome/test/data/webui/mocha_adapter.js (48)
[2896:2520:0910/065657.445:ERROR:web_ui_test_handler.cc(100)] Test Errors: 1/17 tests had failed assertions.
[2896:2520:0910/065657.445:ERROR:web_ui_browser_test.cc(481)] CONDITION FAILURE: encountered javascript console error(s):
[2896:2520:0910/065657.445:ERROR:web_ui_browser_test.cc(483)] JS ERROR: '[2896:2520:0910/065656.584:ERROR:CONSOLE(48)] "Mocha test failed: <history-list> updating history results
TypeError: Cannot read property 'isCardEnd' of undefined
    at file:///E:/b/s/w/ir/chrome/test/data/webui/md_history/history_list_test.js:223:27
", source: file:///E:/b/s/w/ir/chrome/test/data/webui/mocha_adapter.js (48)
'
[2896:2520:0910/065657.445:ERROR:web_ui_browser_test.cc(485)] JS call assumed failed, because JS console error(s) found.
gen/chrome/test/data/webui/md_history/md_history_browsertest-gen.cc(145): error: Value of: RunJavascriptTestF( true, "MaterialHistoryListTest", "MAYBE_All")
  Actual: false
Expected: true
Stack trace:
Backtrace:
	StackTraceGetter::CurrentStackTrace [0x019824A8+40]
	testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop [0x0198ABCB+69]
	testing::internal::AssertHelper::operator= [0x0198A830+48]
	MaterialHistoryListTest_All_Test::RunTestOnMainThread [0x018436BE+638]
	content::BrowserTestBase::ProxyRunTestOnMainThreadLoop [0x032488B5+373]
	ChromeBrowserMainParts::PreMainMessageLoopRunImpl [0x03DE093D+3877]
	ChromeBrowserMainParts::PreMainMessageLoopRun [0x03DDF95B+139]
	content::BrowserMainLoop::PreMainMessageLoopRun [0x02293F44+68]
	content::StartupTaskRunner::RunAllTasksNow [0x02541758+36]
	content::BrowserMainLoop::CreateStartupTasks [0x02292BDC+554]
	content::BrowserMainRunnerImpl::Initialize [0x02295F16+102]
	content::BrowserMain [0x022912EE+138]
	content::RunBrowserProcessMain [0x0300E0BC+84]
	content::ContentMainRunnerImpl::Run [0x0300E7E2+402]
	content::ContentServiceManagerMainDelegate::RunEmbedderProcess [0x0300DD83+19]
	service_manager::Main [0x036C7E72+354]
	content::ContentMain [0x0300E00F+51]
	content::BrowserTestBase::SetUp [0x0324866D+1549]
[2896:2520:0910/065657.699:WARNING:pref_notifier_impl.cc(23)] Pref observer found at shutdown.
[2896:2520:0910/065657.699:WARNING:pref_notifier_impl.cc(23)] Pref observer found at shutdown.
[  FAILED  ] MaterialHistoryListTest.All, where TypeParam =  and GetParam() =  (3094 ms)
@pkasting : please disable if culprit can't be identified. Seems this was already identified as flaky in the past ( issue 669227 ). Do we need to also disable on OS_WIN?
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68de2da8c6c03ff90be677f39900189fe4fec7df

commit 68de2da8c6c03ff90be677f39900189fe4fec7df
Author: Gabriel Charette <gab@chromium.org>
Date: Mon Sep 10 18:49:26 2018

[Flaky tests] Disable MaterialHistoryListTest.All on Windows

TBR=rbpotter@chromium.org

Bug:  881685 
Change-Id: I26cf5783d26d7dfadd53b1db890b09d14fb09a7e
Reviewed-on: https://chromium-review.googlesource.com/1216625
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590000}
[modify] https://crrev.com/68de2da8c6c03ff90be677f39900189fe4fec7df/chrome/test/data/webui/md_history/md_history_browsertest.js

Cc: rbpotter@chromium.org
Labels: -Sheriff-Chromium
+rbpotter as owner of this test data set. -sheriffs since test is disabled
Cc: aee@chromium.org
+aee who was working on the MD History tests (related  bug 875461 ).
Cc: -rbpotter@chromium.org
Owner: rbpotter@chromium.org
I'm not actually sure how I'm connected to this... it sounds like maybe rbpotter is a better nominal owner?
Labels: Sheriff-Chromium
Detected 10 new flakes for test/step "MaterialHistoryListTest.All". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyJgsSBUZsYWtlIhtNYXRlcmlhbEhpc3RvcnlMaXN0VGVzdC5BbGwM. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
Labels: -Sheriff-Chromium
Test disabled @ r590000, last flake @ r589971, -sheriffs
Blocking: 875443
Project Member

Comment 12 by bugdroid1@chromium.org, Oct 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b86d5480a40752a1e05573791415c1a50c41c5d6

commit b86d5480a40752a1e05573791415c1a50c41c5d6
Author: rbpotter <rbpotter@chromium.org>
Date: Tue Oct 09 02:06:39 2018

History UI: Fix HistoryListTest to pass consistently with Polymer2

Reproduced test failure locally on Windows 10, using gtest_repeat=5.
With changes, test passed with gtest_repeat=20.

Bug:  881685 
Change-Id: I585460175e3014f1886c344a0326d1fe7814daa7
Reviewed-on: https://chromium-review.googlesource.com/c/1266299
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597777}
[modify] https://crrev.com/b86d5480a40752a1e05573791415c1a50c41c5d6/chrome/test/data/webui/md_history/history_list_test.js
[modify] https://crrev.com/b86d5480a40752a1e05573791415c1a50c41c5d6/testing/buildbot/filters/webui_polymer2_browser_tests.filter

Status: Fixed (was: Assigned)

Sign in to add a comment