New issue
Advanced search Search tips

Issue 881682 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 8
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

VideoCaptureDeviceTests CaptureMjpeg and CaptureWithSize failing with LKGM 11042.0.0

Project Member Reported by achuith@chromium.org, Sep 7

Issue description

LKGM is failing because of capture_unittest failures:
https://chromium-review.googlesource.com/c/chromium/src/+/1212447

Failing runs:
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/chromeos-amd64-generic-rel/83565
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/chromeos-amd64-generic-rel/83598

Crashing stack:
[ RUN      ] VideoCaptureDeviceTests/VideoCaptureDeviceTest.CaptureMjpeg/1
[3075:3075:0906/203731.947207:71494607:FATAL:camera_hal_dispatcher_impl.cc(105)] Check failed: !proxy_thread_.IsRunning(). 
#0 0x5d31b555dfac base::debug::StackTrace::StackTrace()
#1 0x5d31b5508fdb logging::LogMessage::~LogMessage()
#2 0x5d31b54e7fe2 media::CameraHalDispatcherImpl::StartThreads()
#3 0x5d31b54e8278 media::CameraHalDispatcherImpl::Start()
#4 0x5d31b5013a17 media::VideoCaptureDeviceTest::VideoCaptureDeviceTest()
#5 0x5d31b5016d16 testing::internal::ParameterizedTestFactory<>::CreateTest()
#6 0x5d31b53aeb06 testing::TestInfo::Run()
#7 0x5d31b53af0a7 testing::TestCase::Run()
#8 0x5d31b53bbd87 testing::internal::UnitTestImpl::RunAllTests()
#9 0x5d31b53bb8eb testing::UnitTest::Run()
#10 0x5d31b53f5e0e base::TestSuite::Run()
#11 0x5d31b53f7edf base::(anonymous namespace)::LaunchUnitTestsInternal()
#12 0x5d31b53f7d2e base::LaunchUnitTests()
#13 0x5d31b4fd1f1d main
#14 0x7d3b76120736 __libc_start_main
#15 0x5d31b4fb7339 _start

I think this one also failed:
[ RUN      ] VideoCaptureDeviceTests/VideoCaptureDeviceTest.CaptureWithSize/1
[3880:3901:0906/212351.428266:544380922:ERROR:camera_hal_dispatcher_impl.cc(267)] chown(): No such file or directory (2)
[3880:3880:0906/212351.429329:544381938:ERROR:video_capture_device_factory_chromeos.cc(76)] CameraHalDispatcherImpl is not started
[3880:3880:0906/212351.430310:544382921:WARNING:video_capture_device_unittest.cc(323)] No camera found
[3880:3880:0906/212351.430920:544383531:FATAL:scoped_refptr.h(219)] Check failed: ptr_. 
#0 0x594c11b3cfac base::debug::StackTrace::StackTrace()
#1 0x594c11ae7fdb logging::LogMessage::~LogMessage()
#2 0x594c11adb2f6 media::VideoCaptureDeviceFactoryChromeOS::~VideoCaptureDeviceFactoryChromeOS()
#3 0x594c11adb39e media::VideoCaptureDeviceFactoryChromeOS::~VideoCaptureDeviceFactoryChromeOS()
#4 0x594c115f2340 media::VideoCaptureDeviceTest::~VideoCaptureDeviceTest()
#5 0x594c115f24ae media::VideoCaptureDeviceTest_TakePhoto_Test::~VideoCaptureDeviceTest_TakePhoto_Test()
#6 0x594c1198dbce testing::TestInfo::Run()
#7 0x594c1198e0a7 testing::TestCase::Run()
#8 0x594c1199ad87 testing::internal::UnitTestImpl::RunAllTests()
#9 0x594c1199a8eb testing::UnitTest::Run()
#10 0x594c119d4e0e base::TestSuite::Run()
#11 0x594c119d6edf base::(anonymous namespace)::LaunchUnitTestsInternal()
#12 0x594c119d6d2e base::LaunchUnitTests()
#13 0x594c115b0f1d main
#14 0x7c4c7ad1e736 __libc_start_main
#15 0x594c11596339 _start
 
Cc: tfiga@chromium.org jcliang@chromium.org shik@chromium.org posciak@chromium.org henryhsu@chromium.org
Components: OS>Kernel>Camera
I thought this is caused by this CL.
https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/1201651
This enabled cros-camera, which is our new camera stack, on amd64-generic.

Ricky, Tomasz, should we revert this CL?
The chromeos change will take days to propagate through the CQ+PFQ, and the LKGM will be stuck until it does.

Perhaps the easiest thing to do would be to disable the failing tests on chromeos.

We should run capture_unittests as an autotest in the cros waterfall to prevent future failures of this nature.
We found that capture_unittests has to be executed with "--test-launcher-jobs=1" option, but isn't.
I made sure that capture_unittests worked with this argument well on amd64-generic VM locally.

I created crrev.com/c/1212433. Hope it would work.

Achuith, is there any way to make sure if my CL will fix the problem on before it is merged?
Status: Started (was: Untriaged)
I think you can combine your CL with the LKGM CL below and send it to the chromeos-amd64-generic-rel trybot to see if it passes:
https://chromium-review.googlesource.com/c/chromium/src/+/1212447


Project Member

Comment 8 by bugdroid1@chromium.org, Sep 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c494421ca78af00437f5fc464dbaad91357811e

commit 7c494421ca78af00437f5fc464dbaad91357811e
Author: Keiichi Watanabe <keiichiw@chromium.org>
Date: Fri Sep 07 20:56:33 2018

testing/buildbot: Run capture_unittests in single process on ChromeOS

The current ChromeOS's camera stack (cros-camera) assumes that
capture_unittests would run in a single process.

Bug:  881682 
Change-Id: I7a89f63ee16c7eb97b83b15ed46ee8061d1d601d
Reviewed-on: https://chromium-review.googlesource.com/1212433
Commit-Queue: Keiichi Watanabe <keiichiw@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589621}
[modify] https://crrev.com/7c494421ca78af00437f5fc464dbaad91357811e/testing/buildbot/chromium.chromiumos.json
[modify] https://crrev.com/7c494421ca78af00437f5fc464dbaad91357811e/testing/buildbot/test_suites.pyl

Status: Fixed (was: Started)
LKGM was successfully updated to 11042.0.0.
https://chromium-review.googlesource.com/c/chromium/src/+/1212447

Sign in to add a comment